Skip to contentSkip to conversation

m68k: Fix two occurrences of the checkpatch.pl error:

PATCH In review [email protected] 2 participants 2 messages Jul 21, 2023 – Jul 24, 2023 1 message not in the archive m68k architecture

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 m68k: Fix two occurrences of the checkpatch.pl error:

ERROR: that open brace { should be on the previous line
ERROR: space required after that ',' (ctx:VxV)

---
 arch/m68k/q40/config.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/m68k/q40/config.c +2 -3
index c78ee709b458..62ed3634c0a4 100644
@@ -146,9 +146,8 @@ static void q40_get_model(char *model)
 	sprintf(model, "Q40");
 }
 
-static unsigned int serports[] =
-{
-	0x3f8,0x2f8,0x3e8,0x2e8,0
+static unsigned int serports[] = {
+	0x3f8, 0x2f8, 0x3e8, 0x2e8, 0
 };
 
 static void __init q40_disable_irqs(void)
#2 lore raw

Hi Ran,

Quoted 4 lines · On Fri, Jul 21, 2023 at 10:04 AM <[email protected]> wrote:

ERROR: that open brace { should be on the previous line
ERROR: space required after that ',' (ctx:VxV)

Thanks for your patch!

But obviously you forgot to run scripts/checkpatch.pl on your own patch:

WARNING: A patch subject line should describe the change not the
tool that found it
#2:
Subject: [PATCH] m68k: Fix two occurrences of the checkpatch.pl error:

WARNING: From:/Signed-off-by: email name mismatch: 'From:
[email protected]' != 'Signed-off-by: Ran Sun <[email protected]>'

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds