opp: Unconditionally call dev_pm_opp_of_remove_table()
Subsystems (11)
Viresh Kumar
maintainerv2 cover opp: Unconditionally call dev_pm_opp_of_remove_table()
Hello,
This cleans up some of the user code around calls to dev_pm_opp_of_remove_table().
All the patches can be picked by respective maintainers directly except for the last patch, which needs the previous two to get merged first.
These are based for 5.9-rc1.
Rajendra, Since most of these changes are related to qcom stuff, it would be great if you can give them a try. I wasn't able to test them due to lack of hardware.
Ulf, I had to revise the sdhci patch, sorry about that. Please pick this one.
Diff between V1 and V2 is mentioned in each of the patches separately.
Viresh Kumar (8):
cpufreq: imx6q: Unconditionally call dev_pm_opp_of_remove_table() drm/lima: Unconditionally call dev_pm_opp_of_remove_table() drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
spi: spi-geni-qcom: Unconditionally call dev_pm_opp_of_remove_table()
spi: spi-qcom-qspi: Unconditionally call dev_pm_opp_of_remove_table()
tty: serial: qcom_geni_serial: Unconditionally call
dev_pm_opp_of_remove_table()
qcom-geni-se: remove has_opp_table
drivers/cpufreq/imx6q-cpufreq.c | 10 ++-------- drivers/gpu/drm/lima/lima_devfreq.c | 6 +----- drivers/gpu/drm/lima/lima_devfreq.h | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 14 +++++--------- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 - drivers/gpu/drm/msm/dsi/dsi_host.c | 8 ++------ drivers/mmc/host/sdhci-msm.c | 14 +++++--------- drivers/spi/spi-geni-qcom.c | 13 +++++-------- drivers/spi/spi-qcom-qspi.c | 15 ++++++--------- drivers/tty/serial/qcom_geni_serial.c | 13 +++++-------- include/linux/qcom-geni-se.h | 2 -- 11 files changed, 31 insertions(+), 66 deletions(-)
base-commit: 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Viresh Kumar
maintainerPATCH v2 1/8 cpufreq: imx6q: Unconditionally call dev_pm_opp_of_remove_table()
dev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here.
---
V2: No changes.
--- drivers/cpufreq/imx6q-cpufreq.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/cpufreq/imx6q-cpufreq.c +2 -8
@@ -48,7 +48,6 @@ static struct clk_bulk_data clks[] = { };static struct device *cpu_dev; -static bool free_opp;static struct cpufreq_frequency_table *freq_table;static unsigned int max_freq;static unsigned int transition_latency;
@@ -390,9 +389,6 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) goto put_reg; } -/* Because we have added the OPPs here, we must free them */ - free_opp = true; -if (of_machine_is_compatible ("fsl,imx6ul" ) ||of_machine_is_compatible ("fsl,imx6ull" )) { ret =imx6ul_opp_check_speed_grading (cpu_dev);
@@ -507,8 +503,7 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) free_freq_table:dev_pm_opp_free_cpufreq_table (cpu_dev, &freq_table); out_free_opp: -if (free_opp) -dev_pm_opp_of_remove_table (cpu_dev); +dev_pm_opp_of_remove_table (cpu_dev); put_reg:if (!IS_ERR (arm_reg))regulator_put (arm_reg);
@@ -528,8 +523,7 @@ static int imx6q_cpufreq_remove(struct platform_device *pdev) {cpufreq_unregister_driver (&imx6q_cpufreq_driver);dev_pm_opp_free_cpufreq_table (cpu_dev, &freq_table); -if (free_opp) -dev_pm_opp_of_remove_table (cpu_dev); +dev_pm_opp_of_remove_table (cpu_dev);regulator_put (arm_reg);if (!IS_ERR (pu_reg))regulator_put (pu_reg);
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Viresh Kumar
maintainerPATCH v2 2/8 drm/lima: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Viresh Kumardev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here.
---
V2: Applied Reviewed by tag.
--- drivers/gpu/drm/lima/lima_devfreq.c | 6 +----- drivers/gpu/drm/lima/lima_devfreq.h | 1 - 2 files changed, 1 insertion(+), 6 deletions(-)
drivers/gpu/drm/lima/lima_devfreq.c +1 -5
@@ -105,10 +105,7 @@ void lima_devfreq_fini(struct lima_device *ldev) devfreq->devfreq =NULL ; } -if (devfreq->opp_of_table_added) { -dev_pm_opp_of_remove_table (ldev->dev); - devfreq->opp_of_table_added = false; - } +dev_pm_opp_of_remove_table (ldev->dev);if (devfreq->regulators_opp_table) {dev_pm_opp_put_regulators (devfreq->regulators_opp_table);
@@ -162,7 +159,6 @@ int lima_devfreq_init(struct lima_device *ldev) ret =dev_pm_opp_of_add_table (dev);if (ret) goto err_fini; - ldevfreq->opp_of_table_added = true;lima_devfreq_reset (ldevfreq);
drivers/gpu/drm/lima/lima_devfreq.h +0 -1
@@ -18,7 +18,6 @@ struct lima_devfreq {struct opp_table *clkname_opp_table;struct opp_table *regulators_opp_table;struct thermal_cooling_device *cooling; -bool opp_of_table_added;ktime_t busy_time;ktime_t idle_time;
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Viresh Kumar
maintainerRe: [PATCH V2 2/8] drm/lima: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 8 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.Reviewed-by Qiang Yu <[email protected]>Signed-off-by Viresh Kumar <[email protected]>
Quoted 6 lines
---
V2: Applied Reviewed by tag.--- drivers/gpu/drm/lima/lima_devfreq.c | 6 +----- drivers/gpu/drm/lima/lima_devfreq.h | 1 - 2 files changed, 1 insertion(+), 6 deletions(-)
Qiang, can you please pick it up ?
Signature · 1 line
viresh
Viresh Kumar
maintainerPATCH v2 3/8 drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Viresh Kumardev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here.
While at it, also create a label to put clkname.
---
V2:
- Compare with -ENODEV only for failures.
- Create new label to put clkname.
--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 14 +++++--------- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 - drivers/gpu/drm/msm/dsi/dsi_host.c | 8 ++------ 3 files changed, 7 insertions(+), 16 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +5 -9
@@ -1010,12 +1010,9 @@ static int dpu_bind(struct device *dev, struct device *master, void *data)return PTR_ERR (dpu_kms->opp_table);/* OPP table is optional */ ret =dev_pm_opp_of_add_table (dev); -if (!ret) { - dpu_kms->has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (dev,"invalid OPP table in device tree\n" ); -dev_pm_opp_put_clkname (dpu_kms->opp_table); -return ret; + goto put_clkname; } mp = &dpu_kms->mp;
@@ -1037,8 +1034,8 @@ static int dpu_bind(struct device *dev, struct device *master, void *data) priv->kms = &dpu_kms->base;return ret; err: -if (dpu_kms->has_opp_table) -dev_pm_opp_of_remove_table (dev); +dev_pm_opp_of_remove_table (dev); +put_clkname:dev_pm_opp_put_clkname (dpu_kms->opp_table);return ret; }
@@ -1056,8 +1053,7 @@ static void dpu_unbind(struct device *dev, struct device *master, void *data)if (dpu_kms->rpm_enabled)pm_runtime_disable (&pdev->dev); -if (dpu_kms->has_opp_table) -dev_pm_opp_of_remove_table (dev); +dev_pm_opp_of_remove_table (dev);dev_pm_opp_put_clkname (dpu_kms->opp_table); }
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h +0 -1
@@ -129,7 +129,6 @@ struct dpu_kms {bool rpm_enabled;struct opp_table *opp_table; -bool has_opp_table;struct dss_module_power mp;
drivers/gpu/drm/msm/dsi/dsi_host.c +2 -6
@@ -113,7 +113,6 @@ struct msm_dsi_host {struct clk *byte_intf_clk;struct opp_table *opp_table; -bool has_opp_table;u32 byte_clk_rate;u32 pixel_clk_rate;
@@ -1891,9 +1890,7 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi)return PTR_ERR (msm_host->opp_table);/* OPP table is optional */ ret =dev_pm_opp_of_add_table (&pdev->dev); -if (!ret) { - msm_host->has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (&pdev->dev,"invalid OPP table in device tree\n" );dev_pm_opp_put_clkname (msm_host->opp_table);return ret;
@@ -1934,8 +1931,7 @@ void msm_dsi_host_destroy(struct mipi_dsi_host *host)mutex_destroy (&msm_host->cmd_mutex);mutex_destroy (&msm_host->dev_mutex); -if (msm_host->has_opp_table) -dev_pm_opp_of_remove_table (&msm_host->pdev->dev); +dev_pm_opp_of_remove_table (&msm_host->pdev->dev);dev_pm_opp_put_clkname (msm_host->opp_table);pm_runtime_disable (&msm_host->pdev->dev); }
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 4 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.
Its a little tricky to call things unconditionally for this driver, more below.
Quoted 21 lines
While at it, also create a label to put clkname.
Signed-off-by Viresh Kumar <[email protected]>---
V2:
- Compare with-ENODEVonly for failures.
- Create new label to put clkname.--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 14 +++++--------- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 - drivers/gpu/drm/msm/dsi/dsi_host.c | 8 ++------ 3 files changed, 7 insertions(+), 16 deletions(-)drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +0
-0@@ -1010,12 +1010,9 @@ static int dpu_bind(struct device *dev, struct device *master, void *data)return PTR_ERR (dpu_kms->opp_table);
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c static int dpu_bind(struct device *dev, struct device *master, void *data) · line 1015
Quoted 10 lines
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +2
-5/* OPP table is optional */ ret =dev_pm_opp_of_add_table (dev); -if (!ret) { - dpu_kms->has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (dev,"invalid OPP table in device tree\n" ); -dev_pm_opp_put_clkname (dpu_kms->opp_table); -return ret; + goto put_clkname;
So FWIU, dpu_unbind() gets called even when dpu_bind() fails for some reason. I tried to address that earlier [1] which I realized did not land. But with these changes it will be even more broken unless we identify if we failed dpu_bind() before adding the OPP table, while adding it, or all went well with opps and handle things accordingly in dpu_unbind.
Quoted 70 lines
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +3
-4} mp = &dpu_kms->mp;@@ -1037,8 +1034,8 @@ static int dpu_bind(struct device *dev, struct device *master, void *data) priv->kms = &dpu_kms->base;return ret; err: -if (dpu_kms->has_opp_table) -dev_pm_opp_of_remove_table (dev); +dev_pm_opp_of_remove_table (dev); +put_clkname:dev_pm_opp_put_clkname (dpu_kms->opp_table);return ret; }@@ -1056,8 +1053,7 @@ static void dpu_unbind(struct device *dev, struct device *master, void *data)if (dpu_kms->rpm_enabled)pm_runtime_disable (&pdev->dev); -if (dpu_kms->has_opp_table) -dev_pm_opp_of_remove_table (dev); +dev_pm_opp_of_remove_table (dev);dev_pm_opp_put_clkname (dpu_kms->opp_table); }drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h +0
-1@@ -129,7 +129,6 @@ struct dpu_kms {bool rpm_enabled;struct opp_table *opp_table; -bool has_opp_table;struct dss_module_power mp;drivers/gpu/drm/msm/dsi/dsi_host.c +2
-6@@ -113,7 +113,6 @@ struct msm_dsi_host {struct clk *byte_intf_clk;struct opp_table *opp_table; -bool has_opp_table;u32 byte_clk_rate;u32 pixel_clk_rate;@@ -1891,9 +1890,7 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi)return PTR_ERR (msm_host->opp_table);/* OPP table is optional */ ret =dev_pm_opp_of_add_table (&pdev->dev); -if (!ret) { - msm_host->has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (&pdev->dev,"invalid OPP table in device tree\n" );dev_pm_opp_put_clkname (msm_host->opp_table);return ret;@@ -1934,8 +1931,7 @@ void msm_dsi_host_destroy(struct mipi_dsi_host *host)mutex_destroy (&msm_host->cmd_mutex);mutex_destroy (&msm_host->dev_mutex); -if (msm_host->has_opp_table) -dev_pm_opp_of_remove_table (&msm_host->pdev->dev); +dev_pm_opp_of_remove_table (&msm_host->pdev->dev);dev_pm_opp_put_clkname (msm_host->opp_table);pm_runtime_disable (&msm_host->pdev->dev); }
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Viresh Kumar
maintainerRe: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 1 line · Rajendra Nayak
So FWIU,
dpu_unbind()gets called even whendpu_bind()fails for some reason.
Ahh, I see.
Quoted 1 line
I tried to address that earlier [1] which I realized did not land.
I don't think that patch was required, as you can call dev_pm_opp_put_clkname() multiple times and it will return without any errors/crash.
Quoted 4 lines
But with these changes
it will be even more broken unless we identify if we faileddpu_bind()before adding the OPP table, while adding it, or all went well with opps and handle things accordingly indpu_unbind.
Maybe not as dev_pm_opp_of_remove_table() can be called multiple times as well without any errors or crash.
Quoted 1 line
Signature · 1 line
viresh
Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 10 lines · Viresh Kumar
Quoted 1 line · Rajendra Nayak
So FWIU,
dpu_unbind()gets called even whendpu_bind()fails for some reason.Ahh, I see.
Quoted 1 line
I tried to address that earlier [1] which I realized did not land.
I don't think that patch was required, as you can call
dev_pm_opp_put_clkname()multiple times and it will return without any errors/crash.
We did see a crash (Sai had reported it), perhaps with dsi [1] and not this driver. But it was the same scenario that was possible here as well, which is dev_pm_opp_put_clkname() getting called without dev_pm_opp_set_clkname() being done. I think we ended up passing a NULL as opp_table in that case and the function tries de-referencing it.
Quoted 8 lines
Quoted 5 lines
But with these changes
it will be even more broken unless we identify if we faileddpu_bind()before adding the OPP table, while adding it, or all went well with opps and handle things accordingly indpu_unbind.Maybe not as
dev_pm_opp_of_remove_table()can be called multiple times as well without any errors or crash.
Can it be called without the driver ever doing a dev_pm_opp_of_add_table()?
[1] https://lore.kernel.org/patchwork/patch/1275628/
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Viresh Kumar
maintainerRe: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 13 lines · Rajendra Nayak
Quoted 10 lines · Viresh Kumar
Quoted 1 line · Rajendra Nayak
So FWIU,
dpu_unbind()gets called even whendpu_bind()fails for some reason.Ahh, I see.
Quoted 1 line
I tried to address that earlier [1] which I realized did not land.
I don't think that patch was required, as you can call
dev_pm_opp_put_clkname()multiple times and it will return without any errors/crash.
Quoted 5 lines
We did see a crash (Sai had reported it), perhaps with dsi [1] and not this driver. But it was the same scenario that was possible here as well, which is
dev_pm_opp_put_clkname()getting called withoutdev_pm_opp_set_clkname()being done. I think we ended up passing a NULL asopp_tablein that case and the function tries de-referencing it.
Heh, yeah I did miss that stupid thing :(
Quoted 10 lines
Quoted 8 lines
Quoted 5 lines
But with these changes
it will be even more broken unless we identify if we faileddpu_bind()before adding the OPP table, while adding it, or all went well with opps and handle things accordingly indpu_unbind.Maybe not as
dev_pm_opp_of_remove_table()can be called multiple times as well without any errors or crash.Can it be called without the driver ever doing a
dev_pm_opp_of_add_table()?
Yes, as we will fail to find the OPP device in that case with -ENODEV and so won't even print a warning.
Also if the OPP table was previously added as a response to dev_pm_opp_set_clkname(), then we won't free it as well. So yes, it should work just fine.
Signature · 1 line
viresh
Viresh Kumar
maintainerRe: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Viresh KumarQuoted 8 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.While at it, also create a label to put clkname.
Signed-off-by Viresh Kumar <[email protected]>
Can someone please apply this and the other drm patch (2/8) ?
Signature · 1 line
viresh
Viresh Kumar
maintainerRe: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 11 lines · Viresh Kumar
Quoted 8 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.While at it, also create a label to put clkname.
Signed-off-by Viresh Kumar <[email protected]>Can someone please apply this and the other drm patch (2/8) ?
Rob/Rajendra, can someone please have a look at these patches ?
Signature · 1 line
viresh
Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 8 lines · Viresh Kumar
Quoted 6 lines · Viresh Kumar
Quoted 5 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
While at it, also create a label to put clkname.
Signed-off-by Viresh Kumar <[email protected]>Can someone please apply this and the other drm patch (2/8) ?
Rob/Rajendra, can someone please have a look at these patches ?
Oh, sorry I missed that, could someone re-send it and CC [email protected] so it shows up in patchworks.. that is more reliable counting on me to not overlook something in my mail
BR,
-R
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Viresh Kumar
maintainerRe: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 13 lines · Rob Clark
Quoted 12 lines · Viresh Kumar
Quoted 10 lines · Viresh Kumar
Quoted 8 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.While at it, also create a label to put clkname.
Signed-off-by Viresh Kumar <[email protected]>
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Can someone please apply this and the other drm patch (2/8) ?
Rob/Rajendra, can someone please have a look at these patches ?
Oh, sorry I missed that, could someone re-send it and CC [email protected] so it shows up in patchworks.. that is more reliable counting on me to not overlook something in my mail
I have just bounced it back to you and freedreno was already cc'd, though I have bounced it there again.
Signature · 1 line
viresh
Viresh Kumar
maintainerPATCH v2 4/8 mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Viresh Kumardev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here.
---
V2:
- Compare with -ENODEV only for failures.
- Create new label to put clkname.
--- drivers/mmc/host/sdhci-msm.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)
drivers/mmc/host/sdhci-msm.c +5 -9
@@ -263,7 +263,6 @@ struct sdhci_msm_host {unsigned long clk_rate;struct mmc_host *mmc;struct opp_table *opp_table; -bool has_opp_table;bool use_14lpp_dll_reset;bool tuning_done;bool calibration_done;
@@ -2285,11 +2284,9 @@ static int sdhci_msm_probe(struct platform_device *pdev)/* OPP table is optional */ ret =dev_pm_opp_of_add_table (&pdev->dev); -if (!ret) { - msm_host->has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (&pdev->dev,"Invalid OPP table in Device tree\n" ); - goto opp_cleanup; + goto opp_put_clkname; }/* Vote for maximum clock rate for maximum performance */
@@ -2453,8 +2450,8 @@ static int sdhci_msm_probe(struct platform_device *pdev)clk_bulk_disable_unprepare (ARRAY_SIZE (msm_host->bulk_clks), msm_host->bulk_clks); opp_cleanup: -if (msm_host->has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev); +opp_put_clkname:dev_pm_opp_put_clkname (msm_host->opp_table); bus_clk_disable:if (!IS_ERR (msm_host->bus_clk))
@@ -2474,8 +2471,7 @@ static int sdhci_msm_remove(struct platform_device *pdev)sdhci_remove_host (host, dead); -if (msm_host->has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev);dev_pm_opp_put_clkname (msm_host->opp_table);pm_runtime_get_sync (&pdev->dev);pm_runtime_disable (&pdev->dev);
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Re: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 7 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.Signed-off-by Viresh Kumar <[email protected]>
Replaced v1 with v2 on my next branch, thanks!
Just to be sure, this patch doesn't depend on any changes for the opp core that are queued for v5.10?
Kind regards
Uffe
Quoted 59 lines
---
V2:
- Compare with-ENODEVonly for failures.
- Create new label to put clkname.--- drivers/mmc/host/sdhci-msm.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)drivers/mmc/host/sdhci-msm.c +5
-10@@ -263,7 +263,6 @@ struct sdhci_msm_host {unsigned long clk_rate;struct mmc_host *mmc;struct opp_table *opp_table; -bool has_opp_table;bool use_14lpp_dll_reset;bool tuning_done;bool calibration_done;@@ -2285,11 +2284,9 @@ static int sdhci_msm_probe(struct platform_device *pdev)/* OPP table is optional */ ret =dev_pm_opp_of_add_table (&pdev->dev); -if (!ret) { - msm_host->has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (&pdev->dev,"Invalid OPP table in Device tree\n" ); - goto opp_cleanup; + goto opp_put_clkname; }/* Vote for maximum clock rate for maximum performance */ @@ -2453,8 +2450,8 @@ static int sdhci_msm_probe(struct platform_device *pdev)clk_bulk_disable_unprepare (ARRAY_SIZE (msm_host->bulk_clks), msm_host->bulk_clks); opp_cleanup: -if (msm_host->has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev); +opp_put_clkname:dev_pm_opp_put_clkname (msm_host->opp_table); bus_clk_disable:if (!IS_ERR (msm_host->bus_clk))@@ -2474,8 +2471,7 @@ static int sdhci_msm_remove(struct platform_device *pdev)sdhci_remove_host (host, dead); -if (msm_host->has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev);dev_pm_opp_put_clkname (msm_host->opp_table);pm_runtime_get_sync (&pdev->dev);pm_runtime_disable (&pdev->dev); --2.25.0.rc1.19.g042ed3e048af
Re: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
Hi,
Quoted 11 lines · Ulf Hansson
Quoted 7 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.Signed-off-by Viresh Kumar <[email protected]>Replaced v1 with v2 on my next branch, thanks!
Actually, I don't see it on there yet, but at least the old broken v1 isn't there anymore. ;-)
I picked v2 and tried it on my sc7180-based device (which does have OPP tables). It worked fine. Thus:
I looked at the code and it looks right to me. Thus:
Quoted 2 lines
Just to be sure, this patch doesn't depend on any changes for the opp core that are queued for v5.10?
Running atop mmc-next, I see the check for -ENODEV, so I'm gonna assume that the required change is there.
$ git grep -A10 'void _dev_pm_opp_find_and_remove_table' -- drivers/opp/core.c
drivers/opp/core.c:void _dev_pm_opp_find_and_remove_table(struct device *dev)
drivers/opp/core.c-{
drivers/opp/core.c- struct opp_table *opp_table;
drivers/opp/core.c-
drivers/opp/core.c- /* Check for existing table for 'dev' */
drivers/opp/core.c- opp_table = _find_opp_table(dev);
drivers/opp/core.c- if (IS_ERR(opp_table)) {
drivers/opp/core.c- int error = PTR_ERR(opp_table);
drivers/opp/core.c-
drivers/opp/core.c- if (error != -ENODEV)
drivers/opp/core.c- WARN(1, "%s: opp_table: %d\n",Viresh Kumar
maintainerRe: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Ulf HanssonQuoted 7 lines · Ulf Hansson
Quoted 6 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.
Quoted 6 lines
Quoted 1 line
Signed-off-by Viresh Kumar <[email protected]>Replaced v1 with v2 on my next branch, thanks!
Just to be sure, this patch doesn't depend on any changes for the opp core that are queued for v5.10?
No it doesn't.
Signature · 1 line
viresh
Viresh Kumar
maintainerRe: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Ulf HanssonQuoted 7 lines · Ulf Hansson
Quoted 6 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.
Quoted 6 lines
Quoted 1 line
Signed-off-by Viresh Kumar <[email protected]>Replaced v1 with v2 on my next branch, thanks!
Just to be sure, this patch doesn't depend on any changes for the opp core that are queued for v5.10?
The recent crashes reported by Anders and Naresh were related to a OPP core bug, for which I have just sent the fix here:
This is already tested by Naresh now and finally everything works as expected.
I am going to get this fix merged in 5.9-rc4, but we do have a dependency now with that fix.
What's the best way to handle this stuff now ? The easiest IMO would be for me to send these patches through the OPP tree, otherwise people need to carry this and the OPP fix (for which I can provide the branch/tag).
Signature · 1 line
viresh
Re: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 24 lines · Viresh Kumar
Quoted 7 lines · Ulf Hansson
Quoted 6 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.Quoted 6 lines
Quoted 1 line
Signed-off-by Viresh Kumar <[email protected]>Replaced v1 with v2 on my next branch, thanks!
Just to be sure, this patch doesn't depend on any changes for the opp core that are queued for v5.10?
The recent crashes reported by Anders and Naresh were related to a OPP core bug, for which I have just sent the fix here:
This is already tested by Naresh now and finally everything works as expected.
Quoted 7 lines
I am going to get this fix merged in 5.9-rc4, but we do have a dependency now with that fix.
What's the best way to handle this stuff now ? The easiest IMO would be for me to send these patches through the OPP tree, otherwise people need to carry this and the OPP fix (for which I can provide the branch/tag).
No need for a tag/branch to be shared. Instead I am simply going to defer to pick up any related changes for mmc, until I can rebase my tree on an rc[n] that contains your fix.
When that is possible, please re-post the mmc patches.
Kind regards
Uffe
Viresh Kumar
maintainerRe: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 33 lines · Ulf Hansson
Quoted 24 lines · Viresh Kumar
Quoted 7 lines · Ulf Hansson
Quoted 6 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.Quoted 6 lines
Quoted 1 line
Signed-off-by Viresh Kumar <[email protected]>Replaced v1 with v2 on my next branch, thanks!
Just to be sure, this patch doesn't depend on any changes for the opp core that are queued for v5.10?
The recent crashes reported by Anders and Naresh were related to a OPP core bug, for which I have just sent the fix here:
This is already tested by Naresh now and finally everything works as expected.
Quoted 7 lines
I am going to get this fix merged in 5.9-rc4, but we do have a dependency now with that fix.
What's the best way to handle this stuff now ? The easiest IMO would be for me to send these patches through the OPP tree, otherwise people need to carry this and the OPP fix (for which I can provide the branch/tag).
Quoted 5 lines
No need for a tag/branch to be shared. Instead I am simply going to defer to pick up any related changes for mmc, until I can rebase my tree on an rc[n] that contains your fix.
When that is possible, please re-post the mmc patches.
The dependency patch got merged in 5.9-rc4. Do you still want me to resend this patch or you can apply it directly from here ?
Signature · 1 line
viresh
Re: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table()
Quoted 35 lines · Viresh Kumar
Quoted 33 lines · Ulf Hansson
Quoted 31 lines · Viresh Kumar
Quoted 7 lines · Ulf Hansson
Quoted 6 lines · Viresh Kumar
dev_pm_opp_of_remove_table()doesn't report any errors when it fails to find the OPP table with error-ENODEV(i.e. OPP table not present for the device). And we can calldev_pm_opp_of_remove_table()unconditionally here.Quoted 6 lines
Quoted 1 line
Signed-off-by Viresh Kumar <[email protected]>Replaced v1 with v2 on my next branch, thanks!
Just to be sure, this patch doesn't depend on any changes for the opp core that are queued for v5.10?
The recent crashes reported by Anders and Naresh were related to a OPP core bug, for which I have just sent the fix here:
This is already tested by Naresh now and finally everything works as expected.
I am going to get this fix merged in 5.9-rc4, but we do have a dependency now with that fix.
What's the best way to handle this stuff now ? The easiest IMO would be for me to send these patches through the OPP tree, otherwise people need to carry this and the OPP fix (for which I can provide the branch/tag).
Quoted 8 lines
Quoted 5 lines
No need for a tag/branch to be shared. Instead I am simply going to defer to pick up any related changes for mmc, until I can rebase my tree on an rc[n] that contains your fix.
When that is possible, please re-post the mmc patches.
The dependency patch got merged in 5.9-rc4. Do you still want me to resend this patch or you can apply it directly from here ?
Please re-submit, then I will pick it from the patchtracker.
Kind regards
Uffe
Viresh Kumar
maintainerPATCH v2 5/8 spi: spi-geni-qcom: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Viresh Kumardev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here.
While at it, create a new label and put clkname on errors.
---
V2:
- Compare with -ENODEV only for failures.
- Create new label to put clkname.
--- drivers/spi/spi-geni-qcom.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
drivers/spi/spi-geni-qcom.c +5 -8
@@ -613,11 +613,9 @@ static int spi_geni_probe(struct platform_device *pdev)return PTR_ERR (mas->se.opp_table);/* OPP table is optional */ ret =dev_pm_opp_of_add_table (&pdev->dev); -if (!ret) { - mas->se.has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (&pdev->dev,"invalid OPP table in device tree\n" ); -return ret; + goto put_clkname; } spi->bus_num =-1 ;
@@ -669,8 +667,8 @@ static int spi_geni_probe(struct platform_device *pdev) spi_geni_probe_runtime_disable:pm_runtime_disable (dev);spi_master_put (spi); -if (mas->se.has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev); +put_clkname:dev_pm_opp_put_clkname (mas->se.opp_table);return ret; }
@@ -685,8 +683,7 @@ static int spi_geni_remove(struct platform_device *pdev)free_irq (mas->irq, spi);pm_runtime_disable (&pdev->dev); -if (mas->se.has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev);dev_pm_opp_put_clkname (mas->se.opp_table);return 0 ; }
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Viresh Kumar
maintainerPATCH v2 6/8 spi: spi-qcom-qspi: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Viresh Kumardev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here.
While at it, create a new label and put clkname on errors.
---
V2:
- Compare with -ENODEV only for failures.
- Create new label to put clkname.
--- drivers/spi/spi-qcom-qspi.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)
drivers/spi/spi-qcom-qspi.c +6 -9
@@ -143,7 +143,6 @@ struct qcom_qspi {struct qspi_xfer xfer;struct icc_path *icc_path_cpu_to_qspi;struct opp_table *opp_table; -bool has_opp_table;unsigned long last_speed;/* Lock to protect data accessed by IRQs */ spinlock_t lock;
@@ -546,11 +545,9 @@ static int qcom_qspi_probe(struct platform_device *pdev) }/* OPP table is optional */ ret =dev_pm_opp_of_add_table (&pdev->dev); -if (!ret) { - ctrl->has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (&pdev->dev,"invalid OPP table in device tree\n" ); - goto exit_probe_master_put; + goto exit_probe_put_clkname; }pm_runtime_use_autosuspend (dev);
@@ -562,8 +559,9 @@ static int qcom_qspi_probe(struct platform_device *pdev)return 0 ;pm_runtime_disable (dev); -if (ctrl->has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev); + +exit_probe_put_clkname:dev_pm_opp_put_clkname (ctrl->opp_table); exit_probe_master_put:
@@ -581,8 +579,7 @@ static int qcom_qspi_remove(struct platform_device *pdev)spi_unregister_master (master);pm_runtime_disable (&pdev->dev); -if (ctrl->has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev);dev_pm_opp_put_clkname (ctrl->opp_table);return 0 ;
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Viresh Kumar
maintainerPATCH v2 7/8 tty: serial: qcom_geni_serial: Unconditionally call dev_pm_opp_of_remove_table()
In reply to Viresh Kumardev_pm_opp_of_remove_table() doesn't report any errors when it fails to find the OPP table with error -ENODEV (i.e. OPP table not present for the device). And we can call dev_pm_opp_of_remove_table() unconditionally here.
While at it, create a new label to put clkname on errors.
---
V2:
- Compare with -ENODEV only for failures.
- Create new label to put clkname.
--- drivers/tty/serial/qcom_geni_serial.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
drivers/tty/serial/qcom_geni_serial.c +5 -8
@@ -1433,11 +1433,9 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)return PTR_ERR (port->se.opp_table);/* OPP table is optional */ ret =dev_pm_opp_of_add_table (&pdev->dev); -if (!ret) { - port->se.has_opp_table = true; - }else if (ret != -ENODEV ) { +if (ret && ret != -ENODEV ) {dev_err (&pdev->dev,"invalid OPP table in device tree\n" ); -return ret; + goto put_clkname; } port->private_data.drv = drv;
@@ -1478,8 +1476,8 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)return 0 ; err: -if (port->se.has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev); +put_clkname:dev_pm_opp_put_clkname (port->se.opp_table);return ret; }
@@ -1489,8 +1487,7 @@ static int qcom_geni_serial_remove(struct platform_device *pdev)struct qcom_geni_serial_port *port =platform_get_drvdata (pdev);struct uart_driver *drv = port->private_data.drv; -if (port->se.has_opp_table) -dev_pm_opp_of_remove_table (&pdev->dev); +dev_pm_opp_of_remove_table (&pdev->dev);dev_pm_opp_put_clkname (port->se.opp_table);dev_pm_clear_wake_irq (&pdev->dev);device_init_wakeup (&pdev->dev, false);
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Viresh Kumar
maintainerPATCH v2 8/8 qcom-geni-se: remove has_opp_table
In reply to Viresh Kumarhas_opp_table isn't used anymore, remove it.
---
V2: No changes.
--- include/linux/qcom-geni-se.h | 2 -- 1 file changed, 2 deletions(-)
include/linux/qcom-geni-se.h +0 -2
@@ -48,7 +48,6 @@ struct geni_icc_path {* @clk_perf_tbl: Table of clock frequency input to serial engine clock * @icc_paths: Array of ICC paths for SE * @opp_table: Pointer to the OPP table -* @has_opp_table: Specifies if the SE has an OPP table */ struct geni_se {void __iomem *base;
@@ -59,7 +58,6 @@ struct geni_se {unsigned long *clk_perf_tbl;struct geni_icc_path icc_paths[3 ];struct opp_table *opp_table; -bool has_opp_table; };/* Common SE registers */
Signature · 1 line
2.25.0.rc1.19.g042ed3e048af
Viresh Kumar
maintainerRe: [PATCH V2 8/8] qcom-geni-se: remove has_opp_table
Quoted 23 lines · Viresh Kumar
has_opp_tableisn't used anymore, remove it.Signed-off-by Viresh Kumar <[email protected]>---
V2: No changes.--- include/linux/qcom-geni-se.h | 2 -- 1 file changed, 2 deletions(-)include/linux/qcom-geni-se.h +0
-1@@ -48,7 +48,6 @@ struct geni_icc_path {* @clk_perf_tbl: Table of clock frequency input to serial engine clock * @icc_paths: Array of ICC paths for SE * @opp_table: Pointer to the OPP table -* @has_opp_table: Specifies if the SE has an OPP table */ struct geni_se {void __iomem *base;
include/linux/qcom-geni-se.h struct geni_se { · line 63
Quoted 7 lines
include/linux/qcom-geni-se.h +0
-1@@ -59,7 +58,6 @@ struct geni_se {unsigned long *clk_perf_tbl;struct geni_icc_path icc_paths[3 ];struct opp_table *opp_table; -bool has_opp_table; };/* Common SE registers */
Rajendra,
This patch depended on following patches which are part of Linus's master now:
7d568edff5cb spi: spi-geni-qcom: Unconditionally call dev_pm_opp_of_remove_table() c7ac46dac744 tty: serial: qcom_geni_serial: Unconditionally call dev_pm_opp_of_remove_table()
Who is going to merge this one ? Should I ask Greg or you can take it ?
Signature · 1 line
viresh
Re: [PATCH V2 8/8] qcom-geni-se: remove has_opp_table
Hi,
Quoted 35 lines · Viresh Kumar
Quoted 23 lines · Viresh Kumar
has_opp_tableisn't used anymore, remove it.Signed-off-by Viresh Kumar <[email protected]>---
V2: No changes.--- include/linux/qcom-geni-se.h | 2 -- 1 file changed, 2 deletions(-)include/linux/qcom-geni-se.h +0
-1@@ -48,7 +48,6 @@ struct geni_icc_path {* @clk_perf_tbl: Table of clock frequency input to serial engine clock * @icc_paths: Array of ICC paths for SE * @opp_table: Pointer to the OPP table -* @has_opp_table: Specifies if the SE has an OPP table */ struct geni_se {void __iomem *base;include/linux/qcom-geni-se.h struct geni_se { · line 63
Quoted 7 lines
include/linux/qcom-geni-se.h +0
-1@@ -59,7 +58,6 @@ struct geni_se {unsigned long *clk_perf_tbl;struct geni_icc_path icc_paths[3 ];struct opp_table *opp_table; -bool has_opp_table; };/* Common SE registers */ Rajendra,
Quoted 6 lines
This patch depended on following patches which are part of Linus's master now:
7d568edff5cbspi: spi-geni-qcom: Unconditionally calldev_pm_opp_of_remove_table()c7ac46dac744tty: serial:qcom_geni_serial: Unconditionally calldev_pm_opp_of_remove_table()Who is going to merge this one ? Should I ask Greg or you can take it ?
My guess would be that Bjorn would take it.
-Doug
Viresh Kumar
maintainerQuoted 10 lines · Viresh Kumar
Hello,
This cleans up some of the user code around calls to
dev_pm_opp_of_remove_table().All the patches can be picked by respective maintainers directly except for the last patch, which needs the previous two to get merged first.
These are based for 5.9-rc1.
Quoted 10 lines
Viresh Kumar (8):
cpufreq: imx6q: Unconditionally calldev_pm_opp_of_remove_table()drm/lima: Unconditionally calldev_pm_opp_of_remove_table()drm/msm: Unconditionally calldev_pm_opp_of_remove_table()
mmc: sdhci-msm: Unconditionally calldev_pm_opp_of_remove_table()
spi: spi-geni-qcom: Unconditionally calldev_pm_opp_of_remove_table()
spi: spi-qcom-qspi: Unconditionally calldev_pm_opp_of_remove_table()
tty: serial:qcom_geni_serial: Unconditionally call
dev_pm_opp_of_remove_table()
qcom-geni-se: removehas_opp_table
During testing by some of the Linaro folks on linux-next, we found out that there was a bug in the OPP core (which makes the kernel crash in some corner cases with these patches) for which I have sent a fix today which should be part of 5.9-rc4:
Please apply the patches over rc4 only once it comes out (I will confirm by that time once the patch gets merged). Else you guys can provide your Ack and I can take the patches through OPP tree.
Signature · 6 lines
viresh _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Viresh Kumar
maintainerQuoted 27 lines · Viresh Kumar
Quoted 10 lines · Viresh Kumar
Hello,
This cleans up some of the user code around calls to
dev_pm_opp_of_remove_table().All the patches can be picked by respective maintainers directly except for the last patch, which needs the previous two to get merged first.
These are based for 5.9-rc1.
Quoted 10 lines
Viresh Kumar (8):
cpufreq: imx6q: Unconditionally calldev_pm_opp_of_remove_table()drm/lima: Unconditionally calldev_pm_opp_of_remove_table()drm/msm: Unconditionally calldev_pm_opp_of_remove_table()
mmc: sdhci-msm: Unconditionally calldev_pm_opp_of_remove_table()
spi: spi-geni-qcom: Unconditionally calldev_pm_opp_of_remove_table()
spi: spi-qcom-qspi: Unconditionally calldev_pm_opp_of_remove_table()
tty: serial:qcom_geni_serial: Unconditionally call
dev_pm_opp_of_remove_table()
qcom-geni-se: removehas_opp_tableDuring testing by some of the Linaro folks on linux-next, we found out that there was a bug in the OPP core (which makes the kernel crash in some corner cases with these patches) for which I have sent a fix today which should be part of 5.9-rc4:
Quoted 5 lines
Please apply the patches over rc4 only once it comes out (I will confirm by that time once the patch gets merged). Else you guys can provide your Ack and I can take the patches through OPP tree.
The fix got merged in 5.9-rc4, please apply the patches from this series in your trees and base them on rc4. Thanks.
Signature · 6 lines
viresh _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Mark Brown
maintainerQuoted 9 lines · Viresh Kumar
This cleans up some of the user code around calls to
dev_pm_opp_of_remove_table().All the patches can be picked by respective maintainers directly except for the last patch, which needs the previous two to get merged first.
These are based for 5.9-rc1.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/2] spi: spi-geni-qcom: Unconditionally call dev_pm_opp_of_remove_table()
commit: 7d568edff5cb7968cc5f29e85da15f941b8070b8
[2/2] spi: spi-qcom-qspi: Unconditionally call dev_pm_opp_of_remove_table()
commit: 062cf7fc927d2546b58ed128383e5c52f26a00a5All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel