Skip to contentSkip to conversation

gstreamer1.0-plugins-bad: Add support for mpegtsmux

PATCH In review Joakim Roubert 2 participants 3 messages Jan 3, 2022 – Jan 10, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 gstreamer1.0-plugins-bad: Add support for mpegtsmux

From: Joakim Roubert <[email protected]>

When enabling srt one most likely also wants to use mpegtsmux.

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb                 | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb +1 -0
index f90dff693d..9233c3bec1 100644
@@ -65,6 +65,7 @@ PACKAGECONFIG[libmms]          = "-Dlibmms=enabled,-Dlibmms=disabled,libmms"
 PACKAGECONFIG[libssh2]         = "-Dcurl-ssh2=enabled,-Dcurl-ssh2=disabled,libssh2"
 PACKAGECONFIG[lcms2]           = "-Dcolormanagement=enabled,-Dcolormanagement=disabled,lcms"
 PACKAGECONFIG[modplug]         = "-Dmodplug=enabled,-Dmodplug=disabled,libmodplug"
+PACKAGECONFIG[mpegtsmux]       = "-Dmpegtsmux=enabled,-Dmpegtsmux=disabled""
 PACKAGECONFIG[msdk]            = "-Dmsdk=enabled,-Dmsdk=disabled,intel-mediasdk"
 PACKAGECONFIG[neon]            = "-Dneon=enabled,-Dneon=disabled,neon"
 PACKAGECONFIG[openal]          = "-Dopenal=enabled,-Dopenal=disabled,openal-soft"
Signature · 1 line
2.30.2
#1 lore raw

Joakim Roubert <[email protected]> escreveu no dia segunda, 3/01/2022 à(s) 08:39:

Quoted 17 lines

From: Joakim Roubert <[email protected]>

When enabling srt one most likely also wants to use mpegtsmux.

---
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb                 | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

gstreamer1.0-plugins-bad_1.18.5.bb b/meta/recipes-multimedia/gstreamer/ gstreamer1.0-plugins-bad_1.18.5.bb
index f90dff693d..9233c3bec1 100644

meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.5.bb +0 -0
@@ -65,6 +65,7 @@ PACKAGECONFIG[libmms]          =

"-Dlibmms=enabled,-Dlibmms=disabled,libmms"

Quoted 9 lines

PACKAGECONFIG[libssh2] =
"-Dcurl-ssh2=enabled,-Dcurl-ssh2=disabled,libssh2"
PACKAGECONFIG[lcms2] =
"-Dcolormanagement=enabled,-Dcolormanagement=disabled,lcms"
PACKAGECONFIG[modplug] =
"-Dmodplug=enabled,-Dmodplug=disabled,libmodplug"
+PACKAGECONFIG[mpegtsmux] =
"-Dmpegtsmux=enabled,-Dmpegtsmux=disabled""

this patch is not backward compatible as it will disable the mpegtsmux plugin because PACKAGECONFIG don't have mpegtsmux

mpegtsmux doesn't have any external dependencies and is not present in EXTRA_OEMESON so it is always enabled.
with this patch the default config will build it with -Dmpegtsmux=disabled

Jose

Quoted 20 lines

PACKAGECONFIG[msdk] =
"-Dmsdk=enabled,-Dmsdk=disabled,intel-mediasdk"
PACKAGECONFIG[neon] = "-Dneon=enabled,-Dneon=disabled,neon"
PACKAGECONFIG[openal] =
"-Dopenal=enabled,-Dopenal=disabled,openal-soft"
--
2.30.2

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#160115):
https://lists.openembedded.org/g/openembedded-core/message/160115
Mute This Topic: https://lists.openembedded.org/mt/88108871/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Best regards,

José Quaresma
#2 lore raw
Quoted 2 lines · Jose Quaresma

mpegtsmux doesn't have any external dependencies and is not present in EXTRA_OEMESON so it is always enabled. with this patch the default config will build it with -Dmpegtsmux=disabled

I can see that now, having had it explained to me. Thank you, then my submission should of course be void and ignored.

BR,

/Joakim