hw/vfio: Drop superfluous inclusion of hw-error.h
PATCH 1/1 hw/vfio: Drop superfluous inclusion of hw-error.h
From: Thomas Huth <[email protected]>
None of these files use the hw_error() function, so there is no need to include hw-error.h here.
--- hw/vfio/device.c | 1 - hw/vfio/helpers.c | 1 - hw/vfio/igd.c | 1 - hw/vfio/kvm-helpers.c | 1 - 4 files changed, 4 deletions(-)
hw/vfio/device.c +0 -1
@@ -24,7 +24,6 @@#include "hw/vfio/vfio-device.h" #include "hw/vfio/pci.h" #include "hw/core/iommu.h" -#include "hw/core/hw-error.h" #include "trace.h" #include "qapi/error.h" #include "qemu/error-report.h"
hw/vfio/helpers.c +0 -1
@@ -24,7 +24,6 @@#include "exec/cpu-common.h" #include "hw/vfio/vfio-device.h" -#include "hw/core/hw-error.h" #include "qapi/error.h" #include "vfio-helpers.h"
hw/vfio/igd.c +0 -1
@@ -16,7 +16,6 @@#include "qapi/error.h" #include "qapi/qmp/qerror.h" #include "hw/core/boards.h" -#include "hw/core/hw-error.h" #include "hw/nvram/fw_cfg.h" #include "pci.h" #include "pci-quirks.h"
hw/vfio/kvm-helpers.c +0 -1
@@ -25,7 +25,6 @@#include "system/kvm.h" #include "exec/cpu-common.h" #include "hw/vfio/vfio-device.h" -#include "hw/core/hw-error.h" #include "qapi/error.h" #include "vfio-helpers.h"
Signature · 1 line
2.53.0
Quoted 5 lines · Thomas Huth
From: Thomas Huth <[email protected]>
None of these files use the
hw_error()function, so there is no need to includehw-error.hhere.
Quoted 8 lines
Signed-off-by Thomas Huth <[email protected]>--- hw/vfio/device.c | 1 - hw/vfio/helpers.c | 1 - hw/vfio/igd.c | 1 - hw/vfio/kvm-helpers.c | 1 - 4 files changed, 4 deletions(-)
Quoted 5 lines · Thomas Huth
From: Thomas Huth <[email protected]>
None of these files use the
hw_error()function, so there is no need to includehw-error.hhere.
Quoted 7 lines
Signed-off-by Thomas Huth <[email protected]>--- hw/vfio/device.c | 1 - hw/vfio/helpers.c | 1 - hw/vfio/igd.c | 1 - hw/vfio/kvm-helpers.c | 1 - 4 files changed, 4 deletions(-)
Quoted 54 lines · Thomas Huth
From: Thomas Huth <[email protected]>
None of these files use the
hw_error()function, so there is no need to includehw-error.hhere.Signed-off-by Thomas Huth <[email protected]>--- hw/vfio/device.c | 1 - hw/vfio/helpers.c | 1 - hw/vfio/igd.c | 1 - hw/vfio/kvm-helpers.c | 1 - 4 files changed, 4 deletions(-)hw/vfio/device.c +0
-1@@ -24,7 +24,6 @@#include "hw/vfio/vfio-device.h" #include "hw/vfio/pci.h" #include "hw/core/iommu.h" -#include "hw/core/hw-error.h" #include "trace.h" #include "qapi/error.h" #include "qemu/error-report.h" hw/vfio/helpers.c +0
-1@@ -24,7 +24,6 @@#include "exec/cpu-common.h" #include "hw/vfio/vfio-device.h" -#include "hw/core/hw-error.h" #include "qapi/error.h" #include "vfio-helpers.h" hw/vfio/igd.c +0
-1@@ -16,7 +16,6 @@#include "qapi/error.h" #include "qapi/qmp/qerror.h" #include "hw/core/boards.h" -#include "hw/core/hw-error.h" #include "hw/nvram/fw_cfg.h" #include "pci.h" #include "pci-quirks.h" hw/vfio/kvm-helpers.c +0
-0
hw/vfio/kvm-helpers.c line 30
Quoted 7 lines
hw/vfio/kvm-helpers.c +0
-1@@ -25,7 +25,6 @@#include "system/kvm.h" #include "exec/cpu-common.h" #include "hw/vfio/vfio-device.h" -#include "hw/core/hw-error.h" #include "qapi/error.h" #include "vfio-helpers.h"
Applied to
https://github.com/legoater/qemu vfio-next
Please base future contributions on this branch.
Thanks,
C.
Quoted 6 lines · Cédric Le Goater
On 4/28/26 18:37, Thomas Huth wrote:
Applied tohttps://github.com/legoater/qemu vfio-next
Please base future contributions on this branch.
In general I think it's better if we don't have odd subsystem specific requirements like this. The general assumption for QEMU patches should be that they are based on the current head-of-git. I don't want to have to remember that vfio is weird if I'm doing a patch that touches more than one part of the codebase. If you're accumulating so much stuff in vfio-next that it's problematic to have new patches based on head-of-git, then my feeling is that you're not sending pullreqs regularly enough.
thanks
-- PMM
Quoted 4 lines · Peter Maydell
Quoted 3 lines · Cédric Le Goater
On 4/28/26 18:37, Thomas Huth wrote:
Applied to
Quoted 8 lines
Quoted 3 lines
https://github.com/legoater/qemu vfio-next
Please base future contributions on this branch.
In general I think it's better if we don't have odd subsystem specific requirements like this. The general assumption for QEMU patches should be that they are based on the current head-of-git.
ok
Quoted 6 lines
I don't want to have to remember that vfio
is weird if I'm doing a patch that touches more than one part of the codebase. If you're accumulating so much stuff in vfio-next that it's problematic to have new patches based on head-of-git, then my feeling is that you're not sending pullreqs regularly enough.
Fair enough.
I have had to deal with cases in the past where there were ordering headaches. I agree we should promote using the HEAD always.
I will remove that last sentence from my "applied" script.
Thanks,
C.