hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf
PATCH 1/1 hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf
Avoid to clutter stdout until explicitly requested (with -d unimp):
$ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin dma: command df not supported dma: command df not supported dma: command df not supported dma: command df not supported
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
--- hw/dma/i8257.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
hw/dma/i8257.c +3 -1
@@ -26,6 +26,7 @@#include "hw/isa/isa.h" #include "hw/dma/i8257.h" #include "qemu/main-loop.h" +#include "qemu/log.h" #include "trace.h" #define I8257 (obj) \
@@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data,switch (iport) {case 0x00 :/* command */ if ((data !=0 ) && (data &CMD_NOT_SUPPORTED )) { -dolog ("command %" PRIx64" not supported\n" , data); +qemu_log_mask (LOG_UNIMP ,"%s: cmd 0x%02" PRIx64" not supported\n" , + __func__, data);return ; } d->command = data;
Signature · 1 line
2.20.1
Quoted 27 lines · Philippe Mathieu-Daudé
Avoid to clutter stdout until explicitly requested (with -d unimp):
$ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin dma: command df not supported dma: command df not supported dma: command df not supported dma: command df not supportedSigned-off-by Philippe Mathieu-Daudé <[email protected]>--- hw/dma/i8257.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)hw/dma/i8257.c +1
-0@@ -26,6 +26,7 @@#include "hw/isa/isa.h" #include "hw/dma/i8257.h" #include "qemu/main-loop.h" +#include "qemu/log.h" #include "trace.h" #define I8257 (obj) \
hw/dma/i8257.c static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data, · line 193
Quoted 9 lines
hw/dma/i8257.c +2
-1@@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data,switch (iport) {case 0x00 :/* command */ if ((data !=0 ) && (data &CMD_NOT_SUPPORTED )) { -dolog ("command %" PRIx64" not supported\n" , data); +qemu_log_mask (LOG_UNIMP ,"%s: cmd 0x%02" PRIx64" not supported\n" , + __func__, data);return ; } d->command = data;
Reviewed-by Thomas Huth <[email protected]>
Quoted 8 lines · Philippe Mathieu-Daudé
Avoid to clutter stdout until explicitly requested (with -d unimp):
$ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin dma: command df not supported dma: command df not supported dma: command df not supported dma: command df not supported
Quoted 4 lines
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- hw/dma/i8257.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by Stefano Garzarella <[email protected]>
Thanks,
Stefano
Laurent Vivier
AppliedQuoted 27 lines · Philippe Mathieu-Daudé
Avoid to clutter stdout until explicitly requested (with -d unimp):
$ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin dma: command df not supported dma: command df not supported dma: command df not supported dma: command df not supportedSigned-off-by Philippe Mathieu-Daudé <[email protected]>--- hw/dma/i8257.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)hw/dma/i8257.c +1
-0@@ -26,6 +26,7 @@#include "hw/isa/isa.h" #include "hw/dma/i8257.h" #include "qemu/main-loop.h" +#include "qemu/log.h" #include "trace.h" #define I8257 (obj) \
hw/dma/i8257.c static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data, · line 193
Quoted 9 lines
hw/dma/i8257.c +2
-1@@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data,switch (iport) {case 0x00 :/* command */ if ((data !=0 ) && (data &CMD_NOT_SUPPORTED )) { -dolog ("command %" PRIx64" not supported\n" , data); +qemu_log_mask (LOG_UNIMP ,"%s: cmd 0x%02" PRIx64" not supported\n" , + __func__, data);return ; } d->command = data;
Applied to my trivial-patches branch.
Thanks,
Laurent