drivers/char/exynos-gpiomem.c:231 exynos_gpiomem_probe() error: we previously assumed 'inst' could be null (see line 156)
PATCH 21/204 drivers/char/exynos-gpiomem.c:231 exynos_gpiomem_probe() error: we previously assumed 'inst' could be null (see line 156)
tree: https://github.com/tobetter/linux odroid-5.15.y head: 28a16e1ab36472a36cac8b10003b29f322f458ff commit: 61f45d975621becb00c0aef303769f10428b9cd8 [21/204] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access config: i386-randconfig-141-20240416 (https://download.01.org/0day-ci/archive/20240416/[email protected]/config) compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:drivers/char/exynos-gpiomem.c:231 exynos_gpiomem_probe() error: we previously assumed 'inst' could be null (see line 156)
vim +/inst +231 drivers/char/exynos-gpiomem.c
61f45d975621be Brian Kim 2017-01-10 145 static int exynos_gpiomem_probe(struct platform_device *pdev)
61f45d975621be Brian Kim 2017-01-10 146 {
61f45d975621be Brian Kim 2017-01-10 147 int err = 0;
61f45d975621be Brian Kim 2017-01-10 148 struct device *dev = &pdev->dev;
61f45d975621be Brian Kim 2017-01-10 149 struct device_node *np = dev->of_node;
61f45d975621be Brian Kim 2017-01-10 150 struct resource *res = NULL;
61f45d975621be Brian Kim 2017-01-10 151 int i = 0;
61f45d975621be Brian Kim 2017-01-10 152
61f45d975621be Brian Kim 2017-01-10 153 /* Allocate buffers and instance data */
61f45d975621be Brian Kim 2017-01-10 154 inst = kzalloc(sizeof(struct exynos_gpiomem_instance), GFP_KERNEL);
61f45d975621be Brian Kim 2017-01-10 155
61f45d975621be Brian Kim 2017-01-10 @156 if (!inst) {
61f45d975621be Brian Kim 2017-01-10 157 err = -ENOMEM;
61f45d975621be Brian Kim 2017-01-10 158 goto failed_inst_alloc;
^^^^^^^^^^^^^^^^^^^^^^^This should just return. Printing an error for failed allocations is against kernel style.
61f45d975621be Brian Kim 2017-01-10 159 }
61f45d975621be Brian Kim 2017-01-10 160
61f45d975621be Brian Kim 2017-01-10 161 inst->dev = dev;
61f45d975621be Brian Kim 2017-01-10 162
61f45d975621be Brian Kim 2017-01-10 163 inst->gpio_area_count = of_property_count_elems_of_size(np, "reg",
61f45d975621be Brian Kim 2017-01-10 164 sizeof(u32)) / 2;
61f45d975621be Brian Kim 2017-01-10 165
61f45d975621be Brian Kim 2017-01-10 166 if (inst->gpio_area_count > 32 || inst->gpio_area_count <= 0) {
61f45d975621be Brian Kim 2017-01-10 167 dev_err(inst->dev, "failed to get gpio register area.");
61f45d975621be Brian Kim 2017-01-10 168 err = -EINVAL;
61f45d975621be Brian Kim 2017-01-10 169 goto failed_inst_alloc;
61f45d975621be Brian Kim 2017-01-10 170 }
61f45d975621be Brian Kim 2017-01-10 171
61f45d975621be Brian Kim 2017-01-10 172 dev_info(inst->dev, "Initialised: GPIO register area is %d",
61f45d975621be Brian Kim 2017-01-10 173 inst->gpio_area_count);
61f45d975621be Brian Kim 2017-01-10 174
61f45d975621be Brian Kim 2017-01-10 175 for (i = 0; i < inst->gpio_area_count; ++i) {
61f45d975621be Brian Kim 2017-01-10 176 res = platform_get_resource(pdev, IORESOURCE_MEM, i);
61f45d975621be Brian Kim 2017-01-10 177 if (res) {
61f45d975621be Brian Kim 2017-01-10 178 inst->gpio_regs_phys[i] = res->start;
61f45d975621be Brian Kim 2017-01-10 179 } else {
61f45d975621be Brian Kim 2017-01-10 180 dev_err(inst->dev, "failed to get IO resource");
61f45d975621be Brian Kim 2017-01-10 181 err = -ENOENT;
61f45d975621be Brian Kim 2017-01-10 182 goto failed_get_resource;
61f45d975621be Brian Kim 2017-01-10 183 }
61f45d975621be Brian Kim 2017-01-10 184 }
61f45d975621be Brian Kim 2017-01-10 185
61f45d975621be Brian Kim 2017-01-10 186 /* Create character device entries */
61f45d975621be Brian Kim 2017-01-10 187 err = alloc_chrdev_region(&exynos_gpiomem_devid,
61f45d975621be Brian Kim 2017-01-10 188 DEVICE_MINOR, 1, DEVICE_NAME);
61f45d975621be Brian Kim 2017-01-10 189 if (err != 0) {
61f45d975621be Brian Kim 2017-01-10 190 dev_err(inst->dev, "unable to allocate device number");
61f45d975621be Brian Kim 2017-01-10 191 goto failed_alloc_chrdev;
61f45d975621be Brian Kim 2017-01-10 192 }
61f45d975621be Brian Kim 2017-01-10 193 cdev_init(&exynos_gpiomem_cdev, &exynos_gpiomem_fops);
61f45d975621be Brian Kim 2017-01-10 194 exynos_gpiomem_cdev.owner = THIS_MODULE;
61f45d975621be Brian Kim 2017-01-10 195 err = cdev_add(&exynos_gpiomem_cdev, exynos_gpiomem_devid, 1);
61f45d975621be Brian Kim 2017-01-10 196 if (err != 0) {
61f45d975621be Brian Kim 2017-01-10 197 dev_err(inst->dev, "unable to register device");
61f45d975621be Brian Kim 2017-01-10 198 goto failed_cdev_add;
61f45d975621be Brian Kim 2017-01-10 199 }
61f45d975621be Brian Kim 2017-01-10 200
61f45d975621be Brian Kim 2017-01-10 201 /* Create sysfs entries */
61f45d975621be Brian Kim 2017-01-10 202 exynos_gpiomem_class = class_create(THIS_MODULE, DEVICE_NAME);
61f45d975621be Brian Kim 2017-01-10 203 err = IS_ERR(exynos_gpiomem_class);
61f45d975621be Brian Kim 2017-01-10 204 if (err)
61f45d975621be Brian Kim 2017-01-10 205 goto failed_class_create;
61f45d975621be Brian Kim 2017-01-10 206
61f45d975621be Brian Kim 2017-01-10 207 exynos_gpiomem_dev = device_create(exynos_gpiomem_class, NULL,
61f45d975621be Brian Kim 2017-01-10 208 exynos_gpiomem_devid, NULL,
61f45d975621be Brian Kim 2017-01-10 209 "gpiomem");
61f45d975621be Brian Kim 2017-01-10 210 err = IS_ERR(exynos_gpiomem_dev);
61f45d975621be Brian Kim 2017-01-10 211 if (err)
61f45d975621be Brian Kim 2017-01-10 212 goto failed_device_create;
61f45d975621be Brian Kim 2017-01-10 213
61f45d975621be Brian Kim 2017-01-10 214 for (i = 0; i < inst->gpio_area_count; ++i) {
61f45d975621be Brian Kim 2017-01-10 215 dev_info(inst->dev, "Initialised: Registers at 0x%08lx",
61f45d975621be Brian Kim 2017-01-10 216 inst->gpio_regs_phys[i]);
61f45d975621be Brian Kim 2017-01-10 217 }
61f45d975621be Brian Kim 2017-01-10 218
61f45d975621be Brian Kim 2017-01-10 219 return 0;
61f45d975621be Brian Kim 2017-01-10 220
61f45d975621be Brian Kim 2017-01-10 221 failed_device_create:
61f45d975621be Brian Kim 2017-01-10 222 class_destroy(exynos_gpiomem_class);
61f45d975621be Brian Kim 2017-01-10 223 failed_class_create:
61f45d975621be Brian Kim 2017-01-10 224 cdev_del(&exynos_gpiomem_cdev);
61f45d975621be Brian Kim 2017-01-10 225 failed_cdev_add:
61f45d975621be Brian Kim 2017-01-10 226 unregister_chrdev_region(exynos_gpiomem_devid, 1);
61f45d975621be Brian Kim 2017-01-10 227 failed_alloc_chrdev:
61f45d975621be Brian Kim 2017-01-10 228 failed_get_resource:
61f45d975621be Brian Kim 2017-01-10 229 kfree(inst);
^^^^^^^^^^^Ugh... Why didn't it warn about this use after free?
61f45d975621be Brian Kim 2017-01-10 230 failed_inst_alloc:
61f45d975621be Brian Kim 2017-01-10 @231 dev_err(inst->dev, "could not load exynos_gpiomem");
^^^^^^^^^61f45d975621be Brian Kim 2017-01-10 232 return err; 61f45d975621be Brian Kim 2017-01-10 233 }
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki