Skip to contentSkip to conversation

buildtools-tarball: add wic dependency into buildtools

PATCH Superseded Changqing Li 2 participants 3 messages Nov 19, 2020 – Nov 25, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 buildtools-tarball: add wic dependency into buildtools

fix below error:
wic ls ./core-image-minimal-intel-x86-64.wic

ERROR: Can't find executable parted

wic depend on some tools like parted/mtools/..., and we have those tools in native_sysroot. so above problem can be avoided by run command like wic ls imagename.wic --native-sysroot <path>

but this cannot cover condition that usr don't have build the image, the image just copy from somewhere.

---
 meta/recipes-core/meta/buildtools-tarball.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-core/meta/buildtools-tarball.bb +3 -0
index 560b8d67b9..7783fabbf2 100644
@@ -29,6 +29,9 @@ TOOLCHAIN_HOST_TASK ?= "\
     nativesdk-rpcsvc-proto \
     nativesdk-patch \
     nativesdk-mtools \
+    nativesdk-parted \
+    nativesdk-dosfstools \
+    nativesdk-gptfdisk \
     "
 
 MULTIMACH_TARGET_SYS = "${SDK_ARCH}-nativesdk${SDK_VENDOR}-${SDK_OS}"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 23 lines · Changqing Li

fix below error:
wic ls ./core-image-minimal-intel-x86-64.wic

ERROR: Can't find executable parted

wic depend on some tools like parted/mtools/..., and we have those tools in native_sysroot. so above problem can be avoided by run command like wic ls imagename.wic --native-sysroot <path>

but this cannot cover condition that usr don't have build the image, the image just copy from somewhere.

---
 meta/recipes-core/meta/buildtools-tarball.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-core/meta/buildtools-tarball.bb +0 -0
index 560b8d67b9..7783fabbf2 100644

meta/recipes-core/meta/buildtools-tarball.bb TOOLCHAIN_HOST_TASK ?= "\ · line 35

Quoted 7 lines
meta/recipes-core/meta/buildtools-tarball.bb +3 -0
@@ -29,6 +29,9 @@ TOOLCHAIN_HOST_TASK ?= "\
     nativesdk-rpcsvc-proto \
     nativesdk-patch \
     nativesdk-mtools \
+    nativesdk-parted \
+    nativesdk-dosfstools \
+    nativesdk-gptfdisk \
     "

These sound more like something which would be in buildtools-extended- tarball. Our rough metric for inclusion in this recipe is whether the tools are needed by an OE build and these are not, they're only needed for standalone wic usage. I'm therefore unsure whether we should be adding them at all.

Any other opinions?

Cheers,
Richard

#2 lore raw
Quoted 39 lines · Richard Purdie

[Please note this e-mail is from an EXTERNAL e-mail address]

Quoted 23 lines · Changqing Li

fix below error:
wic ls ./core-image-minimal-intel-x86-64.wic

ERROR: Can't find executable parted

wic depend on some tools like parted/mtools/..., and we have those tools in native_sysroot. so above problem can be avoided by run command like wic ls imagename.wic --native-sysroot <path>

but this cannot cover condition that usr don't have build the image, the image just copy from somewhere.

---
  meta/recipes-core/meta/buildtools-tarball.bb | 3 +++
  1 file changed, 3 insertions(+)
meta/recipes-core/meta/buildtools-tarball.bb +0 -0
index 560b8d67b9..7783fabbf2 100644

meta/recipes-core/meta/buildtools-tarball.bb TOOLCHAIN_HOST_TASK ?= "\ · line 35

Quoted 7 lines
meta/recipes-core/meta/buildtools-tarball.bb +3 -0
@@ -29,6 +29,9 @@ TOOLCHAIN_HOST_TASK ?= "\
      nativesdk-rpcsvc-proto \
      nativesdk-patch \
      nativesdk-mtools \
+    nativesdk-parted \
+    nativesdk-dosfstools \
+    nativesdk-gptfdisk \
      "

These sound more like something which would be in buildtools-extended- tarball. Our rough metric for inclusion in this recipe is whether the tools are needed by an OE build and these are not, they're only needed for standalone wic usage. I'm therefore unsure whether we should be adding them at all.

Quoted 4 lines

Any other opinions?

Cheers,
Richard

ok. I will send a v2 to add them into buildtools-extended-tarbal.  Thanks.

changqing

Quoted 1 line