Skip to contentSkip to conversation

drm/i915/gt: allow setting generic data pointer

PATCH In review Andi Shyti 4 participants 9 messages Mar 6, 2020 – Mar 7, 2020

Subsystems (2)
lore
Share & tools
lore

Andi Shyti

author
#0 lore raw

PATCH 1/1 drm/i915/gt: allow setting generic data pointer

When registering debugfs files the intel gt debugfs library forces a 'struct *gt' private data on the caller.

There might be different needs, therefore make it generic by adding one more argument to the "debugfs_register_files()" function which gets the generic void private data as argument.

Still keep it simple by defining a wrapper where struct *gt is the chosen private data to be stored.

I take the chance to rename the functions by using "intel_gt_" as prefix instead of "debugfs_".

---
 drivers/gpu/drm/i915/gt/debugfs_engines.c |  2 +-
 drivers/gpu/drm/i915/gt/debugfs_gt.c      |  9 ++++-----
 drivers/gpu/drm/i915/gt/debugfs_gt.h      | 10 ++++++----
 drivers/gpu/drm/i915/gt/debugfs_gt_pm.c   |  2 +-
 4 files changed, 12 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/gt/debugfs_engines.c +1 -1
index 6a5e9ab20b94..3434df10d58c 100644
@@ -32,5 +32,5 @@ void debugfs_engines_register(struct intel_gt *gt, struct dentry *root)
 		{ "engines", &engines_fops },
 	};
 
-	debugfs_gt_register_files(gt, root, files, ARRAY_SIZE(files));
+	intel_gt_debugfs_register_file(gt, root, files, ARRAY_SIZE(files));
 }
drivers/gpu/drm/i915/gt/debugfs_gt.c +4 -5
index 75255aaacaed..9112a8585caf 100644
@@ -26,15 +26,14 @@ void debugfs_gt_register(struct intel_gt *gt)
 	debugfs_gt_pm_register(gt, root);
 }
 
-void debugfs_gt_register_files(struct intel_gt *gt,
-			       struct dentry *root,
-			       const struct debugfs_gt_file *files,
-			       unsigned long count)
+void __intel_gt_debugfs_register_files(struct intel_gt *gt, struct dentry *root,
+				       const struct debugfs_gt_file *files,
+				       unsigned long count, void *data)
 {
 	while (count--) {
 		if (!files->eval || files->eval(gt))
 			debugfs_create_file(files->name,
-					    0444, root, gt,
+					    0444, root, data,
 					    files->fops);
 
 		files++;
drivers/gpu/drm/i915/gt/debugfs_gt.h +6 -4
index 4ea0f06cda8f..1c01d70a2a44 100644
@@ -31,9 +31,11 @@ struct debugfs_gt_file {
 	bool (*eval)(const struct intel_gt *gt);
 };
 
-void debugfs_gt_register_files(struct intel_gt *gt,
-			       struct dentry *root,
-			       const struct debugfs_gt_file *files,
-			       unsigned long count);
+void __intel_gt_debugfs_register_files(struct intel_gt *gt, struct dentry *root,
+				       const struct debugfs_gt_file *files,
+				       unsigned long count, void *data);
+
+#define intel_gt_debugfs_register_file(_g, _r, _f, _c)	\
+	__intel_gt_debugfs_register_files(_g, _r, _f, _c, _g)
 
 #endif /* DEBUGFS_GT_H */
drivers/gpu/drm/i915/gt/debugfs_gt_pm.c +1 -1
index 059c9e5c002e..a8d2391a207a 100644
@@ -597,5 +597,5 @@ void debugfs_gt_pm_register(struct intel_gt *gt, struct dentry *root)
 		{ "rps_boost", &rps_boost_fops, rps_eval },
 	};
 
-	debugfs_gt_register_files(gt, root, files, ARRAY_SIZE(files));
+	intel_gt_debugfs_register_file(gt, root, files, ARRAY_SIZE(files));
 }
Signature · 6 lines
2.25.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 40 lines · Andi Shyti

When registering debugfs files the intel gt debugfs library forces a 'struct *gt' private data on the caller.

There might be different needs, therefore make it generic by adding one more argument to the "debugfs_register_files()" function which gets the generic void private data as argument.

Still keep it simple by defining a wrapper where struct *gt is the chosen private data to be stored.

I take the chance to rename the functions by using "intel_gt_" as prefix instead of "debugfs_".

---
  drivers/gpu/drm/i915/gt/debugfs_engines.c |  2 +-
  drivers/gpu/drm/i915/gt/debugfs_gt.c      |  9 ++++-----
  drivers/gpu/drm/i915/gt/debugfs_gt.h      | 10 ++++++----
  drivers/gpu/drm/i915/gt/debugfs_gt_pm.c   |  2 +-
  4 files changed, 12 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/gt/debugfs_engines.c +1 -1
index 6a5e9ab20b94..3434df10d58c 100644
@@ -32,5 +32,5 @@ void debugfs_engines_register(struct intel_gt *gt, struct dentry *root)
  		{ "engines", &engines_fops },
  	};
 
-	debugfs_gt_register_files(gt, root, files, ARRAY_SIZE(files));
+	intel_gt_debugfs_register_file(gt, root, files, ARRAY_SIZE(files));
  }
drivers/gpu/drm/i915/gt/debugfs_gt.c +0 -0
index 75255aaacaed..9112a8585caf 100644
@@ -26,15 +26,14 @@ void debugfs_gt_register(struct intel_gt *gt)
  	debugfs_gt_pm_register(gt, root);
  }
 

drivers/gpu/drm/i915/gt/debugfs_gt.c void debugfs_gt_register(struct intel_gt *gt) · line 34

Quoted 10 lines
drivers/gpu/drm/i915/gt/debugfs_gt.c +3 -4
-void debugfs_gt_register_files(struct intel_gt *gt,
-			       struct dentry *root,
-			       const struct debugfs_gt_file *files,
-			       unsigned long count)
+void __intel_gt_debugfs_register_files(struct intel_gt *gt, struct dentry *root,
+				       const struct debugfs_gt_file *files,
+				       unsigned long count, void *data)
  {
  	while (count--) {
  		if (!files->eval || files->eval(gt))

IMO the files->eval() function should also use the provided data instead of intel_gt. This will also allow us to drop the intel_gt parameter in this function, which in turn means we can use this function directly from all the levels.

Daniele

Quoted 32 lines
drivers/gpu/drm/i915/gt/debugfs_gt.c +1 -1
  			debugfs_create_file(files->name,
-					    0444, root, gt,
+					    0444, root, data,
  					    files->fops);
 
  		files++;
drivers/gpu/drm/i915/gt/debugfs_gt.h +6 -4
index 4ea0f06cda8f..1c01d70a2a44 100644
@@ -31,9 +31,11 @@ struct debugfs_gt_file {
  	bool (*eval)(const struct intel_gt *gt);
  };
 
-void debugfs_gt_register_files(struct intel_gt *gt,
-			       struct dentry *root,
-			       const struct debugfs_gt_file *files,
-			       unsigned long count);
+void __intel_gt_debugfs_register_files(struct intel_gt *gt, struct dentry *root,
+				       const struct debugfs_gt_file *files,
+				       unsigned long count, void *data);
+
+#define intel_gt_debugfs_register_file(_g, _r, _f, _c)	\
+	__intel_gt_debugfs_register_files(_g, _r, _f, _c, _g)
 
  #endif /* DEBUGFS_GT_H */
drivers/gpu/drm/i915/gt/debugfs_gt_pm.c +0 -0
index 059c9e5c002e..a8d2391a207a 100644

drivers/gpu/drm/i915/gt/debugfs_gt_pm.c void debugfs_gt_pm_register(struct intel_gt *gt, struct dentry *root) · line 601

Quoted 6 lines
drivers/gpu/drm/i915/gt/debugfs_gt_pm.c +1 -1
@@ -597,5 +597,5 @@ void debugfs_gt_pm_register(struct intel_gt *gt, struct dentry *root)
  		{ "rps_boost", &rps_boost_fops, rps_eval },
  	};
 
-	debugfs_gt_register_files(gt, root, files, ARRAY_SIZE(files));
+	intel_gt_debugfs_register_file(gt, root, files, ARRAY_SIZE(files));
  }

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#2 lore raw

Hi Daniele,

Quoted 14 lines
Quoted 14 lines
drivers/gpu/drm/i915/gt/debugfs_gt.c +3 -4
index 75255aaacaed..9112a8585caf 100644
@@ -26,15 +26,14 @@ void debugfs_gt_register(struct intel_gt *gt)
  	debugfs_gt_pm_register(gt, root);
  }
-void debugfs_gt_register_files(struct intel_gt *gt,
-			       struct dentry *root,
-			       const struct debugfs_gt_file *files,
-			       unsigned long count)
+void __intel_gt_debugfs_register_files(struct intel_gt *gt, struct dentry *root,
+				       const struct debugfs_gt_file *files,
+				       unsigned long count, void *data)
Quoted 8 lines

drivers/gpu/drm/i915/gt/debugfs_gt.c void debugfs_gt_register(struct intel_gt *gt) · line 34

Quoted 3 lines
drivers/gpu/drm/i915/gt/debugfs_gt.c +0 -0
  {
  	while (count--) {
  		if (!files->eval || files->eval(gt))

IMO the files->eval() function should also use the provided data instead of intel_gt. This will also allow us to drop the intel_gt parameter in this function, which in turn means we can use this function directly from all the levels.

do you mean something like this:

- bool (*eval)(const struct intel_gt *gt);
+ bool (*eval)(void *data);

?

I am missing the use case, though, what is it that cannot be reached by the gt so that it needs to be more generic?

Do you want to use it at i915 level?

Thanks for the review,
Andi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 30 lines · Andi Shyti

Hi Daniele,

Quoted 14 lines
Quoted 14 lines
drivers/gpu/drm/i915/gt/debugfs_gt.c +3 -4
index 75255aaacaed..9112a8585caf 100644
@@ -26,15 +26,14 @@ void debugfs_gt_register(struct intel_gt *gt)
   	debugfs_gt_pm_register(gt, root);
   }
-void debugfs_gt_register_files(struct intel_gt *gt,
-			       struct dentry *root,
-			       const struct debugfs_gt_file *files,
-			       unsigned long count)
+void __intel_gt_debugfs_register_files(struct intel_gt *gt, struct dentry *root,
+				       const struct debugfs_gt_file *files,
+				       unsigned long count, void *data)
Quoted 8 lines

drivers/gpu/drm/i915/gt/debugfs_gt.c void debugfs_gt_register(struct intel_gt *gt) · line 34

Quoted 3 lines
drivers/gpu/drm/i915/gt/debugfs_gt.c +0 -0
   {
   	while (count--) {
   		if (!files->eval || files->eval(gt))

IMO the files->eval() function should also use the provided data instead of intel_gt. This will also allow us to drop the intel_gt parameter in this function, which in turn means we can use this function directly from all the levels.

do you mean something like this:

(quoted diff) +1 -1
-       bool (*eval)(const struct intel_gt *gt);
+       bool (*eval)(void *data);
Quoted 1 line

?

yes

Quoted 3 lines

I am missing the use case, though, what is it that cannot be reached by the gt so that it needs to be more generic?

It's not a problem of reaching it from gt but the other way around, I don't want the caller to have to retrieve a gt variable it don't needs just to pass it to this function and then go back to the actual required data from gt inside of the eval function. Anything you need for your evaluation should be reachable from the struct used as data for the debugfs. To make a concrete example, I want to avoid an unneeded guc_to_gt inside intel_guc_debugfs_register that would also require a matched guc = &gt->uc.guc inside the eval function, passing guc (i.e. the data) straight in the eval is cleaner IMO.

Daniele

Quoted 6 lines

Do you want to use it at i915 level?

Thanks for the review,
Andi

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Hi Daniele,

Quoted 36 lines
Quoted 28 lines
Quoted 14 lines
Quoted 14 lines
drivers/gpu/drm/i915/gt/debugfs_gt.c +3 -4
index 75255aaacaed..9112a8585caf 100644
@@ -26,15 +26,14 @@ void debugfs_gt_register(struct intel_gt *gt)
   	debugfs_gt_pm_register(gt, root);
   }
-void debugfs_gt_register_files(struct intel_gt *gt,
-			       struct dentry *root,
-			       const struct debugfs_gt_file *files,
-			       unsigned long count)
+void __intel_gt_debugfs_register_files(struct intel_gt *gt, struct dentry *root,
+				       const struct debugfs_gt_file *files,
+				       unsigned long count, void *data)
Quoted 8 lines

drivers/gpu/drm/i915/gt/debugfs_gt.c void debugfs_gt_register(struct intel_gt *gt) · line 34

Quoted 3 lines
drivers/gpu/drm/i915/gt/debugfs_gt.c +0 -0
   {
   	while (count--) {
   		if (!files->eval || files->eval(gt))

IMO the files->eval() function should also use the provided data instead of intel_gt. This will also allow us to drop the intel_gt parameter in this function, which in turn means we can use this function directly from all the levels.

do you mean something like this:

(quoted diff) +1 -1
-       bool (*eval)(const struct intel_gt *gt);
+       bool (*eval)(void *data);
Quoted 1 line

?

yes

Quoted 3 lines

I am missing the use case, though, what is it that cannot be reached by the gt so that it needs to be more generic?

Quoted 9 lines

It's not a problem of reaching it from gt but the other way around, I don't want the caller to have to retrieve a gt variable it don't needs just to pass it to this function and then go back to the actual required data from gt inside of the eval function. Anything you need for your evaluation should be reachable from the struct used as data for the debugfs.
To make a concrete example, I want to avoid an unneeded guc_to_gt inside intel_guc_debugfs_register that would also require a matched guc = &gt->uc.guc inside the eval function, passing guc (i.e. the data) straight in the eval is cleaner IMO.

Thanks for the feedback, makes sense.

Andi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: allow setting generic data pointer

In reply to Andi Shyti
== Series Details ==

== Series Details ==

Series: drm/i915/gt: allow setting generic data pointer
URL : https://patchwork.freedesktop.org/series/74360/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b5c27a068592 drm/i915/gt: allow setting generic data pointer
-:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_g' - possible side-effects?
#72: FILE: drivers/gpu/drm/i915/gt/debugfs_gt.h:38:
+#define intel_gt_debugfs_register_file(_g, _r, _f, _c)	\
+	__intel_gt_debugfs_register_files(_g, _r, _f, _c, _g)

total: 0 errors, 0 warnings, 1 checks, 46 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: allow setting generic data pointer

In reply to Andi Shyti
== Series Details ==

== Series Details ==

Series: drm/i915/gt: allow setting generic data pointer
URL : https://patchwork.freedesktop.org/series/74360/
State : warning

== Summary ==

$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or member 'get_freq' not described in 'intel_shared_dpll_funcs'

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: allow setting generic data pointer

In reply to Andi Shyti
== Series Details ==

== Series Details ==

Series: drm/i915/gt: allow setting generic data pointer
URL : https://patchwork.freedesktop.org/series/74360/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8074 -> Patchwork_16852
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/index.html

Known issues
------------

Here are the changes found in Patchwork_16852 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_addfb_basic@bad-pitch-999:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([CI#94] / [i915#402]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/fi-tgl-y/igt@[email protected]

#### Possible fixes ####

* igt@prime_vgem@basic-gtt:
- fi-tgl-y: [DMESG-WARN][3] ([CI#94] / [i915#402]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/fi-tgl-y/igt@[email protected]

[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402

Participating hosts (50 -> 43)
------------------------------

Additional (1): fi-kbl-7560u
Missing (8): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_8074 -> Patchwork_16852

CI-20190529: 20190529
CI_DRM_8074: 0dd63259839ca847514d9999749219635f311015 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5495: 22df72de8affcec22d9f354bb6148d77f60cc580 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16852: b5c27a068592cbdb2b4abf4e73ee5e305e3e227d @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

b5c27a068592 drm/i915/gt: allow setting generic data pointer

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: allow setting generic data pointer

In reply to Andi Shyti
== Series Details ==

== Series Details ==

Series: drm/i915/gt: allow setting generic data pointer
URL : https://patchwork.freedesktop.org/series/74360/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8074_full -> Patchwork_16852_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_16852_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-kbl1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-kbl2/igt@[email protected]

* igt@gem_exec_schedule@implicit-write-read-bsd2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [i915#677])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +7 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb2/igt@[email protected]

* igt@i915_pm_rps@min-max-config-loaded:
- shard-iclb: [PASS][11] -> [FAIL][12] ([i915#370])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb2/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#413])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb4/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-apl4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-apl4/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#79])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-skl8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-skl10/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#49])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-skl7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-skl5/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-skl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-skl5/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb3/igt@kms_psr@psr2_no_drrs.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][25] -> [FAIL][26] ([i915#31])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-apl1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-apl1/igt@[email protected]

* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#112080]) +9 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb6/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_schedule@implicit-both-bsd:
- shard-iclb: [SKIP][29] ([i915#677]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb6/igt@[email protected]

* igt@gem_exec_schedule@implicit-both-bsd2:
- shard-iclb: [SKIP][31] ([fdo#109276] / [i915#677]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][33] ([fdo#109276]) -> [PASS][34] +15 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][35] ([fdo#112146]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb3/igt@[email protected]

* igt@gem_exec_store@cachelines-vcs1:
- shard-iclb: [SKIP][37] ([fdo#112080]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb8/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb4/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-priority:
- shard-glk: [DMESG-WARN][39] ([i915#118] / [i915#95]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-glk5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-glk7/igt@[email protected]

* igt@i915_pm_dc@dc5-dpms:
- shard-skl: [INCOMPLETE][41] ([i915#198]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-skl9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-skl7/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-tglb: [FAIL][43] ([i915#413]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-tglb1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-tglb6/igt@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-kbl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-kbl2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-kbl7/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-a-64x64-bottom-edge:
- shard-snb: [SKIP][47] ([fdo#109271]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-snb6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-snb2/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][49] ([i915#57]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-hsw8/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-hsw4/igt@[email protected]

* igt@kms_flip_tiling@flip-yf-tiled:
- shard-skl: [FAIL][51] ([fdo#108145]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-skl10/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-skl8/igt@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

#### Warnings ####

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [DMESG-WARN][55] ([fdo#111870]) -> [DMESG-WARN][56] ([fdo#110789] / [fdo#111870])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8074/shard-hsw8/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/shard-hsw4/igt@[email protected]

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#370]: https://gitlab.freedesktop.org/drm/intel/issues/370
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_8074 -> Patchwork_16852

CI-20190529: 20190529
CI_DRM_8074: 0dd63259839ca847514d9999749219635f311015 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5495: 22df72de8affcec22d9f354bb6148d77f60cc580 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16852: b5c27a068592cbdb2b4abf4e73ee5e305e3e227d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16852/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx