linux-usb:optimize to match the Huawei USB storage devices and support new switch command
Subsystems (2)
PATCH 2/2 linux-usb:optimize to match the Huawei USB storage devices and support new switch command
From: fangxiaozhi <[email protected]>
1. Optimize the match rules with new macro for Huawei USB storage devices, to avoid to load USB storage driver for the modem interface with Huawei devices.
2. Add to support new switch command for new Huawei USB dongles.
--------------------------------------------------------------------
drivers/usb/storage/initializers.c 2013-01-22 14:28:21.512294889 +0800 renamed from drivers/usb/storage/initializers.c 2013-01-22 14:12:42.594238726 +0800 +74 -2
@@ -92,8 +92,8 @@ int usb_stor_ucr61s2b_init(struct us_dat return 0; } -/* This places the HUAWEI E220 devices in multi-port mode */ -int usb_stor_huawei_e220_init(struct us_data *us) +/* This places the HUAWEI usb dongles in multi-port mode */ +static int usb_stor_huawei_feature_init(struct us_data *us) { int result;
@@ -104,3 +104,75 @@ int usb_stor_huawei_e220_init(struct us_ US_DEBUGP("Huawei mode set result is %d\n", result); return 0; } + +/* + * It will send a scsi switch command called rewind' to huawei dongle. + * When the dongle receives this command at the first time, + * it will reboot immediately. After rebooted, it will ignore this command. + * So it is unnecessary to read its response. + */ +static int usb_stor_huawei_scsi_init(struct us_data *us) +{ + int result = 0; + int act_len = 0; + struct bulk_cb_wrap *bcbw = (struct bulk_cb_wrap *) us->iobuf; + char rewind_cmd[] = {0x11, 0x06, 0x20, 0x00, 0x00, 0x01, 0x01, 0x00, + 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; + + bcbw->Signature = cpu_to_le32(US_BULK_CB_SIGN); + bcbw->Tag = 0; + bcbw->DataTransferLength = 0; + bcbw->Flags = bcbw->Lun = 0; + bcbw->Length = sizeof(rewind_cmd); + memset(bcbw->CDB, 0, sizeof(bcbw->CDB)); + memcpy(bcbw->CDB, rewind_cmd, sizeof(rewind_cmd)); + + result = usb_stor_bulk_transfer_buf(us, us->send_bulk_pipe, bcbw, + US_BULK_CB_WRAP_LEN, &act_len); + US_DEBUGP("transfer actual length=%d, result=%d\n", act_len, result); + return result; +} + +/* + * It tries to find the supported Huawei USB dongles. + * In Huawei, they assign the following product IDs + * for all of their mobile broadband dongles, + * including the new dongles in the future. + * So if the product ID is not included in this list, + * it means it is not Huawei's mobile broadband dongles. + */ +static int usb_stor_huawei_dongles_pid(struct us_data *us) +{ + struct usb_interface_descriptor *idesc; + int idProduct; + + idesc = &us->pusb_intf->cur_altsetting->desc; + idProduct = us->pusb_dev->descriptor.idProduct; + /* The first port is CDROM, + * means the dongle in the single port mode, + * and a switch command is required to be sent. */ + if (idesc && idesc->bInterfaceNumber == 0) { + if ((idProduct == 0x1001) + || (idProduct == 0x1003) + || (idProduct == 0x1004) + || (idProduct >= 0x1401 && idProduct <= 0x1500) + || (idProduct >= 0x1505 && idProduct <= 0x1600) + || (idProduct >= 0x1c02 && idProduct <= 0x2202)) { + return 1; + } + } + return 0; +} + +int usb_stor_huawei_init(struct us_data *us) +{ + int result = 0; + + if (usb_stor_huawei_dongles_pid(us)) { + if (us->pusb_dev->descriptor.idProduct >= 0x1446) + result = usb_stor_huawei_scsi_init(us); + else + result = usb_stor_huawei_feature_init(us); + } + return result; +}
drivers/usb/storage/initializers.h 2013-01-22 14:19:53.208263547 +0800 renamed from drivers/usb/storage/initializers.h 2013-01-22 14:12:42.595238727 +0800 +2 -2
@@ -46,5 +46,5 @@ int usb_stor_euscsi_init(struct us_data * flash reader */ int usb_stor_ucr61s2b_init(struct us_data *us); -/* This places the HUAWEI E220 devices in multi-port mode */ -int usb_stor_huawei_e220_init(struct us_data *us); +/* This places the HUAWEI usb dongles in multi-port mode */ +int usb_stor_huawei_init(struct us_data *us);
drivers/usb/storage/unusual_devs.h 2013-01-22 14:19:53.208263547 +0800 renamed from drivers/usb/storage/unusual_devs.h 2013-01-22 14:12:42.594238726 +0800 +2 -327
337 lines not on this page · raw message
Quoted 18 lines · On Fri, Jan 25, 2013 at 10:46:13AM +0800, fangxiaozhi 00110321 wrote:
diff -uprN
linux-3.8-rc4_orig/drivers/usb/storage/initializers.clinux-3.8-rc4/drivers/usb/storage/initializers.cdrivers/usb/storage/initializers.c 2013-01-22 14:28:21.512294889 +0800 renamed from drivers/usb/storage/initializers.c 2013-01-22 14:12:42.594238726 +0800 +11
-0@@ -104,3 +104,75 @@ int usb_stor_huawei_e220_init(struct us_ US_DEBUGP("Huawei mode set result is %d\n", result); return 0; } + +/* + * It will send a scsi switch command called rewind' to huawei dongle. + * When the dongle receives this command at the first time, + * it will reboot immediately. After rebooted, it will ignore this command. + * So it is unnecessary to read its response. + */ +static int usb_stor_huawei_scsi_init(struct us_data *us) +{ + int result = 0; + int act_len = 0;
drivers/usb/storage/initializers.c 2013-01-22 14:28:21.512294889 +0800 int usb_stor_huawei_e220_init(struct us_ · line 127
Quoted 10 lines
drivers/usb/storage/initializers.c 2013-01-22 14:28:21.512294889 +0800 renamed from drivers/usb/storage/initializers.c 2013-01-22 14:12:42.594238726 +0800 +10
-0+ struct bulk_cb_wrap *bcbw = (struct bulk_cb_wrap *) us->iobuf; + char rewind_cmd[] = {0x11, 0x06, 0x20, 0x00, 0x00, 0x01, 0x01, 0x00, + 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; + + bcbw->Signature = cpu_to_le32(US_BULK_CB_SIGN); + bcbw->Tag = 0; + bcbw->DataTransferLength = 0; + bcbw->Flags = bcbw->Lun = 0; + bcbw->Length = sizeof(rewind_cmd); + memset(bcbw->CDB, 0, sizeof(bcbw->CDB));
First you memset() 16 bytes of CDB to 0
drivers/usb/storage/initializers.c 2013-01-22 14:28:21.512294889 +0800 int usb_stor_huawei_e220_init(struct us_ · line 128
Quoted 1 line
drivers/usb/storage/initializers.c 2013-01-22 14:28:21.512294889 +0800 renamed from drivers/usb/storage/initializers.c 2013-01-22 14:12:42.594238726 +0800 +1
-0+ memcpy(bcbw->CDB, rewind_cmd, sizeof(rewind_cmd));
And now you copy 16 bytes from rewind_cmd to CDB. So the memset is not really required, is it?
drivers/usb/storage/initializers.c 2013-01-22 14:28:21.512294889 +0800 int usb_stor_huawei_e220_init(struct us_ · line 134
Quoted 6 lines
drivers/usb/storage/initializers.c 2013-01-22 14:28:21.512294889 +0800 renamed from drivers/usb/storage/initializers.c 2013-01-22 14:12:42.594238726 +0800 +6
-0+ + result = usb_stor_bulk_transfer_buf(us, us->send_bulk_pipe, bcbw, + US_BULK_CB_WRAP_LEN, &act_len); + US_DEBUGP("transfer actual length=%d, result=%d\n", act_len, result); + return result; +}
Sebastian