Skip to contentSkip to conversation

clk: kendryte: no need to check argument of free()

PATCH New Heinrich Schuchardt 2 participants 2 messages Sep 29, 2020 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: kendryte: no need to check argument of free()

free() checks if its argument is NULL. No need to check it twice.

---
 drivers/clk/kendryte/clk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/kendryte/clk.c +1 -2
index 981b3b7699..26139fd804 100644
@@ -471,8 +471,7 @@ cleanup_gate:
 cleanup_div:
 	free(div);
 cleanup_mux:
-	if (mux)
-		free(mux);
+	free(mux);
 	return comp;
 }
 

--
2.28.0

#1 lore raw

PATCH 1/1 clk: kendryte: no need to check argument of free()

Quoted 22 lines · Heinrich Schuchardt

free() checks if its argument is NULL. No need to check it twice.

---
 drivers/clk/kendryte/clk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/kendryte/clk.c +1 -3
index 981b3b7699..26139fd804 100644
@@ -471,8 +471,7 @@ cleanup_gate:
 cleanup_div:
 	free(div);
 cleanup_mux:
-	if (mux)
-		free(mux);
+	free(mux);
 	return comp;
 }
 
--
Quoted 2 lines

2.28.0

LGTM