Skip to contentSkip to conversation

libseccomp: Add missing files for ptests

PATCH In review Joerg Vehlow 3 participants 4 messages May 25, 2022 – May 30, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libseccomp: Add missing files for ptests

From: Joerg Vehlow <[email protected]>

pfc files are used e.g. in 38-basic-pfc_coverage.sh valgrind_test.supp is required, when valgrind is installed, otherwise all valgrind tests fail

---
 meta/recipes-support/libseccomp/libseccomp_2.5.4.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-support/libseccomp/libseccomp_2.5.4.bb +4 -0
index c76f3c3573..731d9ae08d 100644
@@ -37,6 +37,10 @@ do_install_ptest() {
     for file in $(find tests/*.tests -type f); do
         install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     done
+        for file in $(find tests/*.pfc -type f); do
+        install -m 644 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    install -m 644 ${S}/tests/valgrind_test.supp ${D}/${PTEST_PATH}/tests
     for file in $(find tools/* -executable -type f); do
         install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
     done
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · J?rg Vehlow

From: Joerg Vehlow <[email protected]>

pfc files are used e.g. in 38-basic-pfc_coverage.sh valgrind_test.supp is required, when valgrind is installed, otherwise all valgrind tests fail

Is this issue specific to 2.5.4 or does it also apply to the 2.5.3 version in kirkstone?

Thanks!

Steve

Quoted 32 lines
---
 meta/recipes-support/libseccomp/libseccomp_2.5.4.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-support/libseccomp/libseccomp_2.5.4.bb +4 -1
index c76f3c3573..731d9ae08d 100644
@@ -37,6 +37,10 @@ do_install_ptest() {
     for file in $(find tests/*.tests -type f); do
         install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tests
     done
+        for file in $(find tests/*.pfc -type f); do
+        install -m 644 ${S}/${file} ${D}/${PTEST_PATH}/tests
+    done
+    install -m 644 ${S}/tests/valgrind_test.supp ${D}/${PTEST_PATH}/tests
     for file in $(find tools/* -executable -type f); do
         install -m 744 ${S}/${file} ${D}/${PTEST_PATH}/tools
     done
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#166108): https://lists.openembedded.org/g/openembedded-core/message/166108
Mute This Topic: https://lists.openembedded.org/mt/91329522/3620601
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

Hi Steve,

Am 5/30/2022 um 4:35 PM schrieb Steve Sakoman:

Quoted 10 lines · J?rg Vehlow
Quoted 6 lines

From: Joerg Vehlow <[email protected]>

pfc files are used e.g. in 38-basic-pfc_coverage.sh valgrind_test.supp is required, when valgrind is installed, otherwise all valgrind tests fail

Is this issue specific to 2.5.4 or does it also apply to the 2.5.3 version in kirkstone?

I am pretty sure that depending on the configuration (e.g. valgrind installed or bpf enabled), that these files are required in at least all 2.5 versions.

Quoted 4 lines

Thanks!

Steve

Joerg

#3 lore raw
Quoted 12 lines · J?rg Vehlow

Hi Steve,

Am 5/30/2022 um 4:35 PM schrieb Steve Sakoman:

Quoted 8 lines · J?rg Vehlow
Quoted 6 lines

From: Joerg Vehlow <[email protected]>

pfc files are used e.g. in 38-basic-pfc_coverage.sh valgrind_test.supp is required, when valgrind is installed, otherwise all valgrind tests fail

Quoted 5 lines
Quoted 2 lines

Is this issue specific to 2.5.4 or does it also apply to the 2.5.3 version in kirkstone?

I am pretty sure that depending on the configuration (e.g. valgrind installed or bpf enabled), that these files are required in at least all 2.5 versions.

OK, will add this to my test queue.

Thanks!

Steve