Skip to contentSkip to conversation

arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name

PATCH Applied Vinod Koul 4 participants 4 messages Apr 21, 2022 – Apr 23, 2022

Subsystems (3)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name

Per DT spec node names should not have underscores (_) in them, so change can_clock to can-clock.

Fixes 5c44c564e449 ("arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD")
---
 arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +1 -1
index 845eb7a6bf92..0e63f707b911 100644
@@ -29,7 +29,7 @@ chosen {
 	};
 
 	/* Fixed crystal oscillator dedicated to MCP2518FD */
-	clk40M: can_clock {
+	clk40M: can-clock {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
 		clock-frequency = <40000000>;
Signature · 1 line
2.34.1
#2 lore raw
In reply to Vinod Koul
Quoted 14 lines · Vinod Koul

Per DT spec node names should not have underscores (_) in them, so change can_clock to can-clock.

Fixes 5c44c564e449 ("arm64: dts: qcom: qrb5165-rb5: Add support for MCP2518FD")
---
 arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +0 -0
index 845eb7a6bf92..0e63f707b911 100644

arch/arm64/boot/dts/qcom/qrb5165-rb5.dts chosen { · line 32

Quoted 5 lines
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +1 -1
@@ -29,7 +29,7 @@ chosen {
 	};
 
 	/* Fixed crystal oscillator dedicated to MCP2518FD */
-	clk40M: can_clock {
+	clk40M: can-clock {

Should the node name be just "clock"?

Thanks,
Mani

Quoted 6 lines
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +0 -0
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
 		clock-frequency = <40000000>;
Signature · 1 line
2.34.1
#3 lore raw

Re: (subset) [PATCH] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name

In reply to Vinod Koul
Quoted 4 lines · Vinod Koul

Per DT spec node names should not have underscores (_) in them, so change can_clock to can-clock.

Applied, thanks!

[1/1] arm64: dts: qcom: qrb5165-rb5: Fix can-clock node name

      commit: 1eae95fb1d696968ca72be3ac8e0d62bb4d8da42

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>