Skip to contentSkip to conversation

Minor inconsistency: "git tag" requires space after -m.

DISCUSSION Sergei Organov 2 participants 3 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

Hello,

It seems options parsing is somewhat broken in git-tag:

$ git tag -a -m"Annotated tag" annotated-tag
usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>]
$ git tag -a -m "Annotated tag" annotated-tag
$ git --version
git version 1.5.3.4

This is inconsistent with, say, "git commit", that groks -m"Message" (without space after -m) just fine.

Signature · 1 line
Sergei.
#1 lore raw

Hi,

Quoted 10 lines · Sergei Organov

It seems options parsing is somewhat broken in git-tag:

$ git tag -a -m"Annotated tag" annotated-tag
usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>]
$ git tag -a -m "Annotated tag" annotated-tag
$ git --version
git version 1.5.3.4

This is inconsistent with, say, "git commit", that groks -m"Message" (without space after -m) just fine.

As it happens, we are in the middle of adding our own option parser which probably solves the issue. Can you please retest when we have that, and use it in builtin-tag?

Thanks,
Dscho

#2 lore raw
Quoted 12 lines · Johannes Schindelin

Hi,

Quoted 8 lines · Sergei Organov

It seems options parsing is somewhat broken in git-tag:

$ git tag -a -m"Annotated tag" annotated-tag
usage: git-tag [-n [<num>]] -l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>] <tagname> [<head>]
$ git tag -a -m "Annotated tag" annotated-tag
$ git --version
git version 1.5.3.4
Quoted 6 lines
Quoted 2 lines

This is inconsistent with, say, "git commit", that groks -m"Message" (without space after -m) just fine.

As it happens, we are in the middle of adding our own option parser which probably solves the issue. Can you please retest when we have that, and use it in builtin-tag?

I'm 100% sure there will be no inconsistencies once you unify options parsing among the tools, but I won't refrain from re-testing this anyway.

Signature · 1 line
Sergei.