Skip to contentSkip to conversation

sensors-detect: Move Winbond WPCD377I to the non-hwmon table

PATCH Applied Jean Delvare 2 participants 2 messages May 12, 2020 – May 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sensors-detect: Move Winbond WPCD377I to the non-hwmon table

Move the detection entry for the Winbond WPCD377I to the @non_hwmon_chip_ids table, where it belongs. This saves one line, and more importantly prevents "not-a-sensor" from being accidentally added to the list of kernel drivers.

---
 prog/detect/sensors-detect |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
prog/detect/sensors-detect +4 -5
@@ -719,11 +719,6 @@
 		i2c_addrs => [0x2c..0x2e],
 		i2c_detect => sub { emc6w201_detect(@_); },
 	}, {
-		name => "Winbond WPCD377I",
-		driver => "not-a-sensor",
-		i2c_addrs => [0x2c..0x2e],
-		i2c_detect => sub { lm85_detect(@_, 7); },
-	}, {
 		name => "Analog Devices ADT7462",
 		driver => "adt7462",
 		i2c_addrs => [0x5c, 0x58],
@@ -1684,6 +1679,10 @@
 		i2c_addrs => [0x2c..0x2f],
 		i2c_detect => sub { w83791sd_detect(@_); },
 	}, {
+		name => "Winbond WPCD377I",
+		i2c_addrs => [0x2c..0x2e],
+		i2c_detect => sub { lm85_detect(@_, 7); },
+	}, {
 		name => "Fintek F75111R/RG/N (GPIO)",
 		i2c_addrs => [0x37, 0x4e],
 		i2c_detect => sub { fintek_detect(@_, 1); },
Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw
Quoted 40 lines · Jean Delvare

Move the detection entry for the Winbond WPCD377I to the @non_hwmon_chip_ids table, where it belongs. This saves one line, and more importantly prevents "not-a-sensor" from being accidentally added to the list of kernel drivers.

---
 prog/detect/sensors-detect |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
prog/detect/sensors-detect +4 -5
@@ -719,11 +719,6 @@
 		i2c_addrs => [0x2c..0x2e],
 		i2c_detect => sub { emc6w201_detect(@_); },
 	}, {
-		name => "Winbond WPCD377I",
-		driver => "not-a-sensor",
-		i2c_addrs => [0x2c..0x2e],
-		i2c_detect => sub { lm85_detect(@_, 7); },
-	}, {
 		name => "Analog Devices ADT7462",
 		driver => "adt7462",
 		i2c_addrs => [0x5c, 0x58],
@@ -1684,6 +1679,10 @@
 		i2c_addrs => [0x2c..0x2f],
 		i2c_detect => sub { w83791sd_detect(@_); },
 	}, {
+		name => "Winbond WPCD377I",
+		i2c_addrs => [0x2c..0x2e],
+		i2c_detect => sub { lm85_detect(@_, 7); },
+	}, {
 		name => "Fintek F75111R/RG/N (GPIO)",
 		i2c_addrs => [0x37, 0x4e],
 		i2c_detect => sub { fintek_detect(@_, 1); },
Signature · 3 lines
-- 
Jean Delvare
SUSE L3 Support

Applied. Thanks!

Ondřej Lysoněk