Skip to contentSkip to conversation

hidraw support for Bluetooth HID devices

PATCH In review [email protected] 2 participants 3 messages Feb 13, 2008

Subsystems (2)
Bluetooth drivers Bluetooth
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 hidraw support for Bluetooth HID devices

This patch exposes Bluetooth HID peripherals to userspace through the hidraw API, in addition to the input subsystem. This improves consistency between hidp and usbhid.

net/bluetooth/hidp/core.c 2008-02-13 14:19:29.000000000 +0100 renamed from net/bluetooth/hidp/core.c.orig 2008-02-13 13:28:26.000000000 +0100 +5 -0
@@ -40,6 +40,7 @@
 
  #include <linux/input.h>
  #include <linux/hid.h>
+#include <linux/hidraw.h>
 
  #include <net/bluetooth/bluetooth.h>
  #include <net/bluetooth/hci_core.h>

@@ -589,6 +590,8 @@ static int hidp_session(void *arg)
         if (session->hid) {
                 if (session->hid->claimed & HID_CLAIMED_INPUT)
                         hidinput_disconnect(session->hid);
+               if (session->hid->claimed & HID_CLAIMED_HIDRAW)
+                       hidraw_disconnect(session->hid);
                 hid_free_device(session->hid);
         }
 

@@ -741,6 +744,8 @@ static inline void hidp_setup_hid(struct
 
         if (hidinput_connect(hid) == 0)
                 hid->claimed |= HID_CLAIMED_INPUT;
+       if (hidraw_connect(hid) == 0)
+               hid->claimed |= HID_CLAIMED_HIDRAW;
  }
 
  int hidp_add_connection(struct hidp_connadd_req *req, struct socket *ctrl_sock, struct socket *intr_sock)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

maintainer
#1 lore raw

Hi Pascal,

Quoted 3 lines

This patch exposes Bluetooth HID peripherals to userspace through the hidraw API, in addition to the input subsystem. This improves consistency between hidp and usbhid.

it misses a Signed-off-by line.

net/bluetooth/hidp/core.c 2008-02-13 14:19:29.000000000 +0100 line 43

Quoted 7 lines
net/bluetooth/hidp/core.c 2008-02-13 14:19:29.000000000 +0100 renamed from net/bluetooth/hidp/core.c.orig 2008-02-13 13:28:26.000000000 +0100 +1 -0
@@ -40,6 +40,7 @@
 
  #include <linux/input.h>
  #include <linux/hid.h>
+#include <linux/hidraw.h>

This looks like your editor can't handle inline very well.

Regards

Marcel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

author
#2 lore raw

PATCH 1/1 bluetooth: hidraw support for Bluetooth HID devices

From: "Pascal A. Brisset" <[email protected]>

This patch exposes Bluetooth HID peripherals to userspace through the hidraw API, in addition to the input subsystem. This improves consistency between hidp and usbhid.

Signed-off-by "Pascal A. Brisset" <[email protected]>
net/bluetooth/hidp/core.c renamed from net/bluetooth/hidp/core.c.orig +5 -0
@@ -40,6 +40,7 @@
 
 #include <linux/input.h>
 #include <linux/hid.h>
+#include <linux/hidraw.h>
 
 #include <net/bluetooth/bluetooth.h>
 #include <net/bluetooth/hci_core.h>

@@ -589,6 +590,8 @@ static int hidp_session(void *arg)
 	if (session->hid) {
 		if (session->hid->claimed & HID_CLAIMED_INPUT)
 			hidinput_disconnect(session->hid);
+		if (session->hid->claimed & HID_CLAIMED_HIDRAW)
+			hidraw_disconnect(session->hid);
 		hid_free_device(session->hid);
 	}
 

@@ -741,6 +744,8 @@ static inline void hidp_setup_hid(struct
 
 	if (hidinput_connect(hid) == 0)
 		hid->claimed |= HID_CLAIMED_INPUT;
+	if (hidraw_connect(hid) == 0)
+		hid->claimed |= HID_CLAIMED_HIDRAW;
 }
 
 int hidp_add_connection(struct hidp_connadd_req *req, struct socket *ctrl_sock, struct socket *intr_sock)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel