bridge: use netstats in net_device structure
Subsystems (3)
PATCH 1/1 bridge: use netstats in net_device structure
Use net_device_stats from net_device structure instead of local. Kill br_dev_get_stats function, because by default it is used identical internal_stats function from net/core/dev.c
Signed-off-by Paulius Zaleckas <[email protected]>
net/bridge/br_device.c +2 -9
@@ -21,12 +21,6 @@#include <asm/uaccess.h> #include "br_private.h" -static struct net_device_stats *br_dev_get_stats (struct net_device *dev) -{ -struct net_bridge *br =netdev_priv (dev); -return &br->statistics; -} -/* net device transmit always called with no BH (preempt_disabled) */ int br_dev_xmit (struct sk_buff *skb,struct net_device *dev) {
@@ -34,8 +28,8 @@ int br_dev_xmit(struct sk_buff *skb, strconst unsigned char *dest = skb->data;struct net_bridge_fdb_entry *dst; - br->statistics.tx_packets++; - br->statistics.tx_bytes += skb->len; + dev->stats.tx_packets++; + dev->stats.tx_bytes += skb->len;skb_reset_mac_header (skb);skb_pull (skb,ETH_HLEN );
@@ -161,7 +155,6 @@ void br_dev_setup(struct net_device *devether_setup (dev); dev->do_ioctl = br_dev_ioctl; - dev->get_stats = br_dev_get_stats; dev->hard_start_xmit = br_dev_xmit; dev->open = br_dev_open; dev->set_multicast_list = br_dev_set_multicast_list;
net/bridge/br_private.h +0 -1
@@ -90,7 +90,6 @@ struct net_bridgespinlock_t lock;struct list_head port_list;struct net_device *dev; -struct net_device_stats statistics;spinlock_t hash_lock;struct hlist_head hash[BR_HASH_SIZE ];struct list_head age_list;
net/bridge/br_forward.c +1 -1
@@ -115,7 +115,7 @@ static void br_flood(struct net_bridge *struct sk_buff *skb2;if ((skb2 =skb_clone (skb,GFP_ATOMIC )) ==NULL ) { - br->statistics.tx_dropped++; + br->dev->stats.tx_dropped++;kfree_skb (skb);return ; }
net/bridge/br_input.c +3 -3
@@ -26,8 +26,8 @@ static void br_pass_frame_up(struct net_ {struct net_device *indev; - br->statistics.rx_packets++; - br->statistics.rx_bytes += skb->len; + br->dev->stats.rx_packets++; + br->dev->stats.rx_bytes += skb->len; indev = skb->dev; skb->dev = br->dev;
@@ -64,7 +64,7 @@ int br_handle_frame_finish(struct sk_buf dst =NULL ;if (is_multicast_ether_addr (dest)) { - br->statistics.multicast++; + br->dev->stats.multicast++; skb2 = skb; }else if ((dst =__br_fdb_get (br, dest)) && dst->is_local) { skb2 = skb;
David Miller
maintainerYou didn't generate this patch against the current networking development tree and therefore you didn't notice that this change has been made already.