Skip to contentSkip to conversation

printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

RFC In review Dirk Gouders 2 participants 3 messages Oct 22, 2013 – Nov 6, 2013 Printk

lore
Share & tools
lore
#0 lore raw

RFC 1/1 printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

Hello Joe,

when having a look at printk.c, I noticed that two comments refer to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore.

While at it, a typo in one of those coments could also be fixed.

Best regards,

Dirk

Quoted 1 line

From 2ef84ff3187633a3156c3a967c1dfc294292e492 Mon Sep 17 00:00:00 2001

From: Dirk Gouders <[email protected]>
Date: Tue, 22 Oct 2013 13:51:15 +0200
Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of
/proc/vmcoreinfo

In one of those comments a typo was fixed, too.

---
 kernel/printk/printk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/printk/printk.c +2 -2
index b4e8500..694d1f9 100644
@@ -705,9 +705,9 @@ const struct file_operations kmsg_fops = {
 
 #ifdef CONFIG_KEXEC
 /*
- * This appends the listed symbols to /proc/vmcoreinfo
+ * This appends the listed symbols to /proc/vmcore
  *
- * /proc/vmcoreinfo is used by various utiilties, like crash and makedumpfile to
+ * /proc/vmcore is used by various utilities, like crash and makedumpfile to
  * obtain access to symbols that are otherwise very difficult to locate.  These
  * symbols are specifically used so that utilities can access and extract the
  * dmesg log from a vmcore file after a crash.
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 6 lines · Dirk Gouders

Hello Joe,

when having a look at printk.c, I noticed that two comments refer to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore.

While at it, a typo in one of those coments could also be fixed.

Hi Dirk.

Thanks and yes this is sensible.
Adding Andrew Morton to cc's and resending as plain-text

Quoted 1 line

From 2ef84ff3187633a3156c3a967c1dfc294292e492 Mon Sep 17 00:00:00 2001

From: Dirk Gouders <[email protected]>
Date: Tue, 22 Oct 2013 13:51:15 +0200
Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of
/proc/vmcoreinfo

In one of those comments a typo was fixed, too.

---
 kernel/printk/printk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/printk/printk.c +2 -2
index b4e8500..694d1f9 100644
@@ -705,9 +705,9 @@ const struct file_operations kmsg_fops = {
 
 #ifdef CONFIG_KEXEC
 /*
- * This appends the listed symbols to /proc/vmcoreinfo
+ * This appends the listed symbols to /proc/vmcore
  *
- * /proc/vmcoreinfo is used by various utiilties, like crash and makedumpfile to
+ * /proc/vmcore is used by various utilities, like crash and makedumpfile to
  * obtain access to symbols that are otherwise very difficult to locate.  These
  * symbols are specifically used so that utilities can access and extract the
  * dmesg log from a vmcore file after a crash.
Signature · 1 line
1.8.3.2
#2 lore raw
Quoted 6 lines · Joe Perches
Quoted 5 lines · Dirk Gouders

Hello Joe,

when having a look at printk.c, I noticed that two comments refer to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore.

Quoted 6 lines
Quoted 1 line

While at it, a typo in one of those coments could also be fixed.

Hi Dirk.

Thanks and yes this is sensible.
Adding Andrew Morton to cc's and resending as plain-text

Hi Joe and Andrew,

thank you for reviewing and accepting (indicated by another mail from Andrew) this patch.

Dirk

Quoted 29 lines

From 2ef84ff3187633a3156c3a967c1dfc294292e492 Mon Sep 17 00:00:00 2001
From: Dirk Gouders <[email protected]>
Date: Tue, 22 Oct 2013 13:51:15 +0200
Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of
/proc/vmcoreinfo

In one of those comments a typo was fixed, too.

---
 kernel/printk/printk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/printk/printk.c +2 -2
index b4e8500..694d1f9 100644
@@ -705,9 +705,9 @@ const struct file_operations kmsg_fops = {
 
 #ifdef CONFIG_KEXEC
 /*
- * This appends the listed symbols to /proc/vmcoreinfo
+ * This appends the listed symbols to /proc/vmcore
  *
- * /proc/vmcoreinfo is used by various utiilties, like crash and makedumpfile to
+ * /proc/vmcore is used by various utilities, like crash and makedumpfile to
  * obtain access to symbols that are otherwise very difficult to locate.  These
  * symbols are specifically used so that utilities can access and extract the
  * dmesg log from a vmcore file after a crash.