Skip to contentSkip to conversation

Sorting commit items by click on the table header in commit dialog.

PATCH In review Vasyl' Vavrychuk 2 participants 3 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Sorting commit items by click on the table header in commit dialog.

In order to implement new feature I have replaced class associated with every table row. CommitItem class encapsulate data that commit dialog manipulates with. Comparators are written using idiom from http://tobega.blogspot.com/2008/05/beautiful-enums.html.
Clicks on a certain column are handled in HeaderSelectionListener class.

---
 .../egit/ui/internal/actions/CommitAction.java     |    2 +-
 .../egit/ui/internal/dialogs/CommitDialog.java     |  248 ++++++++++++++------
 2 files changed, 176 insertions(+), 74 deletions(-)
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java +1 -1
index d703048..779596c 100644
@@ -139,7 +139,7 @@ private void loadPreviousCommit() {
 	private void performCommit(CommitDialog commitDialog, String commitMessage)
 			throws TeamException {
 		// System.out.println("Commit Message: " + commitMessage);
-		IFile[] selectedItems = commitDialog.getSelectedItems();
+		IFile[] selectedItems = commitDialog.getSelectedFiles();
 
 		HashMap<Repository, Tree> treeMap = new HashMap<Repository, Tree>();
 		try {
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java +175 -73

352 lines not on this page · raw message

Signature · 1 line
1.5.6.1.1071.g76fb
#1 lore raw

söndag 04 januari 2009 23:46:47 skrev Vasyl' Vavrychuk:

Quoted 4 lines

In order to implement new feature I have replaced class associated with every table row. CommitItem class encapsulate data that commit dialog manipulates with. Comparators are written using idiom from http://tobega.blogspot.com/2008/05/beautiful-enums.html.
Clicks on a certain column are handled in HeaderSelectionListener class.

Hmm. This one cannot be applied on top of master. There is only only one commit on Dec 8 that involves the same file, so If you could rebase that would be nice. Other than that it looks ok.

Please also Cc me and Shawn on patches to reduce the risk of them getting lost.

-- robin

#2 lore raw

Seems this was trivial to apply after patchin the patch, so I did.

-- robin