Skip to contentSkip to conversation

SIGSEGV when USE_KQEMU is defined

PATCH Applied Consul 2 participants 3 messages Feb 20, 2009 – Mar 3, 2009

lore
Share & tools
lore

Consul

author
#0 lore raw

PATCH 1/1 SIGSEGV when USE_KQEMU is defined

$ svn diff
Index: block.c
===================================================================
--- block.c     (revision 6628)
+++ block.c     (working copy)
@@ -1263,7 +1263,7 @@
     if (!s->is_write) {
         qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
     }
-    qemu_free(s->bounce);
+    qemu_vfree(s->bounce);
     s->this_aiocb->cb(s->this_aiocb->opaque, ret);
     qemu_aio_release(s->this_aiocb);
 }
author
#1 lore raw
Quoted 9 lines · Consul
$ svn diff
Index: block.c
===================================================================

block.c (working copy) line 1269

Quoted 8 lines
block.c (working copy) renamed from block.c (revision 6628) +1 -1
@@ -1263,7 +1263,7 @@
     if (!s->is_write) {
         qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
     }
-    qemu_free(s->bounce);
+    qemu_vfree(s->bounce);
     s->this_aiocb->cb(s->this_aiocb->opaque, ret);
     qemu_aio_release(s->this_aiocb);
 }

On Windows s->bounce = qemu_memalign(512, nb_sectors * 512);
translates to VirtualAlloc and should be freed with VirtualFree (what qemu_vfree does).

#2 lore raw
In reply to Consul
Quoted 8 lines · Consul
$ svn diff
Index: block.c
===================================================================

block.c (working copy) line 1269

Quoted 8 lines
block.c (working copy) renamed from block.c (revision 6628) +1 -1
@@ -1263,7 +1263,7 @@
     if (!s->is_write) {
         qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
     }
-    qemu_free(s->bounce);
+    qemu_vfree(s->bounce);
     s->this_aiocb->cb(s->this_aiocb->opaque, ret);
     qemu_aio_release(s->this_aiocb);
 }

Thanks, applied.

Signature · 2 lines
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net