Skip to contentSkip to conversation

Fix sigsegv on Windows host

PATCH RESEND In review Consul 3 participants 4 messages Feb 27, 2009 – Mar 3, 2009

lore
Share & tools
lore

Consul

author
#0 lore raw

PATCH RESEND 1/1 Fix sigsegv on Windows host

Is there a reason this patch has not been applied? I'm still getting sigsegv early in the boot of Windows images without it. s->bounce has been VirtualAlloc'ed and should be VirtualFree'ed.

signed-off-by Alex Ivanov <[email protected]>

block.c +1 -1
@@ -1263,7 +1263,7 @@
     if (!s->is_write) {
         qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
     }
-    qemu_free(s->bounce);
+    qemu_vfree(s->bounce);
     s->this_aiocb->cb(s->this_aiocb->opaque, ret);
     qemu_aio_release(s->this_aiocb);
 }
#1 lore raw
Quoted 8 lines · Consul

Is there a reason this patch has not been applied? I'm still getting sigsegv early in the boot of Windows images without it. s->bounce has been VirtualAlloc'ed and should be VirtualFree'ed.

signed-off-by Alex Ivanov <[email protected]>

block.c line 1269

Quoted 8 lines
block.c +1 -1
@@ -1263,7 +1263,7 @@
      if (!s->is_write) {
          qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
      }
-    qemu_free(s->bounce);
+    qemu_vfree(s->bounce);
      s->this_aiocb->cb(s->this_aiocb->opaque, ret);
      qemu_aio_release(s->this_aiocb);
  }

Could someone please apply this to SVN?! Thanks!

Robert Riebisch

Signature · 2 lines
BTTR Software
http://www.bttr-software.de/
#2 lore raw
Quoted 8 lines · Robert Riebisch
Quoted 5 lines · Consul

Is there a reason this patch has not been applied? I'm still getting sigsegv early in the boot of Windows images without it. s->bounce has been VirtualAlloc'ed and should be VirtualFree'ed.

signed-off-by Alex Ivanov <[email protected]>

Quoted 15 lines

block.c line 1269

Quoted 12 lines
block.c +1 -1
@@ -1263,7 +1263,7 @@
      if (!s->is_write) {
          qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
      }
-    qemu_free(s->bounce);
+    qemu_vfree(s->bounce);
      s->this_aiocb->cb(s->this_aiocb->opaque, ret);
      qemu_aio_release(s->this_aiocb);
  }

Could someone please apply this to SVN?! Thanks!

It's in my queue to be applied before the release so it'll be there soon.

Regards,

Anthony Liguori

Quoted 2 lines

Robert Riebisch

#3 lore raw
Quoted 4 lines · Anthony Liguori
Quoted 2 lines

Could someone please apply this to SVN?! Thanks!

It's in my queue to be applied before the release so it'll be there soon.

Thanks! :-)

Robert Riebisch

Signature · 2 lines
BTTR Software
http://www.bttr-software.de/