Skip to contentSkip to conversation

Fix compiler warning vcxk

PATCH New Jens Scharsig 3 participants 5 messages Jul 27, 2009 – Aug 10, 2009 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix compiler warning vcxk

My new video driver vcxk produce a compiler warning.

I'm sorry about this.

This patch will

* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'

---

drivers/video/bus_vcxk.c +0 -1
index b3b53e1..7726bb3 100644
@@ -380,7 +380,6 @@ int vcxk_display_bitmap(ulong addr, int x, int y)
 	unsigned long c_width;
 	unsigned long c_height;
 	unsigned char *dataptr;
-	unsigned char *lineptr;
 
 	bmp = (bmp_image_t *) addr;
 	if ((bmp->header.signature[0] == 'B') &&
#1 lore raw

PATCH 1/1 Fix compiler warning vcxk

Quoted 10 lines · Jens Scharsig

My new video driver vcxk produce a compiler warning.

I'm sorry about this.

This patch will

* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'

---

Applied to u-boot-video/master. Thanks.

Please note that comments to the patch should go below "---" line so that they do not appear in the commit message, e.g. in this case:

This patch will

* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'

Your SOB
---
Here is the place for comments which should not appear in the commit log, in this case this is:

"My new video driver vcxk produce a compiler warning.

I'm sorry about this."

Best regards,
Anatolij

#2 lore raw

PATCH 1/1 Fix compiler warning vcxk

Quoted 7 lines · Anatolij Gustschin

Please note that comments to the patch should go below "---" line so that they do not appear in the commit message, e.g. in this case:

This patch will

Quoted 9 lines

* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'

Your SOB
---
Here is the place for comments which should not appear in the commit log, in this case this is:

"My new video driver vcxk produce a compiler warning.

I think the http://www.denx.de/wiki/U-Boot/Patches is a good place to describe such basic things. Especially for people who publish their first patch.

Best regard

Jens

#3 lore raw

PATCH 1/1 Fix compiler warning vcxk

In reply to Jens Scharsig

Dear Jens Scharsig,

Quoted 10 lines · In message <[email protected]> you wrote:

My new video driver vcxk produce a compiler warning.

I'm sorry about this.

This patch will

* FIX: bus_vcxk.c:383: warning: unused variable 'lineptr'

---

Applied (after editing the commit message; hope this is OK).

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I think there's a world market for about five computers.
         -- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943
#4 lore raw

PATCH 1/1 Fix compiler warning vcxk

Dear Wolfgang Denk,

Quoted 1 line

Applied (after editing the commit message; hope this is OK).

No problem, the change commit message describes the right thing.

best regards

Jens Scharsig