Skip to contentSkip to conversation

distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.

PATCH In review Khem Raj 4 participants 5 messages Oct 13, 2010

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.

* This was done generically in bitbake.conf this should be done on demand and distutils based recipes seem to need it. So we define it here.

---
 classes/distutils-common-base.bbclass |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
classes/distutils-common-base.bbclass +2 -0
index f66a5cd..b6caf24 100644
@@ -4,6 +4,8 @@ EXTRA_OEMAKE = ""
 
 export STAGING_INCDIR
 export STAGING_LIBDIR
+# libtool 2.4 does not export with LDFLAGS but distutils need it
+LDFLAGS_prepend = "-L${STAGING_LIBDIR} "
 
 PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
 
Signature · 1 line
1.7.1
#1 lore raw

2010/10/13 Khem Raj <[email protected]>:

Quoted 3 lines

* This was done generically in bitbake.conf this should be done on demand and distutils based recipes seem to need it. So we define it here.

Based on your commit message I expected a change in bitbake.conf too. Am I mssing something here?

Frans

Quoted 28 lines

---
 classes/distutils-common-base.bbclass |    2 ++

 1 files changed, 2 insertions(+), 0 deletions(-)
classes/distutils-common-base.bbclass +0 -0
index f66a5cd..b6caf24 100644
@@ -4,6 +4,8 @@ EXTRA_OEMAKE = ""
 

 export STAGING_INCDIR
 export STAGING_LIBDIR

classes/distutils-common-base.bbclass +2 -0
+# libtool 2.4 does not export with LDFLAGS but distutils need it
+LDFLAGS_prepend = "-L${STAGING_LIBDIR} "

 PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"

--
1.7.1

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Acked-by
#2 lore raw
Quoted 7 lines · Frans Meulenbroeks

2010/10/13 Khem Raj <[email protected]>:

Quoted 3 lines

* This was done generically in bitbake.conf this should be done on demand and distutils based recipes seem to need it. So we define it here.

Based on your commit message I expected a change in bitbake.conf too. Am I mssing something here?

That changes was already commited and it's used only for LIBTOOL_HAS_SYSROOT.

This is fixing build of all python recipes using distutils.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
Acked-by
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Martin Jansa
Quoted 5 lines · Frans Meulenbroeks

2010/10/13 Khem Raj <[email protected]>:

Quoted 3 lines

* This was done generically in bitbake.conf this should be done on demand and distutils based recipes seem to need it. So we define it here.

Quoted 7 lines
Quoted 2 lines

Based on your commit message I expected a change in bitbake.conf too. Am I mssing something here?

That changes was already commited and it's used only for LIBTOOL_HAS_SYSROOT.

This is fixing build of all python recipes using distutils.

Like python-pycairo :)

Quoted 1 line

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMtV7VMkyGM64RGpERAskFAJsGk14QZJ3gKvF31B/RGuj+m+mfmwCgkwXv XIgRylC4P5QyccgD+SdY/Do=
=vkru
-----END PGP SIGNATURE-----

#4 lore raw
In reply to Martin Jansa

2010/10/13 Martin Jansa <[email protected]>:

Quoted 9 lines · Frans Meulenbroeks
Quoted 7 lines

2010/10/13 Khem Raj <[email protected]>:

Quoted 3 lines

* This was done generically in bitbake.conf this should be done on demand and distutils based recipes seem to need it. So we define it here.

Based on your commit message I expected a change in bitbake.conf too. Am I mssing something here?

Quoted 6 lines

That changes was already commited and it's used only for LIBTOOL_HAS_SYSROOT.

This is fixing build of all python recipes using distutils.

Ah ok, thanks for the info.
guess the commit message could have been a teeny weeny bit clearer. it now to me suggested a code/functionality move from bitbake.conf to dustutils-common-base.bbclass.

Frans.