Skip to contentSkip to conversation

Fix rsyslog removal issue

PATCH Applied Anders Darander 2 participants 5 messages Nov 9, 2011

lore
Share & tools
lore
#0 lore raw

cover Fix rsyslog removal issue

Rsyslog wasn't possible to remove from a running system, as the postrm-stage failed. The unit file was already removed when running systemctl. Disable the service prior to removing the files.

The following changes since commit db658e9954586f209c9ad3737c7f7488065ece38:

gateone: make it work (2011-11-09 12:51:30 +0100)

are available in the git repository at:
git://github.com/darander/meta-oe rsyslog
https://github.com/darander/meta-oe/tree/rsyslog

Anders Darander (1):
rsyslog: change postrm to prerm

 meta-oe/recipes-extended/rsyslog/rsyslog.inc |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.7.2
#1 lore raw

PATCH 1/1 rsyslog: change postrm to prerm

The systemd service can't be disabled if it already has been removed, thus disable it prior to removing the package.

---
 meta-oe/recipes-extended/rsyslog/rsyslog.inc |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-extended/rsyslog/rsyslog.inc +2 -2
index 8af2049..856d965 100644
@@ -4,7 +4,7 @@ HOMEPAGE = "http://www.rsyslog.com/"
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=51d9635e646fb75e1b74c074f788e973"
 
-INC_PR = "r0"
+INC_PR = "r1"
 
 SRC_URI = "http://www.rsyslog.com/files/download/rsyslog/${PN}-${PV}.tar.gz \
            file://rsyslog.conf"
@@ -25,7 +25,7 @@ pkg_postinst_${PN} () {
 	systemctl enable rsyslog.service
 }
 
-pkg_postrm_${PN} () {
+pkg_prerm_${PN} () {
 	systemctl disable rsyslog.service
 }
 
Signature · 1 line
1.7.7.2
Applied
#2 lore raw

Re: [PATCH 1/1] rsyslog: change postrm to prerm

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 09-11-11 13:32, Anders Darander schreef:

Quoted 4 lines

The systemd service can't be disabled if it already has been removed, thus disable it prior to removing the package.

Applied. Next time could you please follow
https://github.com/openembedded/meta-oe/blob/master/meta-oe/README and use [meta-oe] in the subject?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFOun1cMkyGM64RGpERAtC7AKCc5sVPSafYXUIn763VVmCwIPuw0gCfcAGw lTnZak0VIzJnfOG1wjF2vC4=
=x7f9
-----END PGP SIGNATURE-----

#3 lore raw

Re: [PATCH 1/1] rsyslog: change postrm to prerm

Quoted 9 lines · Koen Kooi

Op 09-11-11 13:32, Anders Darander schreef:

Quoted 4 lines

The systemd service can't be disabled if it already has been removed, thus disable it prior to removing the package.

Applied. Next time could you please follow
https://github.com/openembedded/meta-oe/blob/master/meta-oe/README and use [meta-oe] in the subject?

Yes, sure. Sorry that I forgot that....

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB
#4 lore raw

Re: [PATCH 1/1] rsyslog: change postrm to prerm

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 09-11-11 14:32, Anders Darander schreef:

Quoted 5 lines · Koen Kooi
Quoted 3 lines

Op 09-11-11 13:32, Anders Darander schreef:

Quoted 2 lines

The systemd service can't be disabled if it already has been removed, thus disable it prior to removing the package.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Applied. Next time could you please follow
https://github.com/openembedded/meta-oe/blob/master/meta-oe/README and use [meta-oe] in the subject?

Yes, sure. Sorry that I forgot that....

I look at http://patchwork.openembedded.org/project/oe/list/?q=meta- far more often than oe-devel :)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFOuoHFMkyGM64RGpERAmq/AJ0QQyXQm9w8pAuW9djpTVi2QcubUwCfXZXy UxerDjXtNhgihdFgTfmaKfg=
=Blqn
-----END PGP SIGNATURE-----