Skip to contentSkip to conversation

x86/apic: remove verify_local_APIC()

PATCH New Bandan Das 2 participants 2 messages Mar 31, 2015 – Apr 2, 2015 x86

lore
Share & tools
lore

Bandan Das

author
#0 lore raw

PATCH 1/1 x86/apic: remove verify_local_APIC()

__verify_local_APIC() is detritus from the early APIC days. Its return value isn't used anywhere and the information it prints when debug is enabled is already part of APIC initialization messages printed to syslog. Off with it!

Signed-off-by Bandan Das <[email protected]>
---
 arch/x86/include/asm/apic.h |  1 -
 arch/x86/kernel/apic/apic.c | 62 ---------------------------------------------
 arch/x86/kernel/smpboot.c   |  2 --
 3 files changed, 65 deletions(-)
arch/x86/include/asm/apic.h +0 -1
index efc3b22..08f2173 100644
@@ -204,7 +204,6 @@ extern void clear_local_APIC(void);
 extern void disconnect_bsp_APIC(int virt_wire_setup);
 extern void disable_local_APIC(void);
 extern void lapic_shutdown(void);
-extern int verify_local_APIC(void);
 extern void sync_Arb_IDs(void);
 extern void init_bsp_APIC(void);
 extern void setup_local_APIC(void);
arch/x86/kernel/apic/apic.c +0 -62

74 lines not on this page · raw message

arch/x86/kernel/smpboot.c +0 -2
index febc6aa..ddd2c06 100644
@@ -1086,8 +1086,6 @@ static int __init smp_sanity_check(unsigned max_cpus)
 		return SMP_NO_APIC;
 	}
 
-	verify_local_APIC();
-
 	/*
 	 * If SMP should be disabled, then really disable it!
 	 */
Signature · 1 line
2.1.0
merge bot
#1 lore raw

[tip:x86/apic] x86/apic: Remove verify_local_APIC()

x86/apic: Remove verify_local_APIC()
Commit-ID:  4399c03c6780ed75fa26e09a7b3a175b3aac5760
Gitweb:     http://git.kernel.org/tip/4399c03c6780ed75fa26e09a7b3a175b3aac5760
Author:     Bandan Das <[email protected]>
AuthorDate: Tue, 31 Mar 2015 16:43:17 -0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 1 Apr 2015 10:47:57 +0200

x86/apic: Remove verify_local_APIC()

__verify_local_APIC() is detritus from the early APIC days. Its return value isn't used anywhere and the information it prints when debug is enabled is already part of APIC initialization messages printed to syslog. Off with it!

Signed-off-by Bandan Das <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc H. Peter Anvin <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Thomas Gleixner <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Ingo Molnar <[email protected]>
---
 arch/x86/include/asm/apic.h |  1 -
 arch/x86/kernel/apic/apic.c | 62 ---------------------------------------------
 arch/x86/kernel/smpboot.c   |  2 --
 3 files changed, 65 deletions(-)
arch/x86/include/asm/apic.h +0 -1
index efc3b22..08f2173 100644
@@ -204,7 +204,6 @@ extern void clear_local_APIC(void);
 extern void disconnect_bsp_APIC(int virt_wire_setup);
 extern void disable_local_APIC(void);
 extern void lapic_shutdown(void);
-extern int verify_local_APIC(void);
 extern void sync_Arb_IDs(void);
 extern void init_bsp_APIC(void);
 extern void setup_local_APIC(void);
arch/x86/kernel/apic/apic.c +0 -62

74 lines not on this page · raw message

arch/x86/kernel/smpboot.c +0 -2
index febc6aa..ddd2c06 100644
@@ -1086,8 +1086,6 @@ static int __init smp_sanity_check(unsigned max_cpus)
 		return SMP_NO_APIC;
 	}
 
-	verify_local_APIC();
-
 	/*
 	 * If SMP should be disabled, then really disable it!
 	 */