Warn when using verb levels >=7 without debug
PATCH 1/1 Warn when using verb levels >=7 without debug
This patch adds a log warning when using --verb levels at 7 or higher when running on builds lacking debug support. Since official builds are now built with enable_debug=no, this warning will help developers identify why expected debug messages may not be present in log output.
The test and message output code is omitted when built with enable_debug=yes or enable_small=yes.
--- src/openvpn/options.c | 6 ++++++ 1 file changed, 6 insertions(+)
src/openvpn/options.c +6 -0
@@ -4672,6 +4672,12 @@ add_option (struct options *options, {VERIFY_PERMISSION (OPT_P_MESSAGES ); options->verbosity =positive_atoi (p[1 ]); +#if !defined(ENABLE_DEBUG ) && !defined(ENABLE_SMALL ) +/* Warn when a debug verbosity is supplied when built without debug support */ +if (options->verbosity >=7 ) +msg (M_WARN ,"NOTE: a debug verb level (--verb %d) is enabled, but this build lacks debug support." , + options->verbosity); +#endif } else if (streq (p[0], "mute") && p[1]) {
Signature · 1 line
1.7.12.4
Am 20.03.13 17:32, schrieb Josh Cepek:
Quoted 20 lines
This patch adds a log warning when using --verb levels at 7 or higher when running on builds lacking debug support. Since official builds are now built with enable_debug=no, this warning will help developers identify why expected debug messages may not be present in log output.
The test and message output code is omitted when built with enable_debug=yes or enable_small=yes.
Signed-off-by Josh Cepek <[email protected]...>--- src/openvpn/options.c | 6 ++++++ 1 file changed, 6 insertions(+)src/openvpn/options.c +0
-0@@ -4672,6 +4672,12 @@ add_option (struct options *options, {VERIFY_PERMISSION (OPT_P_MESSAGES );
src/openvpn/options.c add_option (struct options *options, · line 4683
Quoted 10 lines
src/openvpn/options.c +6
-0options->verbosity =positive_atoi (p[1 ]); +#if !defined(ENABLE_DEBUG ) && !defined(ENABLE_SMALL ) +/* Warn when a debug verbosity is supplied when built without debug support */ +if (options->verbosity >=7 ) +msg (M_WARN ,"NOTE: a debug verb level (--verb %d) is enabled, but this build lacks debug support." , + options->verbosity); +#endif }else if (streq (p[0 ],"mute" ) && p[1 ]) {
ACK. But I would change "debug verb" to "debug verbosity" and I think there should be no comma before "but"
Re: [Openvpn-devel] (updated) [PATCH] Warn when using verb levels >=7 without debug
Quoted 2 lines · Arne Schwabe
ACK. But I would change "debug verb" to "debug verbosity" and I think there should be no comma before "but"
This text change makes sense: I've adjusted it to read "NOTE: debug verbosity..." and saved another byte removing the comma.
Updated patch attached.
--
Josh
From d41a0237220f2fea6647a508a2ab07263e0f160b Mon Sep 17 00:00:00 2001
From: Josh Cepek <[email protected]...>
Date: Tue, 19 Mar 2013 22:52:12 -0500
Subject: [PATCH] Warn when using verb levels >=7 without debug
This patch adds a log warning when using --verb levels at 7 or higher when running on builds lacking debug support. Since official builds are now built with enable_debug=no, this warning will help developers identify why expected debug messages may not be present in log output.
The test and message output code is omitted when built with enable_debug=yes or enable_small=yes.
--- src/openvpn/options.c | 6 ++++++ 1 file changed, 6 insertions(+)
src/openvpn/options.c +6 -0
@@ -4672,6 +4672,12 @@ add_option (struct options *options, {VERIFY_PERMISSION (OPT_P_MESSAGES ); options->verbosity =positive_atoi (p[1 ]); +#if !defined(ENABLE_DEBUG ) && !defined(ENABLE_SMALL ) +/* Warn when a debug verbosity is supplied when built without debug support */ +if (options->verbosity >=7 ) +msg (M_WARN ,"NOTE: debug verbosity (--verb %d) is enabled but this build lacks debug support." , + options->verbosity); +#endif } else if (streq (p[0], "mute") && p[1]) {
Signature · 1 line
1.7.12.4
Re: [Openvpn-devel] (updated) [PATCH] Warn when using verb levels >=7 without debug
Am 20.03.13 19:22, schrieb Josh Cepek:
Quoted 10 lines · Arne Schwabe
Quoted 3 lines
ACK. But I would change "debug verb" to "debug verbosity" and I think there should be no comma before "but"
This text change makes sense: I've adjusted it to read "NOTE: debug verbosity..." and saved another byte removing the comma.
Updated patch attached.
ACK to that patch.
Arne
[Openvpn-devel] [PATCH applied] Re: (updated) [PATCH] Warn when using verb levels >=7 without debug
In reply to Josh CepekYour patch has been applied to the master and release/2.3 branch.
commit 58fbb8046b203ca23708c1765ee84330d8809266 (master) commit 152ca3e49f14b8fe8e7e52daf3cf11851fb98acd (release/2.3)
Author: Josh Cepek Date: Wed Mar 20 13:22:25 2013 -0500
(updated) [PATCH] Warn when using verb levels >=7 without debug
Signed-off-by: Josh Cepek <[email protected]...>
Acked-by: Arne Schwabe <[email protected]...>
Message-Id: <[email protected]...>
URL: http://article.gmane.org/gmane.network.openvpn.devel/7425
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering