Skip to contentSkip to conversation

net: phy: mediatek-ge: do not disable EEE advertisement

PATCH Superseded Arınç ÜNAL 1 participant 1 message Mar 18, 2024

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 net: phy: mediatek-ge: do not disable EEE advertisement

From: Arınç ÜNAL <[email protected]>

There's no need to disable Energy-Efficient Ethernet (EEE) advertisement on the MT7530 and MT7531 switch PHYs. EEE works fine on MT7530 and MT7531 switch PHYs. Remove the code where EEE advertisement is disabled.

This is a bugfix because there's a possible race condition where the mediatek-ge driver would kick in after the MT7530 DSA subdriver which would have EEE disabled until manually enabled.

Fixes e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
---
 drivers/net/phy/mediatek-ge.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/phy/mediatek-ge.c +0 -3
index a493ae01b267..54ea64a37ab3 100644
@@ -23,9 +23,6 @@ static int mtk_gephy_write_page(struct phy_device *phydev, int page)
 
 static void mtk_gephy_config_init(struct phy_device *phydev)
 {
-	/* Disable EEE */
-	phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0);
-
 	/* Enable HW auto downshift */
 	phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4));
 
Signature · 1 line
2.40.1