Remove user "default"

PATCH New Stephan Hoffmann 4 participants 5 messages Jun 5, 2014 – Jun 6, 2014

Share & tools

Stephan Hoffmann

author

2014-06-05 08:30 UTC #0 lore raw

PATCH 1/1 Remove user "default"

User "default" with no password has been around for long time, but not used within buildroot. Since we now have BR2_ROOTFS_USERS_TABLES it is no longer needed.

Signed-off-by Stephan Hoffmann <[email protected]>

---
 system/device_table.txt    | 1 -
 system/skeleton/etc/group  | 1 -
 system/skeleton/etc/passwd | 1 -
 system/skeleton/etc/shadow | 1 -
 4 files changed, 4 deletions(-)

system/device_table.txt +0 -1

index 7ae4b07..e15412d 100644
@@ -10,7 +10,6 @@
 /tmp					d	1777	0	0	-	-	-	-	-
 /etc					d	755	0	0	-	-	-	-	-
 /root					d	700	0	0	-	-	-	-	-
-/home/default				d	755	1000	1000	-	-	-	-	-
 /var/www				d	755	33	33	-	-	-	-	-
 /etc/shadow				f	600	0	0	-	-	-	-	-
 /etc/passwd				f	644	0	0	-	-	-	-	-

system/skeleton/etc/group +0 -1

index 85a1fa2..11d58ac 100644
@@ -27,4 +27,3 @@ ftp:x:83
 nobody:x:99:
 nogroup:x:99:
 users:x:100:
-default:x:1000:

system/skeleton/etc/passwd +0 -1

index ed7006a..8696954 100644
@@ -13,4 +13,3 @@ dbus:x:81:81:dbus:/var/run/dbus:/bin/sh
 ftp:x:83:83:ftp:/home/ftp:/bin/sh
 nobody:x:99:99:nobody:/home:/bin/sh
 sshd:x:103:99:Operator:/var:/bin/sh
-default:x:1000:1000:Default non-root user:/home/default:/bin/sh

system/skeleton/etc/shadow +0 -1

index 67b67c1..d5734d7 100644
@@ -10,4 +10,3 @@ uucp:*:10933:0:99999:7:::
 operator:*:10933:0:99999:7:::
 ftp:*:10933:0:99999:7:::
 nobody:*:10933:0:99999:7:::
-default::10933:0:99999:7:::

Signature · 1 line

2.0.0.rc2

Yann E. MORIN

2014-06-05 17:20 UTC #1 lore raw

PATCH 1/1 Remove user "default"

Stephan, All,

On 2014-06-05 10:30 +0200, Stephan Hoffmann spake thusly:

Quoted 5 lines

User "default" with no password has been around for long time, but not used within buildroot. Since we now have BR2_ROOTFS_USERS_TABLES it is no longer needed.
Signed-off-by Stephan Hoffmann <[email protected]>

Acked-by "Yann E. MORIN" <[email protected]>

Note a comment below...

Regards,
Yann E. MORIN.

Quoted 33 lines

---
 system/device_table.txt    | 1 -
 system/skeleton/etc/group  | 1 -
 system/skeleton/etc/passwd | 1 -
 system/skeleton/etc/shadow | 1 -
 4 files changed, 4 deletions(-)

system/device_table.txt +0 -1

index 7ae4b07..e15412d 100644
@@ -10,7 +10,6 @@
 /tmp					d	1777	0	0	-	-	-	-	-
 /etc					d	755	0	0	-	-	-	-	-
 /root					d	700	0	0	-	-	-	-	-
-/home/default				d	755	1000	1000	-	-	-	-	-
 /var/www				d	755	33	33	-	-	-	-	-
 /etc/shadow				f	600	0	0	-	-	-	-	-
 /etc/passwd				f	644	0	0	-	-	-	-	-

system/skeleton/etc/group +0 -1

index 85a1fa2..11d58ac 100644
@@ -27,4 +27,3 @@ ftp:x:83
 nobody:x:99:
 nogroup:x:99:
 users:x:100:
-default:x:1000:

system/skeleton/etc/passwd +0 -0

index ed7006a..8696954 100644

system/skeleton/etc/passwd dbus:x:81:81:dbus:/var/run/dbus:/bin/sh · line 15

Quoted 3 lines

system/skeleton/etc/passwd +0 -0

@@ -13,4 +13,3 @@ dbus:x:81:81:dbus:/var/run/dbus:/bin/sh
 ftp:x:83:83:ftp:/home/ftp:/bin/sh
 nobody:x:99:99:nobody:/home:/bin/sh
 sshd:x:103:99:Operator:/var:/bin/sh

Should we make these system accounts no-login accounts, and set the set their shells to /bin/false to prevent any latent issue?

For example, my distro's passwd has:

    sshd:x:115:65534::/var/run/sshd:/usr/sbin/nologin
    nobody:x:65534:65534:nobody:/nonexistent:/bin/sh

and shadow has:

    sshd:*:15767:0:99999:7:::
    nobody:*:15630:0:99999:7:::

So, setting at least the shell to /bin/false would be better.

Also, why do we have an sshd user to begin with? We already had this discussion about the 'mail' user, but 'mail' is in the low-digits, and very traditional to UNIX. 'sshd' on the other hand is above 100, and is not really needed: the ssh server should run as root to allow logins anyway.

And since packages can now create users... ;-)

Should we prepare to claen up etc/passwd (and associated files)?

Regards,
Yann E. MORIN.

Quoted 17 lines

system/skeleton/etc/passwd +0 -1

-default:x:1000:1000:Default non-root user:/home/default:/bin/sh

system/skeleton/etc/shadow +0 -1

index 67b67c1..d5734d7 100644
@@ -10,4 +10,3 @@ uucp:*:10933:0:99999:7:::
 operator:*:10933:0:99999:7:::
 ftp:*:10933:0:99999:7:::
 nobody:*:10933:0:99999:7:::
-default::10933:0:99999:7:::

Signature · 6 lines

2.0.0.rc2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Nicholas Kulikov

2014-06-05 19:21 UTC #2 lore raw

PATCH 1/1 Remove user "default"

In reply to Stephan Hoffmann

I don't know why but avahi-autopipd uses this by default.

ps output from system built by using Buildroot:

# ps -o pid,ppid,user,comm,args
PID   PPID  USER     COMMAND
    1     0 root     init
...
  807     1 default  avahi-autoipd    avahi-autoipd: [eth1] bound 169.254.8.72
  808   807 root     avahi-autoipd    avahi-autoipd: [eth1] callout dispatcher
...

Quoted 51 lines · Stephan Hoffmann

User "default" with no password has been around for long time, but not used within buildroot. Since we now have BR2_ROOTFS_USERS_TABLES it is no longer needed.

Signed-off-by Stephan Hoffmann <[email protected]>

---
 system/device_table.txt    | 1 -
 system/skeleton/etc/group  | 1 -
 system/skeleton/etc/passwd | 1 -
 system/skeleton/etc/shadow | 1 -
 4 files changed, 4 deletions(-)

system/device_table.txt +0 -1

index 7ae4b07..e15412d 100644
@@ -10,7 +10,6 @@
 /tmp					d	1777	0	0	-	-	-	-	-
 /etc					d	755	0	0	-	-	-	-	-
 /root					d	700	0	0	-	-	-	-	-
-/home/default				d	755	1000	1000	-	-	-	-	-
 /var/www				d	755	33	33	-	-	-	-	-
 /etc/shadow				f	600	0	0	-	-	-	-	-
 /etc/passwd				f	644	0	0	-	-	-	-	-

system/skeleton/etc/group +0 -1

index 85a1fa2..11d58ac 100644
@@ -27,4 +27,3 @@ ftp:x:83
 nobody:x:99:
 nogroup:x:99:
 users:x:100:
-default:x:1000:

system/skeleton/etc/passwd +0 -1

index ed7006a..8696954 100644
@@ -13,4 +13,3 @@ dbus:x:81:81:dbus:/var/run/dbus:/bin/sh
 ftp:x:83:83:ftp:/home/ftp:/bin/sh
 nobody:x:99:99:nobody:/home:/bin/sh
 sshd:x:103:99:Operator:/var:/bin/sh
-default:x:1000:1000:Default non-root user:/home/default:/bin/sh

system/skeleton/etc/shadow +0 -1

index 67b67c1..d5734d7 100644
@@ -10,4 +10,3 @@ uucp:*:10933:0:99999:7:::
 operator:*:10933:0:99999:7:::
 ftp:*:10933:0:99999:7:::
 nobody:*:10933:0:99999:7:::
-default::10933:0:99999:7:::

Peter Korsgaard

2014-06-05 20:23 UTC #3 lore raw

PATCH 1/1 Remove user "default"

Quoted 11 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Nicholas" == Nicholas Kulikov <[email protected]> writes:
I don't know why but avahi-autopipd uses this by default. ps output from system built by using Buildroot:
# ps -o pid,ppid,user,comm,args
PID   PPID  USER     COMMAND
   1     0 root     init
...
 807     1 default  avahi-autoipd    avahi-autoipd: [eth1] bound 169.254.8.72
 808   807 root     avahi-autoipd    avahi-autoipd: [eth1] callout dispatcher
...

Ahh, that's because of:

git grep default package/avahi/avahi.mk

package/avahi/avahi.mk:         --with-avahi-user=default \
package/avahi/avahi.mk:         --with-avahi-group=default \
package/avahi/avahi.mk:         --with-autoipd-user=default \
package/avahi/avahi.mk:         --with-autoipd-group=default

We should adjust avahi.mk to create an avahi user. I'll take a look.

Signature · 1 line

Bye, Peter Korsgaard

Peter Korsgaard

2014-06-06 22:13 UTC #4 lore raw

PATCH 1/1 Remove user "default"

In reply to Stephan Hoffmann

Quoted 7 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Stephan" == Stephan Hoffmann <[email protected]> writes:
User "default" with no password has been around for long time, but not used within buildroot. Since we now have BR2_ROOTFS_USERS_TABLES it is no longer needed.
Signed-off-by Stephan Hoffmann <[email protected]>

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard