Skip to contentSkip to conversation

adsvix: Fix undefined reference to inb and outb build errors

PATCH New Marcel Ziswiler 2 participants 3 messages May 2, 2008 – May 4, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 adsvix: Fix undefined reference to inb and outb build errors

- undefined reference to `inb'
- undefined reference to `outb'

---
 include/configs/adsvix.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/adsvix.h +1 -0
index 703d312..58914cb 100644
@@ -310,6 +310,7 @@
 
 #define CONFIG_PXA_PCMCIA 1
 #define CONFIG_PXA_IDE 1
+#define __io
 
 #define CONFIG_PCMCIA_SLOT_A 1
 /* just to keep build system happy  */
Signature · 1 line
1.5.4.1
#1 lore raw

PATCH 1/1 adsvix: Fix undefined reference to inb and outb build errors

Quoted 13 lines · Marcel Ziswiler

- undefined reference to `inb'
- undefined reference to `outb'

---
 include/configs/adsvix.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/adsvix.h +0 -0
index 703d312..58914cb 100644

include/configs/adsvix.h line 313

Quoted 4 lines
include/configs/adsvix.h +1 -0
@@ -310,6 +310,7 @@
 
 #define CONFIG_PXA_PCMCIA 1
 #define CONFIG_PXA_IDE 1
+#define __io

This is not the good way to do it

__io is suppose to declare as this
#define __io(a) ((volatile void *)(a))

NACK

This will be fix by ad the asm-arm/arch-*/io.h

and cleany the asm/io.h

Best Regards,
J.

#2 lore raw

PATCH 1/1 adsvix: Fix undefined reference to inb and outb build errors

Quoted 1 line · Jean-Christophe PLAGNIOL-VILLARD <plagnioj <at> jcrosoft.com> writes:

This is not the good way to do it

I just noticed it to be done like that for the two SH boards r2dplus and r7780mp and figured it to be good enough for use on ARM as well.

Quoted 2 lines

__io is suppose to declare as this
#define __io(a) ((volatile void *)(a))

I am very well aware of that's the way the kernel guys use it.

Quoted 3 lines

This will be fix by ad the asm-arm/arch-*/io.h

and cleany the asm/io.h

OK, go ahead. It would be nice if that made it into 1.3.3 as the adsvix board currently does not build at all.

Cheers

Marcel Ziswiler