Skip to contentSkip to conversation

support for medion dvb stick 1660:1921

PATCH In review Stéphane Elmaleh 2 participants 2 messages May 30, 2010 – Jun 1, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support for medion dvb stick 1660:1921

Hello,
I'm not sure of doing this the right way since I'm not a programmer.

diff -r b576509ea6d2 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Wed May 19 19:34:33
2010 -0300
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Mon May 31 00:34:44
2010 +0200
@@ -2083,6 +2083,7 @@
{ USB_DEVICE(USB_VID_PCTV, USB_PID_PINNACLE_PCTV282E) },
{ USB_DEVICE(USB_VID_DIBCOM, USB_PID_DIBCOM_STK7770P) },
/* 60 */{ USB_DEVICE(USB_VID_TERRATEC, USB_PID_TERRATEC_CINERGY_T_XXS_2) },
+ { USB_DEVICE(USB_VID_MEDION, USB_PID_MEDION_STICK_CTX_1921) },
{ USB_DEVICE(USB_VID_DIBCOM, USB_PID_DIBCOM_STK807XPVR) },
{ USB_DEVICE(USB_VID_DIBCOM, USB_PID_DIBCOM_STK807XP) },
{ USB_DEVICE(USB_VID_PIXELVIEW, USB_PID_PIXELVIEW_SBTVD) },
@@ -2606,10 +2607,14 @@
},
},

- .num_device_descs = 2,
+ .num_device_descs = 3,
.devices = {
{ "DiBcom STK7770P reference design",
{ &dib0700_usb_id_table[59], NULL },
+ { NULL },
+ },
+ { "Medion Stick ctx 1921",
+ { &dib0700_usb_id_table[61], NULL },
{ NULL },
},
{ "Terratec Cinergy T USB XXS (HD)/ T3",
diff -r b576509ea6d2 linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Wed May 19 19:34:33
2010 -0300
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h Mon May 31 00:34:44
2010 +0200
@@ -303,4 +303,5 @@
#define USB_PID_TERRATEC_DVBS2CI_V2 0x10ac
#define USB_PID_TECHNISAT_USB2_HDCI_V1 0x0001
#define USB_PID_TECHNISAT_USB2_HDCI_V2 0x0002
+#define USB_PID_MEDION_STICK_CTX_1921 0x1921
#endif

#1 lore raw

Hi Stephane,

Quoted 2 lines · St?phane Elmaleh

Hello,
I'm not sure of doing this the right way since I'm not a programmer.

Thanks for submitting the patch.

Review line 2089

Quoted 13 lines

diff -r b576509ea6d2 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Wed May 19 19:34:33
2010 -0300
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Mon May 31 00:34:44
2010 +0200

(quoted diff) +1 -0
@@ -2083,6 +2083,7 @@
 	{ USB_DEVICE(USB_VID_PCTV,	USB_PID_PINNACLE_PCTV282E) },
 	{ USB_DEVICE(USB_VID_DIBCOM,	USB_PID_DIBCOM_STK7770P) },
 /* 60 */{ USB_DEVICE(USB_VID_TERRATEC,	USB_PID_TERRATEC_CINERGY_T_XXS_2) },
+	{ USB_DEVICE(USB_VID_MEDION,	USB_PID_MEDION_STICK_CTX_1921) },
 	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_STK807XPVR) },
 	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_STK807XP) },
 	{ USB_DEVICE(USB_VID_PIXELVIEW, USB_PID_PIXELVIEW_SBTVD) }

Could you please move your inserted line to the end of this PID/VID-table? How it is done now will change the indices used for all other PID/VID-entries which will break all the references to it.

Review line 2617

Quoted 13 lines
(quoted diff) +5 -1
@@ -2606,10 +2607,14 @@
 			},
 		},
 
-		.num_device_descs = 2,
+		.num_device_descs = 3,
 		.devices = {
 			{   "DiBcom STK7770P reference design",
 				{ &dib0700_usb_id_table[59], NULL },
+				{ NULL },
+			},
+			{   "Medion Stick ctx 1921",
+				{ &dib0700_usb_id_table[61], NULL },

If moved to the end of the table you have to adapt the 61 here to the real value.

Please resent the patch afterwards.

thanks,
Patrick.

--

Patrick Boettcher - Kernel Labs
http://www.kernellabs.com/