Skip to contentSkip to conversation

kvm/powerpc: fix a build error in e500_tlb.c

PATCH In review Kevin Hao 4 participants 4 messages Jun 3, 2010 – Aug 25, 2015

Subsystems (3)
lore
Share & tools
lore

Kevin Hao

author
#0 lore raw

PATCH 1/1 kvm/powerpc: fix a build error in e500_tlb.c

We use the wrong number arguments when invoking trace_kvm_stlb_inval,
and cause the following build error.
arch/powerpc/kvm/e500_tlb.c: In function 'kvmppc_e500_stlbe_invalidate':
arch/powerpc/kvm/e500_tlb.c:230: error: too many arguments to function 'trace_kvm_stlb_inval'

---
 arch/powerpc/kvm/e500_tlb.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
arch/powerpc/kvm/e500_tlb.c +1 -2
index 21011e1..1261a21 100644
@@ -226,8 +226,7 @@ static void kvmppc_e500_stlbe_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500,
 
 	kvmppc_e500_shadow_release(vcpu_e500, tlbsel, esel);
 	stlbe->mas1 = 0;
-	trace_kvm_stlb_inval(index_of(tlbsel, esel), stlbe->mas1, stlbe->mas2,
-			     stlbe->mas3, stlbe->mas7);
+	trace_kvm_stlb_inval(index_of(tlbsel, esel));
 }
 
 static void kvmppc_e500_tlb1_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500,
Signature · 1 line
1.6.3.1
#1 lore raw
Quoted 4 lines · Kevin Hao

We use the wrong number arguments when invoking trace_kvm_stlb_inval,
and cause the following build error.
arch/powerpc/kvm/e500_tlb.c: In function 'kvmppc_e500_stlbe_invalidate':
arch/powerpc/kvm/e500_tlb.c:230: error: too many arguments to function 'trace_kvm_stlb_inval'

Liu, I'd like to get an ack from you here.

Alex

#2 lore raw
Quoted 15 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Alexander Graf
Sent: Friday, June 04, 2010 10:08 PM
To: Kevin Hao
Cc: Marcelo Tosatti; Kumar Gala; Avi Kivity; [email protected] list; [email protected]; Liu Yu-B13201
Subject: Re: [PATCH] kvm/powerpc: fix a build error in e500_tlb.c

Quoted 1 line · Kevin Hao

We use the wrong number arguments when invoking

Quoted 9 lines

trace_kvm_stlb_inval,

Quoted 2 lines

and cause the following build error.
arch/powerpc/kvm/e500_tlb.c: In function

'kvmppc_e500_stlbe_invalidate':

Quoted 1 line

arch/powerpc/kvm/e500_tlb.c:230: error: too many arguments

to function 'trace_kvm_stlb_inval'

Liu, I'd like to get an ack from you here.

Seems commit e43f2f741a49483034bf968841275cfa553a4cb3 has solved this.

#3 lore raw
In reply to Kevin Hao
Quoted 5 lines · Kevin Hao <haokexin <at> gmail.com> writes:

We use the wrong number arguments when invoking trace_kvm_stlb_inval, and cause the following build error. arch/powerpc/kvm/e500_tlb.c: In function 'kvmppc_e500_stlbe_invalidate':
arch/powerpc/kvm/e500_tlb.c:230: error: too many arguments to

function 'trace_kvm_stlb_inval'

arch/powerpc/kvm/e500_tlb.c

Quoted 11 lines
Signed-off-by Kevin Hao <haokexin <at> gmail.com>
---
 arch/powerpc/kvm/e500_tlb.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
arch/powerpc/kvm/e500_tlb.c +0 -0
index 21011e1..1261a21 100644
 <at>  <at>  -226,8 +226,7  <at>  <at>  static void 

kvmppc_e500_stlbe_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500,

arch/powerpc/kvm/e500_tlb.c static void kvmppc_e500_stlbe_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500,

Quoted 4 lines
arch/powerpc/kvm/e500_tlb.c +0 -1
 	kvmppc_e500_shadow_release(vcpu_e500, tlbsel, esel);
 	stlbe->mas1 = 0;
-	trace_kvm_stlb_inval(index_of(tlbsel, esel), stlbe->mas1, 

stlbe->mas2,

arch/powerpc/kvm/e500_tlb.c static void kvmppc_e500_stlbe_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500,

Quoted 5 lines
arch/powerpc/kvm/e500_tlb.c +1 -1
-			     stlbe->mas3, stlbe->mas7);
+	trace_kvm_stlb_inval(index_of(tlbsel, esel));
 }
 
 static void kvmppc_e500_tlb1_invalidate(struct kvmppc_vcpu_e500 

*vcpu_e500,

it worked was able to build image after this change, I have one query how to check on PowerPC that KVM is enabled, or VT is enabled, any cli available to check this data. please share it.