2.5.X config: USB speedtouch driver
Minor nit: the subject driver depends on ATM, so a config-time check to see if ATM support is enabled is appropriate.
Signature · 4 lines
----------------------------------------------------------------------- Bob Tracy WTO + WIPO = DMCA? http://www.anti-dmca.org [email protected] -----------------------------------------------------------------------
Quoted 2 lines · Bob_Tracy
Minor nit: the subject driver depends on ATM, so a config-time check to see if ATM support is enabled is appropriate.
Agreed, patch? :)
greg k-h
Quoted 5 lines · Greg KH
Quoted 2 lines · Bob_Tracy
Minor nit: the subject driver depends on ATM, so a config-time check to see if ATM support is enabled is appropriate.
Agreed, patch? :)
Ok. You shamed me into it :-). If I understand how dep_tristate works, the attached one-liner should do the trick. Sorry for doing this as an attachment, but I've seen my mailer mangle stuff when I try to include it in-line :-(.
Signature · 4 lines
----------------------------------------------------------------------- Bob Tracy WTO + WIPO = DMCA? http://www.anti-dmca.org [email protected] -----------------------------------------------------------------------
drivers/usb/misc/Config.in renamed from drivers/usb/misc/Config.in.orig +1 -1
@@ -8,4 +8,4 @@ dep_tristate ' USB Diamond Rio500 support (EXPERIMENTAL)' CONFIG_USB_RIO500 $CONFIG_USB $CONFIG_EXPERIMENTAL dep_tristate ' Tieman Voyager USB Braille display support (EXPERIMENTAL)' CONFIG_USB_BRLVGER $CONFIG_USB $CONFIG_EXPERIMENTAL dep_tristate ' USB LCD driver support' CONFIG_USB_LCD $CONFIG_USB -dep_tristate ' Alcatel Speedtouch ADSL USB Modem' CONFIG_USB_SPEEDTOUCH $CONFIG_USB +dep_tristate ' Alcatel Speedtouch ADSL USB Modem' CONFIG_USB_SPEEDTOUCH $CONFIG_USB $CONFIG_ATM
Quoted 11 lines · Bob_Tracy
Quoted 5 lines · Greg KH
Quoted 2 lines · Bob_Tracy
Minor nit: the subject driver depends on ATM, so a config-time check to see if ATM support is enabled is appropriate.
Agreed, patch? :)
Ok. You shamed me into it :-). If I understand how
dep_tristateworks, the attached one-liner should do the trick. Sorry for doing this as an attachment, but I've seen my mailer mangle stuff when I try to include it in-line :-(.
Looks good, I've applied this to my tree.
thanks,
greg k-h