Skip to contentSkip to conversation

do_tty_hangup: Use group_send_sig_info not send_group_sig_info.

PATCH New Eric W. Biederman 1 participant 1 message Jan 29, 2006 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 do_tty_hangup: Use group_send_sig_info not send_group_sig_info.

We already have the tasklist_lock so there is no need for us to reacquire it with send_group_sig_info. reader/writer locks allow multiple readers and thus recursion so the old code was ok just wastful.

---

 drivers/char/tty_io.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

b4634b339062085cc463041341a662d2d41c78b8

drivers/char/tty_io.c +2 -2
index da9ed47..1d83cd5 100644
@@ -1075,8 +1075,8 @@ static void do_tty_hangup(void *data)
 				p->signal->tty = NULL;
 			if (!p->signal->leader)
 				continue;
-			send_group_sig_info(SIGHUP, SEND_SIG_PRIV, p);
-			send_group_sig_info(SIGCONT, SEND_SIG_PRIV, p);
+			group_send_sig_info(SIGHUP, SEND_SIG_PRIV, p);
+			group_send_sig_info(SIGCONT, SEND_SIG_PRIV, p);
 			if (tty->pgrp > 0)
 				p->signal->tty_old_pgrp = tty->pgrp;
 		} while_each_task_pid(tty->session, PIDTYPE_SID, p);
Signature · 1 line
1.1.5.g3480