Skip to contentSkip to conversation

sysctl: fix memset parameters in setup_sysctl_set()

PATCH In review Dan Carpenter 2 participants 2 messages Jan 30, 2012 – Jan 31, 2012

Subsystems (3)
Kernel janitors Proc filesystem Proc sysctl
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 2/2 sysctl: fix memset parameters in setup_sysctl_set()

The current code is a nop.

Signed-off-by Dan Carpenter <[email protected]>
fs/proc/proc_sysctl.c +1 -1
index 1b1f5b8..27e265b 100644
@@ -1547,7 +1547,7 @@ void setup_sysctl_set(struct ctl_table_set *set,
 	struct ctl_table_root *root,
 	int (*is_seen)(struct ctl_table_set *))
 {
-	memset(set, sizeof(*set), 0);
+	memset(set, 0, sizeof(*set));
 	set->is_seen = is_seen;
 	init_header(&set->dir.header, root, set, NULL, root_table);
 }