Skip to contentSkip to conversation

perf, x86: Add Sandy Bridge constraints for CYCLE_ACTIVITY.*

PATCH In review Andi Kleen 2 participants 3 messages Mar 8, 2013 – Apr 10, 2013

Subsystems (2)
lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf, x86: Add Sandy Bridge constraints for CYCLE_ACTIVITY.*

From: Andi Kleen <[email protected]>

Add CYCLE_ACTIVITY.CYCLES_NO_DISPATCH/CYCLES_L1D_PENDING These recently documented events have restrictions to counter 0-3 and counter 2 respectively. The scheduler needs to know that to schedule them correctly.

IvyBridge already has the necessary constraints.

---
 arch/x86/kernel/cpu/perf_event_intel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/perf_event_intel.c +2 -0
index 5b59c6c..0d2f9d8 100644
@@ -104,6 +104,8 @@ static struct event_constraint intel_snb_event_constraints[] __read_mostly =
 	INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
 	INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
 	INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
+	INTEL_UEVENT_CONSTRAINT(0x04a3, 0xf), /* CYCLE_ACTIVITY.CYCLES_NO_DISPATCH */
+	INTEL_UEVENT_CONSTRAINT(0x02a3, 0x4), /* CYCLE_ACTIVITY.CYCLES_L1D_PENDING */
 	EVENT_CONSTRAINT_END
 };
 
Signature · 1 line
1.7.7.6
author
#1 lore raw
Quoted 1 line · Andi Kleen

From: Andi Kleen <[email protected]>

Ping! Patch is missing review.

-Andi

Quoted 25 lines

Add CYCLE_ACTIVITY.CYCLES_NO_DISPATCH/CYCLES_L1D_PENDING These recently documented events have restrictions to counter 0-3 and counter 2 respectively. The scheduler needs to know that to schedule them correctly.

IvyBridge already has the necessary constraints.

---
 arch/x86/kernel/cpu/perf_event_intel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/perf_event_intel.c +2 -0
index 5b59c6c..0d2f9d8 100644
@@ -104,6 +104,8 @@ static struct event_constraint intel_snb_event_constraints[] __read_mostly =
 	INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
 	INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
 	INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
+	INTEL_UEVENT_CONSTRAINT(0x04a3, 0xf), /* CYCLE_ACTIVITY.CYCLES_NO_DISPATCH */
+	INTEL_UEVENT_CONSTRAINT(0x02a3, 0x4), /* CYCLE_ACTIVITY.CYCLES_L1D_PENDING */
 	EVENT_CONSTRAINT_END
 };
Signature · 1 line
[email protected] -- Speaking for myself only
#2 lore raw

[tip:perf/core] perf/x86: Add Sandy Bridge constraints for CYCLE_ACTIVITY.*

In reply to Andi Kleen
perf/x86: Add Sandy Bridge constraints for CYCLE_ACTIVITY.*
Commit-ID:  f8378f5259647710f0b4ecb814b0a1b0d9040de0
Gitweb:     http://git.kernel.org/tip/f8378f5259647710f0b4ecb814b0a1b0d9040de0
Author:     Andi Kleen <[email protected]>
AuthorDate: Fri, 8 Mar 2013 15:22:48 -0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 10 Apr 2013 15:00:07 +0200

perf/x86: Add Sandy Bridge constraints for CYCLE_ACTIVITY.*

Add CYCLE_ACTIVITY.CYCLES_NO_DISPATCH/CYCLES_L1D_PENDING constraints.

These recently documented events have restrictions to counter 0-3 and counter 2 respectively. The perf scheduler needs to know that to schedule them correctly.

IvyBridge already has the necessary constraints.

---
 arch/x86/kernel/cpu/perf_event_intel.c | 2 ++
 1 file changed, 2 insertions(+)
arch/x86/kernel/cpu/perf_event_intel.c +2 -0
index e84c4ba..2ad2374 100644
@@ -109,6 +109,8 @@ static struct event_constraint intel_snb_event_constraints[] __read_mostly =
 	INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
 	INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
 	INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
+	INTEL_UEVENT_CONSTRAINT(0x04a3, 0xf), /* CYCLE_ACTIVITY.CYCLES_NO_DISPATCH */
+	INTEL_UEVENT_CONSTRAINT(0x02a3, 0x4), /* CYCLE_ACTIVITY.CYCLES_L1D_PENDING */
 	EVENT_CONSTRAINT_END
 };