cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
PATCH 1/4 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
clean up with 2.6.38 checkpatch.pl
Signed-off-by Macpaul Lin <[email protected]>
--- common/cmd_bdinfo.c | 295 ++++++++++++++++++++++++++------------------------- 1 files changed, 148 insertions(+), 147 deletions(-)
common/cmd_bdinfo.c +148 -147
@@ -42,56 +42,57 @@ static void print_lnum(const char *, u64);#if defined(CONFIG_PPC )static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd;char buf[32 ];#ifdef DEBUG -print_num ("bd address" , (ulong )bd ); -#endif -print_num ("memstart" , bd->bi_memstart ); -print_lnum ("memsize" , bd->bi_memsize ); -print_num ("flashstart" , bd->bi_flashstart ); -print_num ("flashsize" , bd->bi_flashsize ); -print_num ("flashoffset" , bd->bi_flashoffset ); -print_num ("sramstart" , bd->bi_sramstart ); -print_num ("sramsize" , bd->bi_sramsize ); -#if defined(CONFIG_5xx) || defined(CONFIG_8xx) || \ - defined(CONFIG_8260 ) || defined(CONFIG_E500 ) -print_num ("immr_base" , bd->bi_immr_base ); -#endif -print_num ("bootflags" , bd->bi_bootflags ); -#if defined(CONFIG_405GP ) || defined(CONFIG_405CR ) || \ - defined(CONFIG_405EP ) || defined(CONFIG_XILINX_405 ) || \ - defined(CONFIG_440EP ) || defined(CONFIG_440GR ) || \ - defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) || \ - defined(CONFIG_440SP ) || defined(CONFIG_440SPE ) -print_str ("procfreq" ,strmhz (buf, bd->bi_procfreq)); -print_str ("plb_busfreq" ,strmhz (buf, bd->bi_plb_busfreq)); -#if defined(CONFIG_405GP ) || defined(CONFIG_405EP ) || defined(CONFIG_XILINX_405 ) || \ - defined(CONFIG_440EP ) || defined(CONFIG_440GR ) || defined(CONFIG_440SPE ) || \ - defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) -print_str ("pci_busfreq" ,strmhz (buf, bd->bi_pci_busfreq)); +print_num ("bd address" , (ulong )bd); +#endif +print_num ("memstart" , bd->bi_memstart); +print_lnum ("memsize" , bd->bi_memsize); +print_num ("flashstart" , bd->bi_flashstart); +print_num ("flashsize" , bd->bi_flashsize); +print_num ("flashoffset" , bd->bi_flashoffset); +print_num ("sramstart" , bd->bi_sramstart); +print_num ("sramsize" , bd->bi_sramsize); +#if defined(CONFIG_5xx) || defined(CONFIG_8xx) || \ + defined(CONFIG_8260 ) || defined(CONFIG_E500 ) +print_num ("immr_base" , bd->bi_immr_base); +#endif +print_num ("bootflags" , bd->bi_bootflags); +#if defined(CONFIG_405GP ) || defined(CONFIG_405CR ) || \ + defined(CONFIG_405EP ) || defined(CONFIG_XILINX_405 ) || \ + defined(CONFIG_440EP ) || defined(CONFIG_440GR ) || \ + defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) || \ + defined(CONFIG_440SP ) || defined(CONFIG_440SPE ) +print_str ("procfreq" ,strmhz (buf, bd->bi_procfreq)); +print_str ("plb_busfreq" ,strmhz (buf, bd->bi_plb_busfreq)); +#if defined(CONFIG_405GP ) || defined(CONFIG_405EP ) || \ + defined(CONFIG_XILINX_405 ) || defined(CONFIG_440EP ) || \ + defined(CONFIG_440GR ) || defined(CONFIG_440SPE ) || \ + defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) +print_str ("pci_busfreq" ,strmhz (buf, bd->bi_pci_busfreq));#endif #else /* ! CONFIG_405GP, CONFIG_405CR, CONFIG_405EP, CONFIG_XILINX_405, CONFIG_440EP CONFIG_440GR */ #if defined(CONFIG_CPM2 ) -print_str ("vco" ,strmhz (buf, bd->bi_vco)); -print_str ("sccfreq" ,strmhz (buf, bd->bi_sccfreq)); -print_str ("brgfreq" ,strmhz (buf, bd->bi_brgfreq)); +print_str ("vco" ,strmhz (buf, bd->bi_vco)); +print_str ("sccfreq" ,strmhz (buf, bd->bi_sccfreq)); +print_str ("brgfreq" ,strmhz (buf, bd->bi_brgfreq));#endif -print_str ("intfreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("intfreq" ,strmhz (buf, bd->bi_intfreq));#if defined(CONFIG_CPM2 ) -print_str ("cpmfreq" ,strmhz (buf, bd->bi_cpmfreq)); +print_str ("cpmfreq" ,strmhz (buf, bd->bi_cpmfreq));#endif -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq));#endif /* CONFIG_405GP, CONFIG_405CR, CONFIG_405EP, CONFIG_XILINX_405, CONFIG_440EP CONFIG_440GR */ #if defined(CONFIG_MPC8220 ) -print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); -print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); -print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); -print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); -print_str ("pevfreq" ,strmhz (buf, bd->bi_pevfreq)); +print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); +print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); +print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); +print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); +print_str ("pevfreq" ,strmhz (buf, bd->bi_pevfreq));#endif print_eth (0 );
@@ -112,25 +113,25 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#endif #ifdef CONFIG_HERMES -print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed)); +print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed));#endif -printf ("IP addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %6ld bps\n" , bd->bi_baudrate ); -print_num ("relocaddr" , gd->relocaddr); +printf ("IP addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %6ld bps\n" , bd->bi_baudrate); +print_num ("relocaddr" , gd->relocaddr);return 0 ; }#elif defined(CONFIG_NIOS2) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start" , (ulong )bd->bi_memstart); -print_lnum ("mem size" , (u64 )bd->bi_memsize); -print_num ("flash start" , (ulong )bd->bi_flashstart); -print_num ("flash size" , (ulong )bd->bi_flashsize); -print_num ("flash offset" , (ulong )bd->bi_flashoffset); +print_num ("mem start" , (ulong )bd->bi_memstart); +print_lnum ("mem size" , (u64 )bd->bi_memsize); +print_num ("flash start" , (ulong )bd->bi_flashstart); +print_num ("flash size" , (ulong )bd->bi_flashsize); +print_num ("flash offset" , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_SRAM_BASE )print_num ("sram start" , (ulong )bd->bi_sramstart);
@@ -139,33 +140,33 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_MICROBLAZE ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start " , (ulong )bd->bi_memstart); -print_lnum ("mem size " , (u64 )bd->bi_memsize); -print_num ("flash start " , (ulong )bd->bi_flashstart); -print_num ("flash size " , (ulong )bd->bi_flashsize); -print_num ("flash offset " , (ulong )bd->bi_flashoffset); +print_num ("mem start " , (ulong )bd->bi_memstart); +print_lnum ("mem size " , (u64 )bd->bi_memsize); +print_num ("flash start " , (ulong )bd->bi_flashstart); +print_num ("flash size " , (ulong )bd->bi_flashsize); +print_num ("flash offset " , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_SRAM_BASE ) -print_num ("sram start " , (ulong )bd->bi_sramstart); -print_num ("sram size " , (ulong )bd->bi_sramsize); +print_num ("sram start " , (ulong )bd->bi_sramstart); +print_num ("sram size " , (ulong )bd->bi_sramsize);#endif #if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate);return 0 ; }
@@ -206,32 +207,32 @@ int do_bdinfo(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd;char buf[32 ]; -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_INIT_RAM_ADDR ) -print_num ("sramstart" , (ulong )bd->bi_sramstart); -print_num ("sramsize" , (ulong )bd->bi_sramsize); +print_num ("sramstart" , (ulong )bd->bi_sramstart); +print_num ("sramsize" , (ulong )bd->bi_sramsize);#endif #if defined(CONFIG_SYS_MBAR ) -print_num ("mbar" , bd->bi_mbar_base); +print_num ("mbar" , bd->bi_mbar_base);#endif -print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); +print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq));#ifdef CONFIG_PCI -print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); +print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq));#endif #ifdef CONFIG_EXTRA_CLOCK -print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); -print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); -print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); +print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); +print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); +print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq));#endif #if defined(CONFIG_CMD_NET )print_eth (0 );
@@ -245,9 +246,9 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_eth (3 );#endif -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , bd->bi_baudrate);return 0 ; }
@@ -264,16 +265,16 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])printf ("U-Boot = %s\n" , bd->bi_r_version);printf ("CPU = %s\n" , bd->bi_cpu);printf ("Board = %s\n" , bd->bi_board_name); -print_str ("VCO" ,strmhz (buf, bd->bi_vco)); -print_str ("CCLK" ,strmhz (buf, bd->bi_cclk)); -print_str ("SCLK" ,strmhz (buf, bd->bi_sclk)); +print_str ("VCO" ,strmhz (buf, bd->bi_vco)); +print_str ("CCLK" ,strmhz (buf, bd->bi_cclk)); +print_str ("SCLK" ,strmhz (buf, bd->bi_sclk)); -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 );printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);
@@ -284,55 +285,55 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#elif defined(CONFIG_MIPS ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_AVR32 ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %lu bps\n" , bd->bi_baudrate); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %lu bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_ARM ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {int i;bd_t *bd = gd->bd; -print_num ("arch_number" , bd->bi_arch_number); -print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("arch_number" , bd->bi_arch_number); +print_num ("boot_params" , (ulong )bd->bi_boot_params); -for (i=0 ; i<CONFIG_NR_DRAM_BANKS ; ++i) { +for (i =0 ; i <CONFIG_NR_DRAM_BANKS ; ++i) {print_num ("DRAM bank" , i);print_num ("-> start" , bd->bi_dram[i].start);print_num ("-> size" , bd->bi_dram[i].size);
@@ -340,36 +341,36 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);#if !(defined(CONFIG_SYS_NO_ICACHE ) && defined(CONFIG_SYS_NO_DCACHE )) -print_num ("TLB addr" , gd->tlb_addr); +print_num ("TLB addr" , gd->tlb_addr);#endif -print_num ("relocaddr" , gd->relocaddr); -print_num ("reloc off" , gd->reloc_off); -print_num ("irq_sp" , gd->irq_sp);/* irq stack pointer */ -print_num ("sp start " , gd->start_addr_sp); -print_num ("FB base " , gd->fb_base); +print_num ("relocaddr" , gd->relocaddr); +print_num ("reloc off" , gd->reloc_off); +print_num ("irq_sp" , gd->irq_sp);/* irq stack pointer */ +print_num ("sp start " , gd->start_addr_sp); +print_num ("FB base " , gd->fb_base);return 0 ; }#elif defined(CONFIG_SH ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start " , (ulong )bd->bi_memstart); -print_lnum ("mem size " , (u64 )bd->bi_memsize); -print_num ("flash start " , (ulong )bd->bi_flashstart); -print_num ("flash size " , (ulong )bd->bi_flashsize); -print_num ("flash offset " , (ulong )bd->bi_flashoffset); +print_num ("mem start " , (ulong )bd->bi_memstart); +print_lnum ("mem size " , (u64 )bd->bi_memsize); +print_num ("flash start " , (ulong )bd->bi_flashstart); +print_num ("flash size " , (ulong )bd->bi_flashsize); +print_num ("flash offset " , (ulong )bd->bi_flashoffset);#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate);return 0 ; }
@@ -377,25 +378,25 @@ int do_bdinfo (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {int i;bd_t *bd = gd->bd;char buf[32 ]; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("bi_memstart" , bd->bi_memstart); -print_num ("bi_memsize" , bd->bi_memsize); -print_num ("bi_flashstart" , bd->bi_flashstart); -print_num ("bi_flashsize" , bd->bi_flashsize); -print_num ("bi_flashoffset" , bd->bi_flashoffset); -print_num ("bi_sramstart" , bd->bi_sramstart); -print_num ("bi_sramsize" , bd->bi_sramsize); -print_num ("bi_bootflags" , bd->bi_bootflags); -print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); - -for (i=0 ; i<CONFIG_NR_DRAM_BANKS ; ++i) { +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("bi_memstart" , bd->bi_memstart); +print_num ("bi_memsize" , bd->bi_memsize); +print_num ("bi_flashstart" , bd->bi_flashstart); +print_num ("bi_flashsize" , bd->bi_flashsize); +print_num ("bi_flashoffset" , bd->bi_flashoffset); +print_num ("bi_sramstart" , bd->bi_sramstart); +print_num ("bi_sramsize" , bd->bi_sramsize); +print_num ("bi_bootflags" , bd->bi_bootflags); +print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); + +for (i =0 ; i <CONFIG_NR_DRAM_BANKS ; ++i) {print_num ("DRAM bank" , i);print_num ("-> start" , bd->bi_dram[i].start);print_num ("-> size" , bd->bi_dram[i].size);
@@ -403,10 +404,10 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed)); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed));#endif -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);return 0 ; }
@@ -417,7 +418,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])static void print_num (const char *name,ulong value) { -printf ("%-12s= 0x%08lX\n" , name, value); +printf ("%-12s= 0x%08lX\n" , name, value); }#if !(defined(CONFIG_ARM ) || defined(CONFIG_M68K )) || defined(CONFIG_CMD_NET )
@@ -438,17 +439,17 @@ static void print_eth(int idx)#if (!defined(CONFIG_ARM ) && !defined(CONFIG_X86 ))static void print_lnum (const char *name,u64 value) { -printf ("%-12s= 0x%.8llX\n" , name, value); +printf ("%-12s= 0x%.8llX\n" , name, value); }#endif -#if defined(CONFIG_PPC ) || \ - defined(CONFIG_M68K ) || \ - defined(CONFIG_BLACKFIN ) || \ - defined(CONFIG_X86 ) +#if defined(CONFIG_PPC ) || \ + defined(CONFIG_M68K ) || \ + defined(CONFIG_BLACKFIN ) || \ + defined(CONFIG_X86 )static void print_str (const char *name,const char *str) { -printf ("%-12s= %6s MHz\n" , name, str); +printf ("%-12s= %6s MHz\n" , name, str); }#endif /* CONFIG_PPC */
Signature · 1 line
1.7.3.5
PATCH 1/4 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi all,
2011/4/27 Macpaul Lin <[email protected]>:
Quoted 3 lines
clean up with 2.6.38 checkpatch.pl
Signed-off-by Macpaul Lin <[email protected]>
[PATCH 1/4] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Sorry for the mistake of wrong subject. This is a single patch. I'll resend one.
Signature · 2 lines
Best regards, Macpaul Lin
PATCH v2 1/1 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
In reply to Macpaul Linclean up with 2.6.38 checkpatch.pl
Signed-off-by Macpaul Lin <[email protected]>
---
Changes for v2:
- Correct the subject field to single patch.
common/cmd_bdinfo.c | 295 ++++++++++++++++++++++++++------------------------- 1 files changed, 148 insertions(+), 147 deletions(-)
common/cmd_bdinfo.c +148 -147
@@ -42,56 +42,57 @@ static void print_lnum(const char *, u64);#if defined(CONFIG_PPC )static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd;char buf[32 ];#ifdef DEBUG -print_num ("bd address" , (ulong )bd ); -#endif -print_num ("memstart" , bd->bi_memstart ); -print_lnum ("memsize" , bd->bi_memsize ); -print_num ("flashstart" , bd->bi_flashstart ); -print_num ("flashsize" , bd->bi_flashsize ); -print_num ("flashoffset" , bd->bi_flashoffset ); -print_num ("sramstart" , bd->bi_sramstart ); -print_num ("sramsize" , bd->bi_sramsize ); -#if defined(CONFIG_5xx) || defined(CONFIG_8xx) || \ - defined(CONFIG_8260 ) || defined(CONFIG_E500 ) -print_num ("immr_base" , bd->bi_immr_base ); -#endif -print_num ("bootflags" , bd->bi_bootflags ); -#if defined(CONFIG_405GP ) || defined(CONFIG_405CR ) || \ - defined(CONFIG_405EP ) || defined(CONFIG_XILINX_405 ) || \ - defined(CONFIG_440EP ) || defined(CONFIG_440GR ) || \ - defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) || \ - defined(CONFIG_440SP ) || defined(CONFIG_440SPE ) -print_str ("procfreq" ,strmhz (buf, bd->bi_procfreq)); -print_str ("plb_busfreq" ,strmhz (buf, bd->bi_plb_busfreq)); -#if defined(CONFIG_405GP ) || defined(CONFIG_405EP ) || defined(CONFIG_XILINX_405 ) || \ - defined(CONFIG_440EP ) || defined(CONFIG_440GR ) || defined(CONFIG_440SPE ) || \ - defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) -print_str ("pci_busfreq" ,strmhz (buf, bd->bi_pci_busfreq)); +print_num ("bd address" , (ulong )bd); +#endif +print_num ("memstart" , bd->bi_memstart); +print_lnum ("memsize" , bd->bi_memsize); +print_num ("flashstart" , bd->bi_flashstart); +print_num ("flashsize" , bd->bi_flashsize); +print_num ("flashoffset" , bd->bi_flashoffset); +print_num ("sramstart" , bd->bi_sramstart); +print_num ("sramsize" , bd->bi_sramsize); +#if defined(CONFIG_5xx) || defined(CONFIG_8xx) || \ + defined(CONFIG_8260 ) || defined(CONFIG_E500 ) +print_num ("immr_base" , bd->bi_immr_base); +#endif +print_num ("bootflags" , bd->bi_bootflags); +#if defined(CONFIG_405GP ) || defined(CONFIG_405CR ) || \ + defined(CONFIG_405EP ) || defined(CONFIG_XILINX_405 ) || \ + defined(CONFIG_440EP ) || defined(CONFIG_440GR ) || \ + defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) || \ + defined(CONFIG_440SP ) || defined(CONFIG_440SPE ) +print_str ("procfreq" ,strmhz (buf, bd->bi_procfreq)); +print_str ("plb_busfreq" ,strmhz (buf, bd->bi_plb_busfreq)); +#if defined(CONFIG_405GP ) || defined(CONFIG_405EP ) || \ + defined(CONFIG_XILINX_405 ) || defined(CONFIG_440EP ) || \ + defined(CONFIG_440GR ) || defined(CONFIG_440SPE ) || \ + defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) +print_str ("pci_busfreq" ,strmhz (buf, bd->bi_pci_busfreq));#endif #else /* ! CONFIG_405GP, CONFIG_405CR, CONFIG_405EP, CONFIG_XILINX_405, CONFIG_440EP CONFIG_440GR */ #if defined(CONFIG_CPM2 ) -print_str ("vco" ,strmhz (buf, bd->bi_vco)); -print_str ("sccfreq" ,strmhz (buf, bd->bi_sccfreq)); -print_str ("brgfreq" ,strmhz (buf, bd->bi_brgfreq)); +print_str ("vco" ,strmhz (buf, bd->bi_vco)); +print_str ("sccfreq" ,strmhz (buf, bd->bi_sccfreq)); +print_str ("brgfreq" ,strmhz (buf, bd->bi_brgfreq));#endif -print_str ("intfreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("intfreq" ,strmhz (buf, bd->bi_intfreq));#if defined(CONFIG_CPM2 ) -print_str ("cpmfreq" ,strmhz (buf, bd->bi_cpmfreq)); +print_str ("cpmfreq" ,strmhz (buf, bd->bi_cpmfreq));#endif -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq));#endif /* CONFIG_405GP, CONFIG_405CR, CONFIG_405EP, CONFIG_XILINX_405, CONFIG_440EP CONFIG_440GR */ #if defined(CONFIG_MPC8220 ) -print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); -print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); -print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); -print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); -print_str ("pevfreq" ,strmhz (buf, bd->bi_pevfreq)); +print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); +print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); +print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); +print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); +print_str ("pevfreq" ,strmhz (buf, bd->bi_pevfreq));#endif print_eth (0 );
@@ -112,25 +113,25 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#endif #ifdef CONFIG_HERMES -print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed)); +print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed));#endif -printf ("IP addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %6ld bps\n" , bd->bi_baudrate ); -print_num ("relocaddr" , gd->relocaddr); +printf ("IP addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %6ld bps\n" , bd->bi_baudrate); +print_num ("relocaddr" , gd->relocaddr);return 0 ; }#elif defined(CONFIG_NIOS2) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start" , (ulong )bd->bi_memstart); -print_lnum ("mem size" , (u64 )bd->bi_memsize); -print_num ("flash start" , (ulong )bd->bi_flashstart); -print_num ("flash size" , (ulong )bd->bi_flashsize); -print_num ("flash offset" , (ulong )bd->bi_flashoffset); +print_num ("mem start" , (ulong )bd->bi_memstart); +print_lnum ("mem size" , (u64 )bd->bi_memsize); +print_num ("flash start" , (ulong )bd->bi_flashstart); +print_num ("flash size" , (ulong )bd->bi_flashsize); +print_num ("flash offset" , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_SRAM_BASE )print_num ("sram start" , (ulong )bd->bi_sramstart);
@@ -139,33 +140,33 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_MICROBLAZE ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start " , (ulong )bd->bi_memstart); -print_lnum ("mem size " , (u64 )bd->bi_memsize); -print_num ("flash start " , (ulong )bd->bi_flashstart); -print_num ("flash size " , (ulong )bd->bi_flashsize); -print_num ("flash offset " , (ulong )bd->bi_flashoffset); +print_num ("mem start " , (ulong )bd->bi_memstart); +print_lnum ("mem size " , (u64 )bd->bi_memsize); +print_num ("flash start " , (ulong )bd->bi_flashstart); +print_num ("flash size " , (ulong )bd->bi_flashsize); +print_num ("flash offset " , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_SRAM_BASE ) -print_num ("sram start " , (ulong )bd->bi_sramstart); -print_num ("sram size " , (ulong )bd->bi_sramsize); +print_num ("sram start " , (ulong )bd->bi_sramstart); +print_num ("sram size " , (ulong )bd->bi_sramsize);#endif #if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate);return 0 ; }
@@ -206,32 +207,32 @@ int do_bdinfo(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd;char buf[32 ]; -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_INIT_RAM_ADDR ) -print_num ("sramstart" , (ulong )bd->bi_sramstart); -print_num ("sramsize" , (ulong )bd->bi_sramsize); +print_num ("sramstart" , (ulong )bd->bi_sramstart); +print_num ("sramsize" , (ulong )bd->bi_sramsize);#endif #if defined(CONFIG_SYS_MBAR ) -print_num ("mbar" , bd->bi_mbar_base); +print_num ("mbar" , bd->bi_mbar_base);#endif -print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); +print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq));#ifdef CONFIG_PCI -print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); +print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq));#endif #ifdef CONFIG_EXTRA_CLOCK -print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); -print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); -print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); +print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); +print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); +print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq));#endif #if defined(CONFIG_CMD_NET )print_eth (0 );
@@ -245,9 +246,9 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_eth (3 );#endif -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , bd->bi_baudrate);return 0 ; }
@@ -264,16 +265,16 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])printf ("U-Boot = %s\n" , bd->bi_r_version);printf ("CPU = %s\n" , bd->bi_cpu);printf ("Board = %s\n" , bd->bi_board_name); -print_str ("VCO" ,strmhz (buf, bd->bi_vco)); -print_str ("CCLK" ,strmhz (buf, bd->bi_cclk)); -print_str ("SCLK" ,strmhz (buf, bd->bi_sclk)); +print_str ("VCO" ,strmhz (buf, bd->bi_vco)); +print_str ("CCLK" ,strmhz (buf, bd->bi_cclk)); +print_str ("SCLK" ,strmhz (buf, bd->bi_sclk)); -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 );printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);
@@ -284,55 +285,55 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#elif defined(CONFIG_MIPS ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_AVR32 ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %lu bps\n" , bd->bi_baudrate); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %lu bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_ARM ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {int i;bd_t *bd = gd->bd; -print_num ("arch_number" , bd->bi_arch_number); -print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("arch_number" , bd->bi_arch_number); +print_num ("boot_params" , (ulong )bd->bi_boot_params); -for (i=0 ; i<CONFIG_NR_DRAM_BANKS ; ++i) { +for (i =0 ; i <CONFIG_NR_DRAM_BANKS ; ++i) {print_num ("DRAM bank" , i);print_num ("-> start" , bd->bi_dram[i].start);print_num ("-> size" , bd->bi_dram[i].size);
@@ -340,36 +341,36 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);#if !(defined(CONFIG_SYS_NO_ICACHE ) && defined(CONFIG_SYS_NO_DCACHE )) -print_num ("TLB addr" , gd->tlb_addr); +print_num ("TLB addr" , gd->tlb_addr);#endif -print_num ("relocaddr" , gd->relocaddr); -print_num ("reloc off" , gd->reloc_off); -print_num ("irq_sp" , gd->irq_sp);/* irq stack pointer */ -print_num ("sp start " , gd->start_addr_sp); -print_num ("FB base " , gd->fb_base); +print_num ("relocaddr" , gd->relocaddr); +print_num ("reloc off" , gd->reloc_off); +print_num ("irq_sp" , gd->irq_sp);/* irq stack pointer */ +print_num ("sp start " , gd->start_addr_sp); +print_num ("FB base " , gd->fb_base);return 0 ; }#elif defined(CONFIG_SH ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start " , (ulong )bd->bi_memstart); -print_lnum ("mem size " , (u64 )bd->bi_memsize); -print_num ("flash start " , (ulong )bd->bi_flashstart); -print_num ("flash size " , (ulong )bd->bi_flashsize); -print_num ("flash offset " , (ulong )bd->bi_flashoffset); +print_num ("mem start " , (ulong )bd->bi_memstart); +print_lnum ("mem size " , (u64 )bd->bi_memsize); +print_num ("flash start " , (ulong )bd->bi_flashstart); +print_num ("flash size " , (ulong )bd->bi_flashsize); +print_num ("flash offset " , (ulong )bd->bi_flashoffset);#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate);return 0 ; }
@@ -377,25 +378,25 @@ int do_bdinfo (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {int i;bd_t *bd = gd->bd;char buf[32 ]; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("bi_memstart" , bd->bi_memstart); -print_num ("bi_memsize" , bd->bi_memsize); -print_num ("bi_flashstart" , bd->bi_flashstart); -print_num ("bi_flashsize" , bd->bi_flashsize); -print_num ("bi_flashoffset" , bd->bi_flashoffset); -print_num ("bi_sramstart" , bd->bi_sramstart); -print_num ("bi_sramsize" , bd->bi_sramsize); -print_num ("bi_bootflags" , bd->bi_bootflags); -print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); - -for (i=0 ; i<CONFIG_NR_DRAM_BANKS ; ++i) { +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("bi_memstart" , bd->bi_memstart); +print_num ("bi_memsize" , bd->bi_memsize); +print_num ("bi_flashstart" , bd->bi_flashstart); +print_num ("bi_flashsize" , bd->bi_flashsize); +print_num ("bi_flashoffset" , bd->bi_flashoffset); +print_num ("bi_sramstart" , bd->bi_sramstart); +print_num ("bi_sramsize" , bd->bi_sramsize); +print_num ("bi_bootflags" , bd->bi_bootflags); +print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); + +for (i =0 ; i <CONFIG_NR_DRAM_BANKS ; ++i) {print_num ("DRAM bank" , i);print_num ("-> start" , bd->bi_dram[i].start);print_num ("-> size" , bd->bi_dram[i].size);
@@ -403,10 +404,10 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed)); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed));#endif -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);return 0 ; }
@@ -417,7 +418,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])static void print_num (const char *name,ulong value) { -printf ("%-12s= 0x%08lX\n" , name, value); +printf ("%-12s= 0x%08lX\n" , name, value); }#if !(defined(CONFIG_ARM ) || defined(CONFIG_M68K )) || defined(CONFIG_CMD_NET )
@@ -438,17 +439,17 @@ static void print_eth(int idx)#if (!defined(CONFIG_ARM ) && !defined(CONFIG_X86 ))static void print_lnum (const char *name,u64 value) { -printf ("%-12s= 0x%.8llX\n" , name, value); +printf ("%-12s= 0x%.8llX\n" , name, value); }#endif -#if defined(CONFIG_PPC ) || \ - defined(CONFIG_M68K ) || \ - defined(CONFIG_BLACKFIN ) || \ - defined(CONFIG_X86 ) +#if defined(CONFIG_PPC ) || \ + defined(CONFIG_M68K ) || \ + defined(CONFIG_BLACKFIN ) || \ + defined(CONFIG_X86 )static void print_str (const char *name,const char *str) { -printf ("%-12s= %6s MHz\n" , name, str); +printf ("%-12s= %6s MHz\n" , name, str); }#endif /* CONFIG_PPC */
Signature · 1 line
1.7.3.5
PATCH v2 1/1 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Macpaul,
Quoted 1 line
clean up with 2.6.38 checkpatch.pl
There is indeed only one non-whitespace hunk in there:
@@ -69,8 +69,9 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
defined(CONFIG_440SP) || defined(CONFIG_440SPE)
print_str ("procfreq", strmhz(buf, bd->bi_procfreq));
print_str ("plb_busfreq", strmhz(buf, bd->bi_plb_busfreq));
-#if defined(CONFIG_405GP) || defined(CONFIG_405EP) || defined(CONFIG_XILINX_405) || \
- defined(CONFIG_440EP) || defined(CONFIG_440GR) || defined(CONFIG_440SPE) || \
+#if defined(CONFIG_405GP) || defined(CONFIG_405EP) || \
+ defined(CONFIG_XILINX_405) || defined(CONFIG_440EP) || \
+ defined(CONFIG_440GR) || defined(CONFIG_440SPE) || \
defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
print_str ("pci_busfreq", strmhz(buf, bd->bi_pci_busfreq));#endif
It's ok that you do the line wrapping, but actually with such lists we require alphabetical sorting of the clauses, so can you please juggle the list so that the "XILINX_405" gets to the end?
Thanks!
Detlev
Signature · 7 lines
The continental people think life is a game. The English think
cricket is a game.
-- George Mikes
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.dePATCH v2 1/1 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Detlev,
2011/4/27 Detlev Zundel <[email protected]>:
Quoted 8 lines
Hi Macpaul,
Quoted 1 line
clean up with 2.6.38 checkpatch.pl
There is indeed only one non-whitespace hunk in there:
It's ok that you do the line wrapping, but actually with such lists we require alphabetical sorting of the clauses, so can you please juggle the list so that the "XILINX_405" gets to the end?
Since I've correct the subject of this patch v3 according to the "cosmetic" rule,
it seems patch v3 is out of this mailing thread.
So I remind you the patch v3 is here.
http://patchwork.ozlabs.org/patch/93169/
Thanks!
Signature · 2 lines
Best regards, Macpaul Lin
PATCH v2 1/1 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Macpaul,
Quoted 7 lines
Hi Detlev,
2011/4/27 Detlev Zundel <[email protected]>:
Quoted 4 lines
Hi Macpaul,
Quoted 1 line
clean up with 2.6.38 checkpatch.pl
Quoted 8 lines
Quoted 4 lines
There is indeed only one non-whitespace hunk in there:
It's ok that you do the line wrapping, but actually with such lists we require alphabetical sorting of the clauses, so can you please juggle the list so that the "XILINX_405" gets to the end?Since I've correct the subject of this patch v3 according to the "cosmetic" rule,
it seems patch v3 is out of this mailing thread.
This change of the subject was the reason why I did not require you changing it as I know that Wolfgang currently matches patch versions by subject strings.
"Correct" threading however uses "References:" mail headers and can cope with changing subjects. Somehow you seem to know this, as v3 indeed _has_ such a correct header and thus the threading in my mail reader works just fine ;)
Cheers
Detlev
Signature · 5 lines
0x2B | ~0x2B -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
PATCH v2 1/1 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Detlev,
Quoted 5 lines
"Correct" threading however uses "References:" mail headers and can cope with changing subjects. ?Somehow you seem to know this, as v3 indeed _has_ such a correct header and thus the threading in my mail reader works just fine ;)
Yes. I did fix the References and In-reply-to headers. However v3 it doesn't goes to the correct threadning in gmail. :p Anyway. Thanks for your reply. :D
Signature · 2 lines
Best regards, Macpaul Lin
PATCH v2 1/1 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Macpaul,
Quoted 8 lines
Quoted 5 lines
"Correct" threading however uses "References:" mail headers and can cope with changing subjects. ?Somehow you seem to know this, as v3 indeed _has_ such a correct header and thus the threading in my mail reader works just fine ;)
Yes. I did fix the References and In-reply-to headers. However v3 it doesn't goes to the correct threadning in gmail. :p
Gmail cannot handle "references:" headers? That is news to me. I find it always interesting that basic century old things seem to be forgotten by "modern all bells and whistles software"....
Cheers
Detlev
Signature · 6 lines
Windows Vista? And what a vista! All you see as you look around your garden is a 60foot high brick wall -- Crosbie Fitch. -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
PATCH v2 1/1 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
In reply to Detlev ZundelDear Detlev Zundel,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Since I've correct the subject of this patch v3 according to the "cosmetic" rule,
it seems patch v3 is out of this mailing thread.This change of the subject was the reason why I did not require you changing it as I know that Wolfgang currently matches patch versions by subject strings.
This is not quite correct. I refer to the Subject: only if no other thread information is present, i. e. if we have working In-reply-to:
and/or References: hewaders this works fine for me, too.
The problem is that only very few people provide correct thread references with updated patches.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Who is the oldest inhabitant of this village?" "We haven't got one; we had one, but he died three weeks ago."
PATCH v2 1/1 cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Wolfgang,
[...]
Quoted 7 lines
Quoted 3 lines
This change of the subject was the reason why I did not require you changing it as I know that Wolfgang currently matches patch versions by subject strings.
This is not quite correct. I refer to the Subject: only if no other thread information is present, i. e. if we have working In-reply-to:
and/or References: hewaders this works fine for me, too.
Ah ok. Sorry for misremembering and thanks for the correction.
Cheers
Detlev
Signature · 8 lines
Cyberwar is certainly not a myth. But you haven't seen it yet, despite
the attacks on Estonia. Cyberwar is warfare in cyberspace. And warfare
involves massive death and destruction. When you see it, you'll know it.
-- Bruce Schneier, Nov. 2007
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.dePATCH v3 1/1 cosmetic: cmd_bdinfo.c: clean up by using checkpatch.pl
In reply to Macpaul Lincmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Signed-off-by Macpaul Lin <[email protected]>
---
Changes for v2:
- Correct the subject field to single patch.
Changes for v3:
- 405XX, 440XX, XILINX_405 are sorted according to the reviewing suggestion.
- Replace the subject field according to the new rules.
common/cmd_bdinfo.c | 296 ++++++++++++++++++++++++++------------------------- 1 files changed, 149 insertions(+), 147 deletions(-)
common/cmd_bdinfo.c +149 -147
@@ -42,56 +42,58 @@ static void print_lnum(const char *, u64);#if defined(CONFIG_PPC )static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd;char buf[32 ];#ifdef DEBUG -print_num ("bd address" , (ulong )bd ); -#endif -print_num ("memstart" , bd->bi_memstart ); -print_lnum ("memsize" , bd->bi_memsize ); -print_num ("flashstart" , bd->bi_flashstart ); -print_num ("flashsize" , bd->bi_flashsize ); -print_num ("flashoffset" , bd->bi_flashoffset ); -print_num ("sramstart" , bd->bi_sramstart ); -print_num ("sramsize" , bd->bi_sramsize ); -#if defined(CONFIG_5xx) || defined(CONFIG_8xx) || \ - defined(CONFIG_8260 ) || defined(CONFIG_E500 ) -print_num ("immr_base" , bd->bi_immr_base ); -#endif -print_num ("bootflags" , bd->bi_bootflags ); -#if defined(CONFIG_405GP ) || defined(CONFIG_405CR ) || \ - defined(CONFIG_405EP ) || defined(CONFIG_XILINX_405 ) || \ - defined(CONFIG_440EP ) || defined(CONFIG_440GR ) || \ - defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) || \ - defined(CONFIG_440SP ) || defined(CONFIG_440SPE ) -print_str ("procfreq" ,strmhz (buf, bd->bi_procfreq)); -print_str ("plb_busfreq" ,strmhz (buf, bd->bi_plb_busfreq)); -#if defined(CONFIG_405GP ) || defined(CONFIG_405EP ) || defined(CONFIG_XILINX_405 ) || \ - defined(CONFIG_440EP ) || defined(CONFIG_440GR ) || defined(CONFIG_440SPE ) || \ - defined(CONFIG_440EPX ) || defined(CONFIG_440GRX ) -print_str ("pci_busfreq" ,strmhz (buf, bd->bi_pci_busfreq)); +print_num ("bd address" , (ulong )bd); +#endif +print_num ("memstart" , bd->bi_memstart); +print_lnum ("memsize" , bd->bi_memsize); +print_num ("flashstart" , bd->bi_flashstart); +print_num ("flashsize" , bd->bi_flashsize); +print_num ("flashoffset" , bd->bi_flashoffset); +print_num ("sramstart" , bd->bi_sramstart); +print_num ("sramsize" , bd->bi_sramsize); +#if defined(CONFIG_5xx) || defined(CONFIG_8xx) || \ + defined(CONFIG_8260 ) || defined(CONFIG_E500 ) +print_num ("immr_base" , bd->bi_immr_base); +#endif +print_num ("bootflags" , bd->bi_bootflags); +#if defined(CONFIG_405CR ) || defined(CONFIG_405EP ) || \ + defined(CONFIG_405GP ) || \ + defined(CONFIG_440EP ) || defined(CONFIG_440EPX ) || \ + defined(CONFIG_440GR ) || defined(CONFIG_440GRX ) || \ + defined(CONFIG_440SP ) || defined(CONFIG_440SPE ) || \ + defined(CONFIG_XILINX_405 ) +print_str ("procfreq" ,strmhz (buf, bd->bi_procfreq)); +print_str ("plb_busfreq" ,strmhz (buf, bd->bi_plb_busfreq)); +#if defined(CONFIG_405EP ) || defined(CONFIG_405GP ) || \ + defined(CONFIG_440EP ) || defined(CONFIG_440EPX ) || \ + defined(CONFIG_440GR ) || defined(CONFIG_440GRX ) || \ + defined(CONFIG_440SPE ) || defined(CONFIG_XILINX_405 ) +print_str ("pci_busfreq" ,strmhz (buf, bd->bi_pci_busfreq));#endif #else /* ! CONFIG_405GP, CONFIG_405CR, CONFIG_405EP, CONFIG_XILINX_405, CONFIG_440EP CONFIG_440GR */ #if defined(CONFIG_CPM2 ) -print_str ("vco" ,strmhz (buf, bd->bi_vco)); -print_str ("sccfreq" ,strmhz (buf, bd->bi_sccfreq)); -print_str ("brgfreq" ,strmhz (buf, bd->bi_brgfreq)); +print_str ("vco" ,strmhz (buf, bd->bi_vco)); +print_str ("sccfreq" ,strmhz (buf, bd->bi_sccfreq)); +print_str ("brgfreq" ,strmhz (buf, bd->bi_brgfreq));#endif -print_str ("intfreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("intfreq" ,strmhz (buf, bd->bi_intfreq));#if defined(CONFIG_CPM2 ) -print_str ("cpmfreq" ,strmhz (buf, bd->bi_cpmfreq)); +print_str ("cpmfreq" ,strmhz (buf, bd->bi_cpmfreq));#endif -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq));#endif /* CONFIG_405GP, CONFIG_405CR, CONFIG_405EP, CONFIG_XILINX_405, CONFIG_440EP CONFIG_440GR */ #if defined(CONFIG_MPC8220 ) -print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); -print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); -print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); -print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); -print_str ("pevfreq" ,strmhz (buf, bd->bi_pevfreq)); +print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); +print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); +print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); +print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); +print_str ("pevfreq" ,strmhz (buf, bd->bi_pevfreq));#endif print_eth (0 );
@@ -112,25 +114,25 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#endif #ifdef CONFIG_HERMES -print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed)); +print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed));#endif -printf ("IP addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %6ld bps\n" , bd->bi_baudrate ); -print_num ("relocaddr" , gd->relocaddr); +printf ("IP addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %6ld bps\n" , bd->bi_baudrate); +print_num ("relocaddr" , gd->relocaddr);return 0 ; }#elif defined(CONFIG_NIOS2) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start" , (ulong )bd->bi_memstart); -print_lnum ("mem size" , (u64 )bd->bi_memsize); -print_num ("flash start" , (ulong )bd->bi_flashstart); -print_num ("flash size" , (ulong )bd->bi_flashsize); -print_num ("flash offset" , (ulong )bd->bi_flashoffset); +print_num ("mem start" , (ulong )bd->bi_memstart); +print_lnum ("mem size" , (u64 )bd->bi_memsize); +print_num ("flash start" , (ulong )bd->bi_flashstart); +print_num ("flash size" , (ulong )bd->bi_flashsize); +print_num ("flash offset" , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_SRAM_BASE )print_num ("sram start" , (ulong )bd->bi_sramstart);
@@ -139,33 +141,33 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_MICROBLAZE ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start " , (ulong )bd->bi_memstart); -print_lnum ("mem size " , (u64 )bd->bi_memsize); -print_num ("flash start " , (ulong )bd->bi_flashstart); -print_num ("flash size " , (ulong )bd->bi_flashsize); -print_num ("flash offset " , (ulong )bd->bi_flashoffset); +print_num ("mem start " , (ulong )bd->bi_memstart); +print_lnum ("mem size " , (u64 )bd->bi_memsize); +print_num ("flash start " , (ulong )bd->bi_flashstart); +print_num ("flash size " , (ulong )bd->bi_flashsize); +print_num ("flash offset " , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_SRAM_BASE ) -print_num ("sram start " , (ulong )bd->bi_sramstart); -print_num ("sram size " , (ulong )bd->bi_sramsize); +print_num ("sram start " , (ulong )bd->bi_sramstart); +print_num ("sram size " , (ulong )bd->bi_sramsize);#endif #if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate);return 0 ; }
@@ -206,32 +208,32 @@ int do_bdinfo(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd;char buf[32 ]; -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);#if defined(CONFIG_SYS_INIT_RAM_ADDR ) -print_num ("sramstart" , (ulong )bd->bi_sramstart); -print_num ("sramsize" , (ulong )bd->bi_sramsize); +print_num ("sramstart" , (ulong )bd->bi_sramstart); +print_num ("sramsize" , (ulong )bd->bi_sramsize);#endif #if defined(CONFIG_SYS_MBAR ) -print_num ("mbar" , bd->bi_mbar_base); +print_num ("mbar" , bd->bi_mbar_base);#endif -print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); +print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq));#ifdef CONFIG_PCI -print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq)); +print_str ("pcifreq" ,strmhz (buf, bd->bi_pcifreq));#endif #ifdef CONFIG_EXTRA_CLOCK -print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); -print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); -print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq)); +print_str ("flbfreq" ,strmhz (buf, bd->bi_flbfreq)); +print_str ("inpfreq" ,strmhz (buf, bd->bi_inpfreq)); +print_str ("vcofreq" ,strmhz (buf, bd->bi_vcofreq));#endif #if defined(CONFIG_CMD_NET )print_eth (0 );
@@ -245,9 +247,9 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])print_eth (3 );#endif -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , bd->bi_baudrate);return 0 ; }
@@ -264,16 +266,16 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])printf ("U-Boot = %s\n" , bd->bi_r_version);printf ("CPU = %s\n" , bd->bi_cpu);printf ("Board = %s\n" , bd->bi_board_name); -print_str ("VCO" ,strmhz (buf, bd->bi_vco)); -print_str ("CCLK" ,strmhz (buf, bd->bi_cclk)); -print_str ("SCLK" ,strmhz (buf, bd->bi_sclk)); +print_str ("VCO" ,strmhz (buf, bd->bi_vco)); +print_str ("CCLK" ,strmhz (buf, bd->bi_cclk)); +print_str ("SCLK" ,strmhz (buf, bd->bi_sclk)); -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 );printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);
@@ -284,55 +286,55 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#elif defined(CONFIG_MIPS ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_AVR32 ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("memstart" , (ulong )bd->bi_memstart); -print_lnum ("memsize" , (u64 )bd->bi_memsize); -print_num ("flashstart" , (ulong )bd->bi_flashstart); -print_num ("flashsize" , (ulong )bd->bi_flashsize); -print_num ("flashoffset" , (ulong )bd->bi_flashoffset); +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("memstart" , (ulong )bd->bi_memstart); +print_lnum ("memsize" , (u64 )bd->bi_memsize); +print_num ("flashstart" , (ulong )bd->bi_flashstart); +print_num ("flashsize" , (ulong )bd->bi_flashsize); +print_num ("flashoffset" , (ulong )bd->bi_flashoffset);print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -printf ("baudrate = %lu bps\n" , bd->bi_baudrate); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("baudrate = %lu bps\n" , bd->bi_baudrate);return 0 ; }#elif defined(CONFIG_ARM ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {int i;bd_t *bd = gd->bd; -print_num ("arch_number" , bd->bi_arch_number); -print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("arch_number" , bd->bi_arch_number); +print_num ("boot_params" , (ulong )bd->bi_boot_params); -for (i=0 ; i<CONFIG_NR_DRAM_BANKS ; ++i) { +for (i =0 ; i <CONFIG_NR_DRAM_BANKS ; ++i) {print_num ("DRAM bank" , i);print_num ("-> start" , bd->bi_dram[i].start);print_num ("-> size" , bd->bi_dram[i].size);
@@ -340,36 +342,36 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);#if !(defined(CONFIG_SYS_NO_ICACHE ) && defined(CONFIG_SYS_NO_DCACHE )) -print_num ("TLB addr" , gd->tlb_addr); +print_num ("TLB addr" , gd->tlb_addr);#endif -print_num ("relocaddr" , gd->relocaddr); -print_num ("reloc off" , gd->reloc_off); -print_num ("irq_sp" , gd->irq_sp);/* irq stack pointer */ -print_num ("sp start " , gd->start_addr_sp); -print_num ("FB base " , gd->fb_base); +print_num ("relocaddr" , gd->relocaddr); +print_num ("reloc off" , gd->reloc_off); +print_num ("irq_sp" , gd->irq_sp);/* irq stack pointer */ +print_num ("sp start " , gd->start_addr_sp); +print_num ("FB base " , gd->fb_base);return 0 ; }#elif defined(CONFIG_SH ) -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {bd_t *bd = gd->bd; -print_num ("mem start " , (ulong )bd->bi_memstart); -print_lnum ("mem size " , (u64 )bd->bi_memsize); -print_num ("flash start " , (ulong )bd->bi_flashstart); -print_num ("flash size " , (ulong )bd->bi_flashsize); -print_num ("flash offset " , (ulong )bd->bi_flashoffset); +print_num ("mem start " , (ulong )bd->bi_memstart); +print_lnum ("mem size " , (u64 )bd->bi_memsize); +print_num ("flash start " , (ulong )bd->bi_flashstart); +print_num ("flash size " , (ulong )bd->bi_flashsize); +print_num ("flash offset " , (ulong )bd->bi_flashoffset);#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr);#endif -printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate); +printf ("baudrate = %ld bps\n" , (ulong )bd->bi_baudrate);return 0 ; }
@@ -377,25 +379,25 @@ int do_bdinfo (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])static void print_str (const char *,const char *); -int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) +int do_bdinfo (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {int i;bd_t *bd = gd->bd;char buf[32 ]; -print_num ("boot_params" , (ulong )bd->bi_boot_params); -print_num ("bi_memstart" , bd->bi_memstart); -print_num ("bi_memsize" , bd->bi_memsize); -print_num ("bi_flashstart" , bd->bi_flashstart); -print_num ("bi_flashsize" , bd->bi_flashsize); -print_num ("bi_flashoffset" , bd->bi_flashoffset); -print_num ("bi_sramstart" , bd->bi_sramstart); -print_num ("bi_sramsize" , bd->bi_sramsize); -print_num ("bi_bootflags" , bd->bi_bootflags); -print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); -print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); - -for (i=0 ; i<CONFIG_NR_DRAM_BANKS ; ++i) { +print_num ("boot_params" , (ulong )bd->bi_boot_params); +print_num ("bi_memstart" , bd->bi_memstart); +print_num ("bi_memsize" , bd->bi_memsize); +print_num ("bi_flashstart" , bd->bi_flashstart); +print_num ("bi_flashsize" , bd->bi_flashsize); +print_num ("bi_flashoffset" , bd->bi_flashoffset); +print_num ("bi_sramstart" , bd->bi_sramstart); +print_num ("bi_sramsize" , bd->bi_sramsize); +print_num ("bi_bootflags" , bd->bi_bootflags); +print_str ("cpufreq" ,strmhz (buf, bd->bi_intfreq)); +print_str ("busfreq" ,strmhz (buf, bd->bi_busfreq)); + +for (i =0 ; i <CONFIG_NR_DRAM_BANKS ; ++i) {print_num ("DRAM bank" , i);print_num ("-> start" , bd->bi_dram[i].start);print_num ("-> size" , bd->bi_dram[i].size);
@@ -403,10 +405,10 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_CMD_NET )print_eth (0 ); -printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); -print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed)); +printf ("ip_addr = %pI4\n" , &bd->bi_ip_addr); +print_str ("ethspeed" ,strmhz (buf, bd->bi_ethspeed));#endif -printf ("baudrate = %d bps\n" , bd->bi_baudrate); +printf ("baudrate = %d bps\n" , bd->bi_baudrate);return 0 ; }
@@ -417,7 +419,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])static void print_num (const char *name,ulong value) { -printf ("%-12s= 0x%08lX\n" , name, value); +printf ("%-12s= 0x%08lX\n" , name, value); }#if !(defined(CONFIG_ARM ) || defined(CONFIG_M68K )) || defined(CONFIG_CMD_NET )
@@ -438,17 +440,17 @@ static void print_eth(int idx)#if (!defined(CONFIG_ARM ) && !defined(CONFIG_X86 ))static void print_lnum (const char *name,u64 value) { -printf ("%-12s= 0x%.8llX\n" , name, value); +printf ("%-12s= 0x%.8llX\n" , name, value); }#endif -#if defined(CONFIG_PPC ) || \ - defined(CONFIG_M68K ) || \ - defined(CONFIG_BLACKFIN ) || \ - defined(CONFIG_X86 ) +#if defined(CONFIG_PPC ) || \ + defined(CONFIG_M68K ) || \ + defined(CONFIG_BLACKFIN ) || \ + defined(CONFIG_X86 )static void print_str (const char *name,const char *str) { -printf ("%-12s= %6s MHz\n" , name, str); +printf ("%-12s= %6s MHz\n" , name, str); }#endif /* CONFIG_PPC */
Signature · 1 line
1.7.3.5
PATCH v3 1/1 cosmetic: cmd_bdinfo.c: clean up by using checkpatch.pl
Hi Macpaul,
Quoted 3 lines
cmd_bdinfo.c: clean up with 2.6.38 checkpatch.plSigned-off-by Macpaul Lin <[email protected]>
Looks sane to me, thanks!
Acked-by Detlev Zundel <[email protected]>
Signature · 8 lines
Peace of mind isn't at all superficial to technical work. It's the
whole thing. That which produces it is good work and that which
destroys it is bad work.
-- Robert M. Pirsig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.deWolfgang Denk
AppliedPATCH v3 1/1 cosmetic: cmd_bdinfo.c: clean up by using checkpatch.pl
In reply to Macpaul LinDear Macpaul Lin,
Quoted 11 lines · In message <[email protected]> you wrote:
cmd_bdinfo.c: clean up with 2.6.38 checkpatch.plSigned-off-by Macpaul Lin <[email protected]>---
Changes for v2:
- Correct the subject field to single patch.
Changes for v3:
- 405XX, 440XX,XILINX_405are sorted according to the reviewing suggestion.
- Replace the subject field according to the new rules.
Quoted 2 lines
common/cmd_bdinfo.c | 296 ++++++++++++++++++++++++++------------------------- 1 files changed, 149 insertions(+), 147 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A failure will not appear until a unit has passed final inspection.