Skip to contentSkip to conversation

mmc: meson-gx: fix setting f_min

PATCH New Heiner Kallweit 3 participants 6 messages Jan 26, 2017 – Feb 1, 2017

Subsystems (2)
Arm/Amlogic Meson SoC support MMC, SD and SDIO
lore
Share & tools
lore

Heiner Kallweit

author
#0 lore raw

PATCH 1/3 mmc: meson-gx: fix setting f_min

Currently f_min is set to 4 MHz whilst the comment states 400 MHz. I think the itention is to set f_min to 400 kHz.
Change value and comment accordingly.

Signed-off-by Heiner Kallweit <[email protected]>
---
 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/meson-gx-mmc.c +1 -1
index bf19d03c..cf071756 100644
@@ -268,7 +268,7 @@ static int meson_mmc_clk_init(struct meson_host *host)
 	if (f_min != UINT_MAX)
 		f_min = DIV_ROUND_UP(CLK_SRC_XTAL_RATE, CLK_DIV_MAX);
 	else
-		f_min = 4000000;  /* default min: 400 MHz */
+		f_min = 400000;  /* default min: 400 kHz */
 	host->mmc->f_min = f_min;
 
 	/* create the mux */
Signature · 1 line
2.11.0
maintainer
#1 lore raw

PATCH 1/3 mmc: meson-gx: fix setting f_min

Quoted 2 lines · Heiner Kallweit

Currently f_min is set to 4 MHz whilst the comment states 400 MHz. I think the itention is to set f_min to 400 kHz.

Yes indeed.

Quoted 3 lines

Change value and comment accordingly.

Signed-off-by Heiner Kallweit <[email protected]>
Acked-by Kevin Hilman <[email protected]>
Quoted 17 lines
---
 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/meson-gx-mmc.c +1 -1
index bf19d03c..cf071756 100644
@@ -268,7 +268,7 @@ static int meson_mmc_clk_init(struct meson_host *host)
 	if (f_min != UINT_MAX)
 		f_min = DIV_ROUND_UP(CLK_SRC_XTAL_RATE, CLK_DIV_MAX);
 	else
-		f_min = 4000000;  /* default min: 400 MHz */
+		f_min = 400000;  /* default min: 400 kHz */
 	host->mmc->f_min = f_min;
 
 	/* create the mux */
#2 lore raw

PATCH 1/3 mmc: meson-gx: fix setting f_min

In reply to Heiner Kallweit
Quoted 5 lines · Heiner Kallweit

Currently f_min is set to 4 MHz whilst the comment states 400 MHz. I think the itention is to set f_min to 400 kHz.
Change value and comment accordingly.

Signed-off-by Heiner Kallweit <[email protected]>

Heiner, could you please collect the mmc meson changes that you recently have submitted in one series and re-post to linux-mmc. I can pick them up from there.

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/meson-gx-mmc.c +1 -2
index bf19d03c..cf071756 100644
@@ -268,7 +268,7 @@ static int meson_mmc_clk_init(struct meson_host *host)
        if (f_min != UINT_MAX)
                f_min = DIV_ROUND_UP(CLK_SRC_XTAL_RATE, CLK_DIV_MAX);
        else
-               f_min = 4000000;  /* default min: 400 MHz */
+               f_min = 400000;  /* default min: 400 kHz */
        host->mmc->f_min = f_min;
 
        /* create the mux */
--

2.11.0

author
#3 lore raw

PATCH 1/3 mmc: meson-gx: fix setting f_min

Am 31.01.2017 um 12:55 schrieb Ulf Hansson:

Quoted 11 lines · Heiner Kallweit
Quoted 5 lines

Currently f_min is set to 4 MHz whilst the comment states 400 MHz. I think the itention is to set f_min to 400 kHz.
Change value and comment accordingly.

Signed-off-by Heiner Kallweit <[email protected]>

Heiner, could you please collect the mmc meson changes that you recently have submitted in one series and re-post to linux-mmc. I can pick them up from there.

Sure. Apart from the ones you've reviewed already I have few more. I'll add them to the patch set.

Regards, Heiner

Quoted 24 lines

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/meson-gx-mmc.c +1 -2
index bf19d03c..cf071756 100644
@@ -268,7 +268,7 @@ static int meson_mmc_clk_init(struct meson_host *host)
        if (f_min != UINT_MAX)
                f_min = DIV_ROUND_UP(CLK_SRC_XTAL_RATE, CLK_DIV_MAX);
        else
-               f_min = 4000000;  /* default min: 400 MHz */
+               f_min = 400000;  /* default min: 400 kHz */
        host->mmc->f_min = f_min;
 
        /* create the mux */
--

2.11.0

maintainer
#4 lore raw

PATCH 1/3 mmc: meson-gx: fix setting f_min

Quoted 6 lines · Heiner Kallweit

Am 31.01.2017 um 12:55 schrieb Ulf Hansson:

Quoted 5 lines · Heiner Kallweit
Quoted 4 lines

Currently f_min is set to 4 MHz whilst the comment states 400 MHz. I think the itention is to set f_min to 400 kHz.
Change value and comment accordingly.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Heiner Kallweit <[email protected]>

Heiner, could you please collect the mmc meson changes that you recently have submitted in one series and re-post to linux-mmc. I can pick them up from there.

Sure. Apart from the ones you've reviewed already I have few more. I'll add them to the patch set.

When you re-post, it's customary to collect and add the various tags (acked-by, tested-by, reviewed-by) to the changelog so it's easy to tell what's already been reviewed/acked etc.

Kevin

maintainer
#5 lore raw

PATCH 1/3 mmc: meson-gx: fix setting f_min

Quoted 13 lines · Kevin Hilman
Quoted 12 lines · Heiner Kallweit

Am 31.01.2017 um 12:55 schrieb Ulf Hansson:

Quoted 11 lines · Heiner Kallweit
Quoted 5 lines

Currently f_min is set to 4 MHz whilst the comment states 400 MHz. I think the itention is to set f_min to 400 kHz.
Change value and comment accordingly.

Signed-off-by Heiner Kallweit <[email protected]>

Heiner, could you please collect the mmc meson changes that you recently have submitted in one series and re-post to linux-mmc. I can pick them up from there.

Quoted 6 lines
Quoted 2 lines

Sure. Apart from the ones you've reviewed already I have few more. I'll add them to the patch set.

When you re-post, it's customary to collect and add the various tags (acked-by, tested-by, reviewed-by) to the changelog so it's easy to tell what's already been reviewed/acked etc.

Also, please be sure to Cc the linux-amlogic list.

Thanks,

Kevin