Skip to contentSkip to conversation

clk: gxbb: expose CLKID_MMC_PCLK

PATCH Superseded Kevin Hilman 2 participants 4 messages Jul 7, 2016 – Jul 16, 2016

Subsystems (4)
Device tree bindings Arm/Amlogic Meson SoC support Common clk Arm/Amlogic Meson SoC clock framework
lore
Share & tools
lore

Kevin Hilman

author maintainer
#0 lore raw

PATCH v2 1/1 clk: gxbb: expose CLKID_MMC_PCLK

The MMC_PCLK is needed for the SD/eMMC driver, expose to DT (and comment out in clk driver)

Signed-off-by Kevin Hilman <[email protected]>
---
 drivers/clk/meson/gxbb.h              | 2 +-
 include/dt-bindings/clock/gxbb-clkc.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/clk/meson/gxbb.h +1 -1
index a2adf3448b59..8355ecd27b81 100644
@@ -234,7 +234,7 @@
 #define CLKID_HDMI_PCLK		  63
 #define CLKID_USB1_DDR_BRIDGE	  64
 #define CLKID_USB0_DDR_BRIDGE	  65
-#define CLKID_MMC_PCLK		  66
+/* CLKID_MMC_PCLK */	       
 #define CLKID_DVIN		  67
 #define CLKID_UART2		  68
 #define CLKID_SANA		  69
include/dt-bindings/clock/gxbb-clkc.h +1 -0
index f889d80246cb..5eb69ec74f6b 100644
@@ -8,5 +8,6 @@
 #define CLKID_CPUCLK		1
 #define CLKID_CLK81		12
 #define CLKID_ETH		36
+#define CLKID_MMC_PCLK		66
 
 #endif /* __GXBB_CLKC_H */
Signature · 1 line
2.9.0
Applied
#1 lore raw

PATCH v2 1/1 clk: gxbb: expose CLKID_MMC_PCLK

Quoting Kevin Hilman (2016-07-06 20:38:37)

Quoted 4 lines

The MMC_PCLK is needed for the SD/eMMC driver, expose to DT (and comment out in clk driver)

Signed-off-by Kevin Hilman <[email protected]>

Applied to the same clk-s905 branch if you need to re-pull it as a dependency.

Regards,
Mike

Quoted 32 lines
---
 drivers/clk/meson/gxbb.h              | 2 +-
 include/dt-bindings/clock/gxbb-clkc.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/clk/meson/gxbb.h +1 -1
index a2adf3448b59..8355ecd27b81 100644
@@ -234,7 +234,7 @@
 #define CLKID_HDMI_PCLK                  63
 #define CLKID_USB1_DDR_BRIDGE    64
 #define CLKID_USB0_DDR_BRIDGE    65
-#define CLKID_MMC_PCLK           66
+/* CLKID_MMC_PCLK */          
 #define CLKID_DVIN               67
 #define CLKID_UART2              68
 #define CLKID_SANA               69
include/dt-bindings/clock/gxbb-clkc.h +1 -0
index f889d80246cb..5eb69ec74f6b 100644
@@ -8,5 +8,6 @@
 #define CLKID_CPUCLK           1
 #define CLKID_CLK81            12
 #define CLKID_ETH              36
+#define CLKID_MMC_PCLK         66
 
 #endif /* __GXBB_CLKC_H */
Signature · 1 line
2.9.0
author maintainer
#2 lore raw

PATCH v2 1/1 clk: gxbb: expose CLKID_MMC_PCLK

Quoted 8 lines · Michael Turquette

Quoting Kevin Hilman (2016-07-06 20:38:37)

Quoted 4 lines

The MMC_PCLK is needed for the SD/eMMC driver, expose to DT (and comment out in clk driver)

Signed-off-by Kevin Hilman <[email protected]>

Applied to the same clk-s905 branch if you need to re-pull it as a dependency.

Ugh. Just received some updated documentation, and turns out this clock is not used at all. :(

Feel free to revert now before it becomes ABI.

Now that I have actual docs, I'll have a new series coming that will have the right clock details.

Thanks, and sorry for the noise,

Kevin

#3 lore raw

PATCH v2 1/1 clk: gxbb: expose CLKID_MMC_PCLK

Quoting Kevin Hilman (2016-07-15 09:48:30)

Quoted 8 lines
Quoted 6 lines · Michael Turquette

Quoting Kevin Hilman (2016-07-06 20:38:37)

Quoted 4 lines

The MMC_PCLK is needed for the SD/eMMC driver, expose to DT (and comment out in clk driver)

Signed-off-by Kevin Hilman <[email protected]>
Quoted 7 lines
Quoted 2 lines

Applied to the same clk-s905 branch if you need to re-pull it as a dependency.

Ugh. Just received some updated documentation, and turns out this clock is not used at all. :(

Feel free to revert now before it becomes ABI.

Reverted.

Quoted 3 lines

Now that I have actual docs, I'll have a new series coming that will have the right clock details.

No problem. I did a git revert b/c I don't want to rebase this late in the cycle.

Regards,
Mike

Quoted 4 lines

Thanks, and sorry for the noise,

Kevin