SDHCI: S3C: Use generic clock names for sdhci bus clock options
Subsystems (4)
PATCH v6 1/1 SDHCI: S3C: Use generic clock names for sdhci bus clock options
This patch modifies the driver to stop depending on the clock names being passed from the platform and switch over to bus clock lookup using generic clock names.
V6 Changes:
Changed sprintf to snprintf as suggested by Chris Ball.
--- drivers/mmc/host/sdhci-s3c.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
drivers/mmc/host/sdhci-s3c.c +2 -5
@@ -435,14 +435,11 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)for (clks =0 , ptr =0 ; ptr <MAX_BUS_CLK ; ptr++) {struct clk *clk; -char *name = pdata->clocks[ptr]; - -if (name ==NULL ) -continue ; +char name[14 ]; +snprintf (name,14 ,"mmc_busclk.%d" , ptr); clk =clk_get (dev, name);if (IS_ERR (clk)) { -dev_err (dev,"failed to get clock %s\n" , name);continue ; }
Signature · 1 line
1.7.4.4
PATCH v6 1/1 SDHCI: S3C: Use generic clock names for sdhci bus clock options
Quoted 9 lines · Rajeshwari Shinde
This patch modifies the driver to stop depending on the clock names being passed from the platform and switch over to bus clock lookup using generic clock names.
V6 Changes:
Changed sprintf to snprintf as suggested by Chris Ball.Signed-off-by Rajeshwari Shinde <[email protected]>
Hi Chirs,
Could you please pick this up in your tree for this merge window?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
Quoted 28 lines
--- drivers/mmc/host/sdhci-s3c.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)drivers/mmc/host/sdhci-s3c.c +2
-6@@ -435,14 +435,11 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)for (clks =0 , ptr =0 ; ptr <MAX_BUS_CLK ; ptr++) {struct clk *clk; -char *name = pdata->clocks[ptr]; - -if (name ==NULL ) -continue ; +char name[14 ]; +snprintf (name,14 ,"mmc_busclk.%d" , ptr); clk =clk_get (dev, name);if (IS_ERR (clk)) { -dev_err (dev,"failed to get clock %s\n" , name);continue ; } --1.7.4.4
PATCH v6 1/1 SDHCI: S3C: Use generic clock names for sdhci bus clock options
Hi Kukjin,
Quoted 7 lines · Kukjin Kim
Quoted 7 lines
This patch modifies the driver to stop depending on the clock names being passed from the platform and switch over to bus clock lookup using generic clock names.
V6 Changes:
Changed sprintf to snprintf as suggested by Chris Ball.
Quoted 7 lines
Quoted 1 line
Signed-off-by Rajeshwari Shinde <[email protected]>Acked-by Kukjin Kim <[email protected]>Hi Chirs,
Could you please pick this up in your tree for this merge window?
Might be easier to have you send this, if you don't mind, since I'm still traveling and have already sent my main pull request. Thanks!
- Chris.
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child
PATCH v6 1/1 SDHCI: S3C: Use generic clock names for sdhci bus clock options
Quoted 15 lines · Chris Ball
Hi Kukjin,
Quoted 11 lines · Kukjin Kim
Quoted 8 lines
This patch modifies the driver to stop depending on the clock names being passed from the platform and switch over to bus clock lookup using generic clock names.
V6 Changes:
Changed sprintf to snprintf as suggested by Chris Ball.Signed-off-by Rajeshwari Shinde <[email protected]>Acked-by Kukjin Kim <[email protected]>
Quoted 9 lines
Quoted 3 lines
Hi Chirs,
Could you please pick this up in your tree for this merge window?
Might be easier to have you send this, if you don't mind, since I'm still traveling and have already sent my main pull request. Thanks!
Acked-by Chris Ball <[email protected]>
Hi Chris,
OK, I picked this up in my tree.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
PATCH v6 1/1 SDHCI: S3C: Use generic clock names for sdhci bus clock options
In reply to Rajeshwari ShindeQuoted 6 lines · Rajeshwari Shinde
This patch modifies the driver to stop depending on the clock names being passed from the platform and switch over to bus clock lookup using generic clock names.
V6 Changes:
Changed sprintf to snprintf as suggested by Chris Ball.
The above two lines can be removed from the commit message.
Quoted 11 lines
Signed-off-by Rajeshwari Shinde <[email protected]>---
?drivers/mmc/host/sdhci-s3c.c | ? ?7 ++-----
?1 files changed, 2 insertions(+), 5 deletions(-)drivers/mmc/host/sdhci-s3c.c +0
-0@@ -435,14 +435,11 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
[...]