Skip to contentSkip to conversation

rtc, rv3029: add support for trickle charger

PATCH Superseded Heiko Schocher 3 participants 9 messages Mar 28, 2011 – Apr 25, 2011 Real time clock (RTC)

lore
Share & tools
lore

Heiko Schocher

author
#0 lore raw

cover rtc, rv3029: add support for trickle charger

This patchseries adds trickle charger support for the RTC RV3029 and add it to the existing digsy_mtc board (rev5 boards only).

checkpatch says:

total: 0 errors, 0 warnings, 117 lines checked

20110328/0001-rtc-rv3029-add-trickle-charger-support.patch has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 7 lines checked

20110328/0002-mpc52xx-digsy_mtc-add-trickle-charger-support-for-re.patch has no obvious style problems and is ready for submission.

Heiko Schocher (2):
rtc, rv3029: add trickle charger support.
mpc52xx, digsy_mtc: add trickle charger support for rev5 boards.

 README                      |    2 +
 drivers/rtc/rv3029.c        |   87 +++++++++++++++++++++++++++++++++++++++++++
 include/configs/digsy_mtc.h |    1 +
 3 files changed, 90 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.4
author
#1 lore raw

PATCH 1/2 rtc, rv3029: add trickle charger support.

Signed-off-by Heiko Schocher <[email protected]>
---
 README               |    2 +
 drivers/rtc/rv3029.c |   87 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 0 deletions(-)
README +2 -0
index 21cd71b..45b32e7 100644
@@ -743,6 +743,8 @@ The following options need to be configured:
 		CONFIG_RTC_ISL1208	- use Intersil ISL1208 RTC
 		CONFIG_RTC_MAX6900	- use Maxim, Inc. MAX6900 RTC
 		CONFIG_SYS_RTC_DS1337_NOOSC	- Turn off the OSC output for DS1337
+		CONFIG_SYS_RV3029_TCR	- enable trickle charger on
+					  RV3029 RTC.
 
 		Note that if the RTC uses I2C, then the I2C interface
 		must also be configured. See I2C Support, below.
drivers/rtc/rv3029.c +87 -0

109 lines not on this page · raw message

Signature · 1 line
1.7.4
author
#2 lore raw

PATCH 2/2 mpc52xx, digsy_mtc: add trickle charger support for rev5 boards.

In reply to Heiko Schocher
Signed-off-by Heiko Schocher <[email protected]>
---
 include/configs/digsy_mtc.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/digsy_mtc.h +1 -0
index e7fd0f7..7e50a86 100644
@@ -252,6 +252,7 @@
 #if defined(CONFIG_DIGSY_REV5)
 #define CONFIG_SYS_I2C_RTC_ADDR	0x56
 #define CONFIG_RTC_RV3029
+#define CONFIG_SYS_RV3029_TCR
 #else
 #define CONFIG_RTC_DS1337
 #define CONFIG_SYS_I2C_RTC_ADDR	0x68
Signature · 1 line
1.7.4
author
#3 lore raw

v2 cover rtc, rv3029: add support for trickle charger

In reply to Heiko Schocher

This patchseries adds trickle charger support for the RTC RV3029 and add it to the existing digsy_mtc board (rev5 boards only).

changes for v2:
- set CONFIG_SYS_RV3029_TCR to 5k Ohm

checkpatch says:

total: 0 errors, 0 warnings, 117 lines checked

20110328_2/0001-rtc-rv3029-add-trickle-charger-support.patch has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 8 lines checked

20110328_2/0002-mpc52xx-digsy_mtc-add-trickle-charger-support-for-re.patch has no obvious style problems and is ready for submission.

Heiko Schocher (2):
rtc, rv3029: add trickle charger support.
mpc52xx, digsy_mtc: add trickle charger support for rev5 boards.

 README                      |    2 +
 drivers/rtc/rv3029.c        |   87 +++++++++++++++++++++++++++++++++++++++++++
 include/configs/digsy_mtc.h |    2 +
 3 files changed, 91 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.4
author
#4 lore raw

PATCH v2 1/2 rtc, rv3029: add trickle charger support.

Signed-off-by Heiko Schocher <[email protected]>
---
 README               |    2 +
 drivers/rtc/rv3029.c |   87 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 0 deletions(-)
README +2 -0
index 21cd71b..45b32e7 100644
@@ -743,6 +743,8 @@ The following options need to be configured:
 		CONFIG_RTC_ISL1208	- use Intersil ISL1208 RTC
 		CONFIG_RTC_MAX6900	- use Maxim, Inc. MAX6900 RTC
 		CONFIG_SYS_RTC_DS1337_NOOSC	- Turn off the OSC output for DS1337
+		CONFIG_SYS_RV3029_TCR	- enable trickle charger on
+					  RV3029 RTC.
 
 		Note that if the RTC uses I2C, then the I2C interface
 		must also be configured. See I2C Support, below.
drivers/rtc/rv3029.c +87 -0

109 lines not on this page · raw message

Signature · 1 line
1.7.4
Applied
#5 lore raw

PATCH v2 1/2 rtc, rv3029: add trickle charger support.

Dear Heiko Schocher,

Quoted 5 lines · In message <[email protected]> you wrote:
Signed-off-by Heiko Schocher <[email protected]>
---
 README               |    2 +
 drivers/rtc/rv3029.c |   87 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 0 deletions(-)

Applied,t hanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
        Ordnung ist die Lust der Vernunft,
        aber Unordnung die Wonne der Phantasie         - Paul Claudel
author
#6 lore raw

PATCH v2 2/2 mpc52xx, digsy_mtc: add trickle charger support for rev5 boards.

In reply to Heiko Schocher
Signed-off-by Heiko Schocher <[email protected]>

---
changes for v2:
- set CONFIG_SYS_RV3029_TCR to 5k Ohm

 include/configs/digsy_mtc.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/configs/digsy_mtc.h +2 -0
index e7fd0f7..f1613c7 100644
@@ -252,6 +252,8 @@
 #if defined(CONFIG_DIGSY_REV5)
 #define CONFIG_SYS_I2C_RTC_ADDR	0x56
 #define CONFIG_RTC_RV3029
+/* Enable 5k Ohm trickle charge resistor */
+#define CONFIG_SYS_RV3029_TCR	0x20
 #else
 #define CONFIG_RTC_DS1337
 #define CONFIG_SYS_I2C_RTC_ADDR	0x68
Signature · 1 line
1.7.4
Applied
#7 lore raw

PATCH v2 2/2 mpc52xx, digsy_mtc: add trickle charger support for rev5 boards.

Dear Heiko Schocher,

Quoted 8 lines · In message <[email protected]> you wrote:
Signed-off-by Heiko Schocher <[email protected]>

---
changes for v2:
- set CONFIG_SYS_RV3029_TCR to 5k Ohm

 include/configs/digsy_mtc.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I used to be indecisive, now I'm not sure.
#8 lore raw

v2 cover rtc, rv3029: add support for trickle charger

In reply to Heiko Schocher

Hallo Heiko,

Quoted 16 lines

This patchseries adds trickle charger support for the RTC RV3029 and add it to the existing digsy_mtc board (rev5 boards only).

changes for v2:
- set CONFIG_SYS_RV3029_TCR to 5k Ohm

checkpatch says:

total: 0 errors, 0 warnings, 117 lines checked

20110328_2/0001-rtc-rv3029-add-trickle-charger-support.patch has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 8 lines checked

20110328_2/0002-mpc52xx-digsy_mtc-add-trickle-charger-support-for-re.patch has no obvious style problems and is ready for submission.

Quoted 8 lines

Heiko Schocher (2):
rtc, rv3029: add trickle charger support.
mpc52xx, digsy_mtc: add trickle charger support for rev5 boards.

 README                      |    2 +
 drivers/rtc/rv3029.c        |   87 +++++++++++++++++++++++++++++++++++++++++++
 include/configs/digsy_mtc.h |    2 +
 3 files changed, 91 insertions(+), 0 deletions(-)

Looks good, so

Acked-by Detlev Zundel <[email protected]>

Cheers
Detlev

Signature · 7 lines
It's like manually inflatable airbags -- people will never
think to use it in time to actually get any help from it.
             -- Miles Bader in <[email protected]>
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de