mmc: Fix mmc_send_status()
PATCH v2 1/1 mmc: Fix mmc_send_status()
The mmc_send_status() function sets cmd.arg = 0. That's incorrect, so fix it.
--- drivers/mmc/mmc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
V2: Take SPI mode into account
drivers/mmc/mmc.c +2 -1
@@ -115,7 +115,8 @@ int mmc_send_status(struct mmc *mmc, int timeout) cmd.cmdidx =MMC_CMD_SEND_STATUS ; cmd.resp_type =MMC_RSP_R1 ; - cmd.cmdarg =0 ; +if (!mmc_host_is_spi (mmc)) + cmd.cmdarg = mmc->rca <<16 ; cmd.flags =0 ; do {
Signature · 1 line
1.7.5.4
PATCH v2 1/1 mmc: Fix mmc_send_status()
Hi Marek,
Quoted 1 line
The
mmc_send_status()function sets cmd.arg = 0. That's incorrect, so fix it.
Can you please use the --in-reply-to option of git-send-email (it prompts for it when run interactively) to preserve threading for superceding patches? Thanks!
It would also be nice if you included the comment from your other mail in the changelog, i.e. what problem/bug under which circumstances this actually fixes.
Thanks
Detlev
Signature · 9 lines
To summarize: It is a well known and lamented fact that those people who
most want to rule people are, ipso facto, those least suited to do it.
To summarize the summary: anyone who is capable of getting themselves made
President should on no account be allowed to do the job.
-- The Hitchhikers Guide To The Galaxy
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.dePATCH v2 1/1 mmc: Fix mmc_send_status()
In reply to Marek VasutHi Marek,
Quoted 24 lines · Marek Vasut
The
mmc_send_status()function sets cmd.arg = 0. That's incorrect, so fix it.Signed-off-by Marek Vasut <[email protected]>---
?drivers/mmc/mmc.c | ? ?3 ++-
?1 files changed, 2 insertions(+), 1 deletions(-)V2: Take SPI mode into account
drivers/mmc/mmc.c +2
-2@@ -115,7 +115,8 @@ int mmc_send_status(struct mmc *mmc, int timeout) ? ? ? ?cmd.cmdidx = MMC_CMD_SEND_STATUS; ? ? ? ?cmd.resp_type = MMC_RSP_R1; - ? ? ? cmd.cmdarg = 0; + ? ? ? if (!mmc_host_is_spi(mmc)) + ? ? ? ? ? ? ? cmd.cmdarg = mmc->rca << 16; ? ? ? ?cmd.flags = 0; ? ? ? ?do { --
Quoted 2 lines
1.7.5.4
This patch works fine on my MMP3 board.
Best regards,
Lei
PATCH v2 1/1 mmc: Fix mmc_send_status()
Hi Lei,
Quoted 25 lines
Hi Marek,
Quoted 22 lines · Marek Vasut
The
mmc_send_status()function sets cmd.arg = 0. That's incorrect, so fix it.Signed-off-by Marek Vasut <[email protected]>---
?drivers/mmc/mmc.c | ? ?3 ++-
?1 files changed, 2 insertions(+), 1 deletions(-)V2: Take SPI mode into account
drivers/mmc/mmc.c +2
-1@@ -115,7 +115,8 @@ int mmc_send_status(struct mmc *mmc, int timeout) ? ? ? ?cmd.cmdidx = MMC_CMD_SEND_STATUS; ? ? ? ?cmd.resp_type = MMC_RSP_R1; - ? ? ? cmd.cmdarg = 0; + ? ? ? if (!mmc_host_is_spi(mmc)) + ? ? ? ? ? ? ? cmd.cmdarg = mmc->rca << 16; ? ? ? ?cmd.flags = 0;
Quoted 6 lines
Quoted 4 lines
drivers/mmc/mmc.c +0
-1? ? ? ?do { --1.7.5.4
This patch works fine on my MMP3 board.
We have a formal way of saying that which as a bonus gets you into the commit-logs ;)
Cheers
Detlev
Signature · 7 lines
I shall be telling this with a sigh / Somewhere ages and ages hence: / Two roads diverged in a wood, and I-- / I took the one less traveled by, / And that has made all the difference. -- Robert Frost -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
PATCH v2 1/1 mmc: Fix mmc_send_status()
Quoted 8 lines · Detlev Zundel
Hi Lei,
Quoted 6 lines
Hi Marek,
Quoted 3 lines · Marek Vasut
The
mmc_send_status()function sets cmd.arg = 0. That's incorrect, so fix it.Signed-off-by Marek Vasut <[email protected]>
Applied (with lei wen's "tested-by").
Thanks,
Andy