Skip to contentSkip to conversation

mmc: meson-gx: set max block count

PATCH Superseded Heiner Kallweit 2 participants 2 messages Jan 28, 2017 – Jan 30, 2017

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mmc: meson-gx: set max block count

So far max_blk_count isn't set what results in a default of value 8 to be used (PAGE_SIZE / block size).

---
v2:
- block length field has 9 bits, so set max_blk_count to 2^9-1 = 511
- in addition set max_req_size because max_blk_count is also limited by max_req_size / block_size

---
 drivers/mmc/host/meson-gx-mmc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mmc/host/meson-gx-mmc.c +2 -0
index 83361f1f..d4d174ed 100644
@@ -810,6 +810,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
 		goto free_host;
 	}
 
+	mmc->max_blk_count = CMD_CFG_LENGTH_MASK;
+	mmc->max_req_size = mmc->max_blk_count * mmc->max_blk_size;
 	mmc->ops = &meson_mmc_ops;
 	mmc_add_host(mmc);
 
Signature · 1 line
2.11.0
maintainer
#1 lore raw

PATCH v2 1/1 mmc: meson-gx: set max block count

Quoted 2 lines · Heiner Kallweit

So far max_blk_count isn't set what results in a default of value 8 to be used (PAGE_SIZE / block size).

This describes the problem...

Quoted 6 lines

---
v2:
- block length field has 9 bits, so set max_blk_count to 2^9-1 = 511
- in addition set max_req_size because max_blk_count is also limited by max_req_size / block_size

... and this part describes the fix, so should also be in the changelog.

with an updated changelog, feel free to add:

Kevin

Quoted 16 lines
---
 drivers/mmc/host/meson-gx-mmc.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mmc/host/meson-gx-mmc.c +2 -0
index 83361f1f..d4d174ed 100644
@@ -810,6 +810,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
 		goto free_host;
 	}
 
+	mmc->max_blk_count = CMD_CFG_LENGTH_MASK;
+	mmc->max_req_size = mmc->max_blk_count * mmc->max_blk_size;
 	mmc->ops = &meson_mmc_ops;
 	mmc_add_host(mmc);