Skip to contentSkip to conversation

let 2.5.51 build

PATCH In review Thierry Vignaud 2 participants 4 messages Dec 11, 2002 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 let 2.5.51 build

this patch enable 2.5.51 kernel to build without sequencer support :

fix compiling without sequencer support

sound/synth/Makefile renamed from sound/synth/Makefile.tv +1 -1
@@ -12,8 +12,8 @@
 obj-$(CONFIG_SND_TRIDENT) += snd-util-mem.o
 ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
   obj-$(CONFIG_SND_SBAWE) += snd-util-mem.o
+obj-$(CONFIG_SND) += emux/
 endif
 
-obj-$(CONFIG_SND) += emux/
 
 include $(TOPDIR)/Rules.make
#1 lore raw

At Wed, 11 Dec 2002 10:51:05 +0100,

Quoted 3 lines · Thierry Vignaud

[1 <text/plain (7bit)>]
this patch enable 2.5.51 kernel to build without sequencer support :

hmm, applying this is surely harmless but i still don't figure out why this fixes the bug. synth/emux/Makefile is:

snd-emux-synth-objs := emux.o emux_synth.o emux_seq.o emux_nrpn.o \
emux_effect.o emux_proc.o soundfont.o
ifeq ($(CONFIG_SND_SEQUENCER_OSS),y)
snd-emux-synth-objs += emux_oss.o
endif

# Toplevel Module Dependency
ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
obj-$(CONFIG_SND_SBAWE) += snd-emux-synth.o
obj-$(CONFIG_SND_EMU10K1) += snd-emux-synth.o
endif

and if $CONFIG_SND_SEQUENCER is n, snd-emux-synth.o will be never compiled nor built-in...

Takashi

Quoted 5 lines

[2 alsa-fix-compile.diff <text/x-patch (7bit)>]
fix compiling without sequencer support

sound/synth/Makefile line 19

Quoted 9 lines
sound/synth/Makefile renamed from sound/synth/Makefile.tv +1 -1
@@ -12,8 +12,8 @@
 obj-$(CONFIG_SND_TRIDENT) += snd-util-mem.o
 ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
   obj-$(CONFIG_SND_SBAWE) += snd-util-mem.o
+obj-$(CONFIG_SND) += emux/
 endif
 
-obj-$(CONFIG_SND) += emux/
 
 include $(TOPDIR)/Rules.make

-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/

#2 lore raw
Quoted 11 lines · Takashi Iwai
Quoted 1 line

this patch enable 2.5.51 kernel to build without sequencer support :

hmm, applying this is surely harmless but i still don't figure out why this fixes the bug. synth/emux/Makefile is:

snd-emux-synth-objs := emux.o emux_synth.o emux_seq.o emux_nrpn.o \
emux_effect.o emux_proc.o soundfont.o
ifeq ($(CONFIG_SND_SEQUENCER_OSS),y)
snd-emux-synth-objs += emux_oss.o
endif

Quoted 8 lines

# Toplevel Module Dependency
ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
obj-$(CONFIG_SND_SBAWE) += snd-emux-synth.o
obj-$(CONFIG_SND_EMU10K1) += snd-emux-synth.o
endif

and if $CONFIG_SND_SEQUENCER is n, snd-emux-synth.o will be never compiled nor built-in...

hummmm. must be some sort of "too late in the night to compile a kernel" workaround for a broken make rule (was not able to build emux/built-in.o if i remember right)

so you can just discard this patch

-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/

#3 lore raw

At Wed, 11 Dec 2002 16:51:23 +0100,

Quoted 20 lines · Thierry Vignaud
Quoted 17 lines · Takashi Iwai
Quoted 1 line

this patch enable 2.5.51 kernel to build without sequencer support :

hmm, applying this is surely harmless but i still don't figure out why this fixes the bug. synth/emux/Makefile is:

snd-emux-synth-objs := emux.o emux_synth.o emux_seq.o emux_nrpn.o \
emux_effect.o emux_proc.o soundfont.o
ifeq ($(CONFIG_SND_SEQUENCER_OSS),y)
snd-emux-synth-objs += emux_oss.o
endif

# Toplevel Module Dependency
ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
obj-$(CONFIG_SND_SBAWE) += snd-emux-synth.o
obj-$(CONFIG_SND_EMU10K1) += snd-emux-synth.o
endif

Quoted 6 lines
Quoted 2 lines

and if $CONFIG_SND_SEQUENCER is n, snd-emux-synth.o will be never compiled nor built-in...

hummmm. must be some sort of "too late in the night to compile a kernel" workaround for a broken make rule (was not able to build emux/built-in.o if i remember right)

looking at the thread on lkml, it seems that we need at least one non-empty obj-* definition. changing synth/emux/Makefile is also a hack...

anyway your patch is a workaround until Makefile.kbuild is fixed. i'll apply it.

Takashi

-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/