Skip to contentSkip to conversation

Amlogic fixes for v4.10-rc

PATCH New Kevin Hilman 3 participants 6 messages Jan 20, 2017 – Jan 27, 2017

Subsystems (2)
lore
Share & tools
lore

Kevin Hilman

author maintainer
#0 lore raw

cover Amlogic fixes for v4.10-rc

Arnd, Olof,

A couple more Amlogic fixes for the -rc cycle. The reserved memory is updated after some debate/discussion of the first version. This one has and ack/review from Andreas who objected to the first version.

Kevin

Jerome Brunet (1):
ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage

Neil Armstrong (1):
ARM64: dts: meson-gx: Add firmware reserved memory zones

 arch/arm64/boot/dts/amlogic/meson-gx.dtsi           | 18 ++++++++++++++++++
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 12 ++++++++++++
 2 files changed, 30 insertions(+)
Signature · 1 line
2.9.3
author maintainer
#1 lore raw

PATCH 1/2 ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage

From: Jerome Brunet <[email protected]>

OdroidC2 GbE link breaks under heavy tx transfer. This happens even if the MAC does not enable Energy Efficient Ethernet (No Low Power state Idle on the Tx path). The problem seems to come from the phy Rx path, entering the LPI state.

Disabling EEE advertisement on the phy prevent this feature to be negociated with the link partner and solve the issue.

---
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +12 -0
index 5d28e1cdc998..c59403adb387 100644
@@ -151,6 +151,18 @@
 	status = "okay";
 	pinctrl-0 = <&eth_rgmii_pins>;
 	pinctrl-names = "default";
+	phy-handle = <&eth_phy0>;
+
+	mdio {
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		eth_phy0: ethernet-phy at 0 {
+			reg = <0>;
+			eee-broken-1000t;
+		};
+	};
 };
 
 &ir {
Signature · 1 line
2.9.3
author maintainer
#2 lore raw

PATCH 2/2 ARM64: dts: meson-gx: Add firmware reserved memory zones

In reply to Kevin Hilman

From: Neil Armstrong <[email protected]>

The Amlogic Meson GXBB/GXL/GXM secure monitor uses part of the memory space, this patch adds these reserved zones.

Without such reserved memory zones, running the following stress command :

$ stress-ng --vm 16 --vm-bytes 128M --timeout 10s
multiple times:

Could lead to the following kernel crashes :

[   46.937975] Bad mode in Error handler detected on CPU1, code 0xbf000000 -- SError
...
[   47.058536] Internal error: Attempting to execute userspace memory: 8600000f [#3] PREEMPT SMP

...
Instead of the OOM killer.

Fixes 4f24eda8401f ("ARM64: dts: Prepare configs for Amlogic Meson GXBaby")
[khilman: added Fixes tag, added _reserved and unit addresses]
---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gx.dtsi +18 -0
index eada0b58ba1c..0cbe24b49710 100644
@@ -55,6 +55,24 @@
 	#address-cells = <2>;
 	#size-cells = <2>;
 
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		/* 16 MiB reserved for Hardware ROM Firmware */
+		hwrom_reserved: hwrom at 0 {
+			reg = <0x0 0x0 0x0 0x1000000>;
+			no-map;
+		};
+
+		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
+		secmon_reserved: secmon at 10000000 {
+			reg = <0x0 0x10000000 0x0 0x200000>;
+			no-map;
+		};
+	};
+
 	cpus {
 		#address-cells = <0x2>;
 		#size-cells = <0x0>;
Signature · 1 line
2.9.3
#3 lore raw

cover Amlogic fixes for v4.10-rc

In reply to Kevin Hilman

Kevin,

Am 20.01.2017 um 17:20 schrieb Kevin Hilman:

Quoted 3 lines

A couple more Amlogic fixes for the -rc cycle. The reserved memory is updated after some debate/discussion of the first version. This one has and ack/review from Andreas who objected to the first version.

Is it intentional that this is not a PULL?

Regards,
Andreas

Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
author maintainer
#4 lore raw

cover Amlogic fixes for v4.10-rc

Quoted 8 lines · Andreas F?rber

Kevin,

Am 20.01.2017 um 17:20 schrieb Kevin Hilman:

Quoted 3 lines

A couple more Amlogic fixes for the -rc cycle. The reserved memory is updated after some debate/discussion of the first version. This one has and ack/review from Andreas who objected to the first version.

Is it intentional that this is not a PULL?

Yes. For one or two patches, arm-soc maintainers are happy to take patches. And in this case, it was especially intentional because these have a dependency on stuff already in arm-soc fixes, so I wanted them to be applied directly.

Kevin

#5 lore raw

cover Amlogic fixes for v4.10-rc

In reply to Kevin Hilman
Quoted 6 lines · CET Kevin Hilman

Arnd, Olof,

A couple more Amlogic fixes for the -rc cycle. The reserved memory is updated after some debate/discussion of the first version. This one has and ack/review from Andreas who objected to the first version.

Applied both to fixes, thanks!

Arnd