Skip to contentSkip to conversation

CONFIG_INET depend on CONFIG_SYSCTL

PATCH In review Yoshinori Sato 2 participants 5 messages Jun 12, 2007 – Jun 22, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CONFIG_INET depend on CONFIG_SYSCTL

It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y. In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.

net/Kconfig +1 -0
index f3de729..2e9a885 100644
@@ -34,6 +34,7 @@ source "net/iucv/Kconfig"
 
 config INET
 	bool "TCP/IP networking"
+	select SYSCTL
 	---help---
 	  These are the protocols used on the Internet and on most local
 	  Ethernets. It is highly recommended to say Y here (this will enlarge
Signature · 2 lines
Yoshinori Sato
<[email protected]>
maintainer
#1 lore raw

From: Yoshinori Sato <[email protected]>
Date: Tue, 12 Jun 2007 16:38:55 +0900

Quoted 4 lines

It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y. In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.

1) Please post networking patches to [email protected] which has been added to the CC:

2) It is much better to add the appropriate CONFIG_SYSCTL ifdefs to the INET code than to force it on for everyone.

#2 lore raw

At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),

Quoted 11 lines · David Miller

From: Yoshinori Sato <[email protected]>
Date: Tue, 12 Jun 2007 16:38:55 +0900

Quoted 4 lines

It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y. In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.

1) Please post networking patches to [email protected] which has been added to the CC:

It was understood.

Quoted 2 lines

2) It is much better to add the appropriate CONFIG_SYSCTL ifdefs to the INET code than to force it on for everyone.

It examined that, but many corrections become necessary.

Signature · 2 lines
Yoshinori Sato
<[email protected]>
maintainer
#3 lore raw

From: Yoshinori Sato <[email protected]>
Date: Wed, 13 Jun 2007 14:59:16 +0900

Quoted 7 lines

At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),

Quoted 2 lines · David Miller

2) It is much better to add the appropriate CONFIG_SYSCTL ifdefs to the INET code than to force it on for everyone.

It examined that, but many corrections become necessary.

I understand, but embedded people will not be happy that SYSFS is a requirement for IPV4 networking. Every little bit of space savings matters for them.

#4 lore raw

At Tue, 12 Jun 2007 23:05:45 -0700 (PDT),

Quoted 7 lines · David Miller

From: Yoshinori Sato <[email protected]>
Date: Wed, 13 Jun 2007 14:59:16 +0900

Quoted 3 lines

At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),
David Miller wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

2) It is much better to add the appropriate CONFIG_SYSCTL ifdefs to the INET code than to force it on for everyone.

It examined that, but many corrections become necessary.

I understand, but embedded people will not be happy that SYSFS is a requirement for IPV4 networking. Every little bit of space savings matters for them.

A reply became late, sorry.

I do not check it in detail, but there seem to be part a few depending SYSFS.
I need to check whether can separate a SYSFS depending part.

It may take time, but tries to check it.

Quoted 5 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Yoshinori Sato
<[email protected]>