Skip to contentSkip to conversation

irqdomain: fix typo in IRQ_BITMAP_BITS definition

PATCH In review Andreas Schwab 3 participants 3 messages Apr 19, 2012 IRQ

lore
Share & tools
lore

Andreas Schwab

author
#0 lore raw

PATCH 1/1 irqdomain: fix typo in IRQ_BITMAP_BITS definition

8196 is an odd number, change it to the intended 8192.

Signed-off-by Andreas Schwab <[email protected]>

---
Shouldn't it actually be just 8192 or maybe max(NR_IRQS, 8192)?

 kernel/irq/internals.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/internals.h +1 -1
index 8e5c56b..6430d0f 100644
@@ -8,7 +8,7 @@
 #include <linux/irqdesc.h>
 
 #ifdef CONFIG_SPARSE_IRQ
-# define IRQ_BITMAP_BITS	(NR_IRQS + 8196)
+# define IRQ_BITMAP_BITS	(NR_IRQS + 8192)
 #else
 # define IRQ_BITMAP_BITS	NR_IRQS
 #endif
Signature · 7 lines
1.7.10


-- 
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
#1 lore raw
Quoted 5 lines · Andreas Schwab

8196 is an odd number, change it to the intended 8192.

Signed-off-by Andreas Schwab <[email protected]>

---
Shouldn't it actually be just 8192 or maybe max(NR_IRQS, 8192)?

The number is completely arbitrary. It doesn't actually matter.

g.

#2 lore raw
Quoted 8 lines · Grant Likely
Quoted 5 lines · Andreas Schwab

8196 is an odd number, change it to the intended 8192.

Signed-off-by Andreas Schwab <[email protected]>

---
Shouldn't it actually be just 8192 or maybe max(NR_IRQS, 8192)?

The number is completely arbitrary. It doesn't actually matter.

Right, it just makes sure that the bitmap is way larger than the NR_IRQS value, so we can deal with all the dynamic allocated interrupts.

Thanks,

tglx