Skip to contentSkip to conversation

Meson (32-bit) multi_v7_defconfig updates

PATCH New Martin Blumenstingl 3 participants 7 messages Jun 11, 2017 – Jun 16, 2017

Subsystems (2)
Arm (32-bit) Arm/Amlogic Meson SoC support
lore
Share & tools
lore

Martin Blumenstingl

author reviewer
#0 lore raw

cover Meson (32-bit) multi_v7_defconfig updates

This enables the following drivers which are supported on Meson8 and Meson8b (as well as Meson8m2):
- Meson USB2 PHY driver (USB controller support is provided by dwc2, which is already enabled)
- Meson PWM driver (used to dim LEDs and generate the 32.768 kHz LPO clock for the SDIO wifi modules)
- the generic PWM clock driver (for the 32.768 kHz LPO clock for the SDIO wifi modules)

I am not sure if these patches will go through Kevin's Amlogic tree or through some other tree. However, these should be independent from anything else, so it's just a matter of preference through which tree they go.

Martin Blumenstingl (3):
ARM: multi_v7_defconfig: enable the Amlogic Meson USB2 PHY driver
ARM: multi_v7_defconfig: enable the Meson PWM controller
ARM: multi_v7_defconfig: enable the PWM clock driver

 arch/arm/configs/multi_v7_defconfig | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.13.1
author reviewer
#1 lore raw

PATCH 1/3 ARM: multi_v7_defconfig: enable the Amlogic Meson USB2 PHY driver

Signed-off-by Martin Blumenstingl <[email protected]>
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/multi_v7_defconfig +1 -0
index 2685e03600b1..49f038dcdd7c 100644
@@ -888,6 +888,7 @@ CONFIG_PHY_BERLIN_SATA=y
 CONFIG_PHY_ROCKCHIP_DP=m
 CONFIG_PHY_ROCKCHIP_USB=y
 CONFIG_PHY_QCOM_APQ8064_SATA=m
+CONFIG_PHY_MESON8B_USB2=y
 CONFIG_PHY_MIPHY28LP=y
 CONFIG_PHY_RCAR_GEN2=m
 CONFIG_PHY_STIH407_USB=y
Signature · 1 line
2.13.1
author reviewer
#2 lore raw

PATCH 2/3 ARM: multi_v7_defconfig: enable the Meson PWM controller

In reply to Martin Blumenstingl

This enables the Amlogic Meson PWM controller. It is used for a dimmable LED on some devices. Additionally some devices use it to generate the 32.768 kHz (low power oscillator) clock.

Signed-off-by Martin Blumenstingl <[email protected]>
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/multi_v7_defconfig +1 -0
index 49f038dcdd7c..abbe288a5134 100644
@@ -870,6 +870,7 @@ CONFIG_PWM_ATMEL=m
 CONFIG_PWM_ATMEL_HLCDC_PWM=m
 CONFIG_PWM_ATMEL_TCB=m
 CONFIG_PWM_FSL_FTM=m
+CONFIG_PWM_MESON=y
 CONFIG_PWM_RENESAS_TPU=y
 CONFIG_PWM_ROCKCHIP=m
 CONFIG_PWM_SAMSUNG=m
Signature · 1 line
2.13.1
author reviewer
#3 lore raw

PATCH 3/3 ARM: multi_v7_defconfig: enable the PWM clock driver

In reply to Martin Blumenstingl

This enables the PWM clock driver (using the common clock and PWM frameworks) which is used on many devices with Amlogic Meson SoCs to generate the 32.768 kHz clock for the wireless SDIO chip.

Signed-off-by Martin Blumenstingl <[email protected]>
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/multi_v7_defconfig +1 -0
index abbe288a5134..a2cd88d7f56e 100644
@@ -835,6 +835,7 @@ CONFIG_STAGING_BOARD=y
 CONFIG_CROS_EC_CHARDEV=m
 CONFIG_COMMON_CLK_MAX77686=y
 CONFIG_COMMON_CLK_MAX77802=m
+CONFIG_COMMON_CLK_PWM=y
 CONFIG_COMMON_CLK_RK808=m
 CONFIG_COMMON_CLK_S2MPS11=m
 CONFIG_APQ_MMCC_8084=y
Signature · 1 line
2.13.1
#4 lore raw

cover Meson (32-bit) multi_v7_defconfig updates

In reply to Martin Blumenstingl
Quoted 16 lines · Martin Blumenstingl

This enables the following drivers which are supported on Meson8 and Meson8b (as well as Meson8m2):
- Meson USB2 PHY driver (USB controller support is provided by dwc2, which is already enabled)
- Meson PWM driver (used to dim LEDs and generate the 32.768 kHz LPO clock for the SDIO wifi modules)
- the generic PWM clock driver (for the 32.768 kHz LPO clock for the SDIO wifi modules)

I am not sure if these patches will go through Kevin's Amlogic tree or through some other tree. However, these should be independent from anything else, so it's just a matter of preference through which tree they go.

Quoted 8 lines

Martin Blumenstingl (3):
ARM: multi_v7_defconfig: enable the Amlogic Meson USB2 PHY driver
ARM: multi_v7_defconfig: enable the Meson PWM controller
ARM: multi_v7_defconfig: enable the PWM clock driver

 arch/arm/configs/multi_v7_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Hi Martin,

Isn't it better to have these as modules like for the ARM64 counterpart ?

Thanks,
Neil

author reviewer
#5 lore raw

cover Meson (32-bit) multi_v7_defconfig updates

Hi Neil,

Quoted 22 lines · Neil Armstrong
Quoted 21 lines · Martin Blumenstingl

This enables the following drivers which are supported on Meson8 and Meson8b (as well as Meson8m2):
- Meson USB2 PHY driver (USB controller support is provided by dwc2, which is already enabled)
- Meson PWM driver (used to dim LEDs and generate the 32.768 kHz LPO clock for the SDIO wifi modules)
- the generic PWM clock driver (for the 32.768 kHz LPO clock for the SDIO wifi modules)

I am not sure if these patches will go through Kevin's Amlogic tree or through some other tree. However, these should be independent from anything else, so it's just a matter of preference through which tree they go.

Martin Blumenstingl (3):
ARM: multi_v7_defconfig: enable the Amlogic Meson USB2 PHY driver
ARM: multi_v7_defconfig: enable the Meson PWM controller
ARM: multi_v7_defconfig: enable the PWM clock driver

Quoted 8 lines
Quoted 3 lines
 arch/arm/configs/multi_v7_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Hi Martin,

Isn't it better to have these as modules like for the ARM64 counterpart ?

indeed, I will look into this - thanks for the hint

PS: I will also re-check if enabling CONFIG_PHY_MESON8B_USB2 is requires, since it defaults to ARCH_MESON (which means it should default to "y" automatically, which is also why we don't have it in arch/arm64/configs/defconfig)

Regards,
Martin

maintainer
#6 lore raw

cover Meson (32-bit) multi_v7_defconfig updates

In reply to Neil Armstrong
Quoted 22 lines · Neil Armstrong
Quoted 21 lines · Martin Blumenstingl

This enables the following drivers which are supported on Meson8 and Meson8b (as well as Meson8m2):
- Meson USB2 PHY driver (USB controller support is provided by dwc2, which is already enabled)
- Meson PWM driver (used to dim LEDs and generate the 32.768 kHz LPO clock for the SDIO wifi modules)
- the generic PWM clock driver (for the 32.768 kHz LPO clock for the SDIO wifi modules)

I am not sure if these patches will go through Kevin's Amlogic tree or through some other tree. However, these should be independent from anything else, so it's just a matter of preference through which tree they go.

Martin Blumenstingl (3):
ARM: multi_v7_defconfig: enable the Amlogic Meson USB2 PHY driver
ARM: multi_v7_defconfig: enable the Meson PWM controller
ARM: multi_v7_defconfig: enable the PWM clock driver

Quoted 9 lines
Quoted 3 lines
 arch/arm/configs/multi_v7_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Hi Martin,

Isn't it better to have these as modules like for the ARM64 counterpart ?

+1 Please enable as modules wherever possible.

Thanks,

Kevin