merging splited driver back
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi,
At Mon, 19 Aug 2002 22:29:12 +0200,
Quoted 8 lines · Thierry Vignaud
snd-ens1370 and 1371're just the same driver which compilation is altered by preprocessors directives.
snd-via8232 came from via686 and some common code can still be seen.
it would be nice if the alsa team can make a unified snd-ens137[01] driver and a snd-via-common sub module used by snd-via{686,8232}.
both jobs would be relatively easy.
in fact, integration of ens137x was already done experimentally on my tree, and the change for via driver should be also small.
but the decision is different.
pro:
- merging via drivers will make the maintenance and bug-hunt easier. merging ens137x drivers makes no difference, because it's already in a source.
con:
- merging two drivers to a unified driver will increase the size.
- we may put the common stuff into lowlevel module. but the lowlevel module cannot be marked as __devinit, although this doesn't matter for modules anyway.
basically i vote for this action, but i'd like to hear the opinion from other people in this regard.
Takashi
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
Quoted 31 lines · Takashi Iwai
Hi,
At Mon, 19 Aug 2002 22:29:12 +0200,
Quoted 8 lines · Thierry Vignaud
snd-ens1370 and 1371're just the same driver which compilation is altered by preprocessors directives.
snd-via8232 came from via686 and some common code can still be seen.
it would be nice if the alsa team can make a unified snd-ens137[01] driver and a snd-via-common sub module used by snd-via{686,8232}.
both jobs would be relatively easy.
in fact, integration of ens137x was already done experimentally on my tree, and the change for via driver should be also small.but the decision is different.
pro:
- merging via drivers will make the maintenance and bug-hunt easier. merging ens137x drivers makes no difference, because it's already in a source.con:
- merging two drivers to a unified driver will increase the size.
- we may put the common stuff into lowlevel module. but the lowlevel module cannot be marked as__devinit, although this doesn't matter for modules anyway.
Quoted 2 lines
basically i vote for this action, but i'd like to hear the opinion from other people in this regard.
I don't like very much to merging of ENS1370 and ENS1371, because different codecs are used (snd-ak4531-codec and snd-ac97-codec). Sure, there is common code (MIDI UART, most of PCM routines), but I think that the final difference (separate module with common code) will be negligible, but we may do it.
VIA code may be merged.
Jaroslav
-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
At Wed, 21 Aug 2002 11:53:32 +0200 (CEST),
Quoted 34 lines · Jaroslav
Quoted 31 lines · Takashi Iwai
Hi,
At Mon, 19 Aug 2002 22:29:12 +0200,
Quoted 8 lines · Thierry Vignaud
snd-ens1370 and 1371're just the same driver which compilation is altered by preprocessors directives.
snd-via8232 came from via686 and some common code can still be seen.
it would be nice if the alsa team can make a unified snd-ens137[01] driver and a snd-via-common sub module used by snd-via{686,8232}.
both jobs would be relatively easy.
in fact, integration of ens137x was already done experimentally on my tree, and the change for via driver should be also small.but the decision is different.
pro:
- merging via drivers will make the maintenance and bug-hunt easier. merging ens137x drivers makes no difference, because it's already in a source.con:
- merging two drivers to a unified driver will increase the size.
- we may put the common stuff into lowlevel module. but the lowlevel module cannot be marked as__devinit, although this doesn't matter for modules anyway.
Quoted 5 lines
Quoted 2 lines
basically i vote for this action, but i'd like to hear the opinion from other people in this regard.
I don't like very much to merging of ENS1370 and ENS1371, because different codecs are used (snd-ak4531-codec and snd-ac97-codec).
ah, yes, that's not beautiful to have two codec modules for one driver.
Quoted 4 lines
Sure,
there is common code (MIDI UART, most of PCM routines), but I think that the final difference (separate module with common code) will be negligible, but we may do it.
well, then let's leave ens1370/1 as they are.
Quoted 1 line
VIA code may be merged.
yes. i'll work on this later.
Takashi
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
Quoted 6 lines · Takashi Iwai
Quoted 2 lines
I don't like very much to merging of ENS1370 and ENS1371, because different codecs are used (snd-ak4531-codec and snd-ac97-codec).
ah, yes, that's not beautiful to have two codec modules for one driver.
Quoted 6 lines
Quoted 4 lines
Sure,
there is common code (MIDI UART, most of PCM routines), but I think that the final difference (separate module with common code) will be negligible, but we may do it.well, then let's leave ens1370/1 as they are.
this would have enbling to reduce memory usage if one have both 1370 and 1371 cards, and/or reduce kernel package size :-)
Quoted 3 lines
Quoted 1 line
VIA code may be merged.
yes. i'll work on this later.
nice.
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
At Thu, 22 Aug 2002 15:41:17 +0200,
Quoted 14 lines · Thierry Vignaud
Quoted 11 lines · Takashi Iwai
Quoted 2 lines
I don't like very much to merging of ENS1370 and ENS1371, because different codecs are used (snd-ak4531-codec and snd-ac97-codec).
ah, yes, that's not beautiful to have two codec modules for one driver.
Quoted 4 lines
Sure,
there is common code (MIDI UART, most of PCM routines), but I think that the final difference (separate module with common code) will be negligible, but we may do it.
Quoted 4 lines
Quoted 1 line
well, then let's leave ens1370/1 as they are.
this would have enbling to reduce memory usage if one have both 1370 and 1371 cards, and/or reduce kernel package size :-)
the probability of former case is not so high, i guess :)
Takashi
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
Quoted 13 lines · Thierry Vignaud
Quoted 11 lines · Takashi Iwai
Quoted 2 lines
I don't like very much to merging of ENS1370 and ENS1371, because different codecs are used (snd-ak4531-codec and snd-ac97-codec).
ah, yes, that's not beautiful to have two codec modules for one driver.
Quoted 4 lines
Sure,
there is common code (MIDI UART, most of PCM routines), but I think that the final difference (separate module with common code) will be negligible, but we may do it.
Quoted 4 lines
Quoted 1 line
well, then let's leave ens1370/1 as they are.
this would have enbling to reduce memory usage if one have both 1370 and 1371 cards,
It's questionable, because every segments are aligned to 4kB on i386 (8kb on alphas), so you can reach same memory consumption.
Quoted 1 line
and/or reduce kernel package size :-)
It's probably only valid reason, but it does not change anything from the maintaince view. Anyway, as I wrote, separating code to a common module will be accepted. Patches are welcome ;-)
Jaroslav
-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
Quoted 2 lines · Jaroslav Kysela
It's questionable, because every segments are aligned to 4kB on i386 (8kb on alphas), so you can reach same memory consumption.
not if compiled in kernel core but i admit this is not a real point:-)
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390