binman: 'module' object has no attribute 'FinaliseOutputDir'

U-Boot Kevin Hilman 2 participants 8 messages May 31, 2017 – Jun 21, 2017

Share & tools

Kevin Hilman

author

2017-05-31 18:13 UTC #0 lore raw

While trying to build v2017.05 for sun5i-r8-chip (CHIP_defconfig), I get the following build error. I'm not familiar with binman, so not sure what I should be looking for.

$ CROSS_COMPILE=arm-linux-gnueabihf- make

[...]

 LD      spl/drivers/serial/built-in.o
 LD      spl/drivers/built-in.o
 LD      spl/common/built-in.o
 LD      spl/lib/built-in.o
 LD      spl/u-boot-spl

OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
MKSUNXI spl/sunxi-spl.bin
BINMAN u-boot-sunxi-with-spl.bin
binman: 'module' object has no attribute 'FinaliseOutputDir' Makefile:1107: recipe for target 'u-boot-sunxi-with-spl.bin' failed
make: *** [u-boot-sunxi-with-spl.bin] Error 1

If it matters, compiler is: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)

Kevin

Simon Glass

2017-05-31 19:19 UTC #1 lore raw

Hi Kevin,

Quoted 22 lines · Kevin Hilman

While trying to build v2017.05 for sun5i-r8-chip (CHIP_defconfig), I get the following build error. I'm not familiar with binman, so not sure what I should be looking for.
$ CROSS_COMPILE=arm-linux-gnueabihf- make
[...]
 LD      spl/drivers/serial/built-in.o
 LD      spl/drivers/built-in.o
 LD      spl/common/built-in.o
 LD      spl/lib/built-in.o
 LD      spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
MKSUNXI spl/sunxi-spl.bin
BINMAN u-boot-sunxi-with-spl.bin
binman: 'module' object has no attribute 'FinaliseOutputDir' Makefile:1107: recipe for target 'u-boot-sunxi-with-spl.bin' failed
make: *** [u-boot-sunxi-with-spl.bin] Error 1

Quoted 1 line

If it matters, compiler is: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)

Do you know what version of python you are using? I cannot imagine what is happening here.

Quoted 2 lines

Kevin

Regards,
Simon

Kevin Hilman

author

2017-06-01 13:55 UTC #2 lore raw

Quoted 25 lines · Simon Glass

Hi Kevin,
Quoted 22 lines · Kevin Hilman
While trying to build v2017.05 for sun5i-r8-chip (CHIP_defconfig), I get the following build error. I'm not familiar with binman, so not sure what I should be looking for.
$ CROSS_COMPILE=arm-linux-gnueabihf- make
[...]
 LD      spl/drivers/serial/built-in.o
 LD      spl/drivers/built-in.o
 LD      spl/common/built-in.o
 LD      spl/lib/built-in.o
 LD      spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
MKSUNXI spl/sunxi-spl.bin
BINMAN u-boot-sunxi-with-spl.bin
binman: 'module' object has no attribute 'FinaliseOutputDir' Makefile:1107: recipe for target 'u-boot-sunxi-with-spl.bin' failed
make: *** [u-boot-sunxi-with-spl.bin] Error 1

Quoted 4 lines

Quoted 1 line
If it matters, compiler is: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
Do you know what version of python you are using? I cannot imagine what is happening here.

$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.

Quoted 1 line

Quoted 1 line
Quoted 1 line

and fwiw, this is on Ubuntu 16.04 LTS.

Kevin

Simon Glass

2017-06-01 15:23 UTC #3 lore raw

Hi Kevin,

Quoted 31 lines · Kevin Hilman

Quoted 25 lines · Simon Glass
Hi Kevin,
Quoted 22 lines · Kevin Hilman
While trying to build v2017.05 for sun5i-r8-chip (CHIP_defconfig), I get the following build error. I'm not familiar with binman, so not sure what I should be looking for.
$ CROSS_COMPILE=arm-linux-gnueabihf- make
[...]
 LD      spl/drivers/serial/built-in.o
 LD      spl/drivers/built-in.o
 LD      spl/common/built-in.o
 LD      spl/lib/built-in.o
 LD      spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
MKSUNXI spl/sunxi-spl.bin
BINMAN u-boot-sunxi-with-spl.bin
binman: 'module' object has no attribute 'FinaliseOutputDir' Makefile:1107: recipe for target 'u-boot-sunxi-with-spl.bin' failed
make: *** [u-boot-sunxi-with-spl.bin] Error 1
Quoted 4 lines
Quoted 1 line
If it matters, compiler is: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
Do you know what version of python you are using? I cannot imagine what is happening here.

Quoted 7 lines

$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Quoted 1 line
Quoted 1 line
Quoted 1 line
and fwiw, this is on Ubuntu 16.04 LTS.

That's what I am using too. This is really mystifying. Are you able to debug the python code?

Quoted 2 lines

Kevin

Regards,
Simon

Kevin Hilman

author

2017-06-01 23:08 UTC #4 lore raw

Quoted 40 lines · Simon Glass

Hi Kevin,
Quoted 37 lines · Kevin Hilman
Quoted 25 lines · Simon Glass
Hi Kevin,
Quoted 22 lines · Kevin Hilman
While trying to build v2017.05 for sun5i-r8-chip (CHIP_defconfig), I get the following build error. I'm not familiar with binman, so not sure what I should be looking for.
$ CROSS_COMPILE=arm-linux-gnueabihf- make
[...]
 LD      spl/drivers/serial/built-in.o
 LD      spl/drivers/built-in.o
 LD      spl/common/built-in.o
 LD      spl/lib/built-in.o
 LD      spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
MKSUNXI spl/sunxi-spl.bin
BINMAN u-boot-sunxi-with-spl.bin
binman: 'module' object has no attribute 'FinaliseOutputDir' Makefile:1107: recipe for target 'u-boot-sunxi-with-spl.bin' failed
make: *** [u-boot-sunxi-with-spl.bin] Error 1
Quoted 4 lines
Quoted 1 line
If it matters, compiler is: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
Do you know what version of python you are using? I cannot imagine what is happening here.
$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Quoted 1 line
Quoted 1 line
Quoted 1 line

Quoted 4 lines

Quoted 1 line
and fwiw, this is on Ubuntu 16.04 LTS.
That's what I am using too. This is really mystifying. Are you able to debug the python code?

If you give me some pointers/suggestions, I'd be glad to, but I don't currently have much time to go wandering too deep into the uboot weeds.

Kevin

Simon Glass

2017-06-02 18:00 UTC #5 lore raw

Hi Kevin,

Quoted 42 lines · Kevin Hilman

Quoted 40 lines · Simon Glass
Hi Kevin,
Quoted 37 lines · Kevin Hilman
Quoted 25 lines · Simon Glass
Hi Kevin,
Quoted 22 lines · Kevin Hilman
While trying to build v2017.05 for sun5i-r8-chip (CHIP_defconfig), I get the following build error. I'm not familiar with binman, so not sure what I should be looking for.
$ CROSS_COMPILE=arm-linux-gnueabihf- make
[...]
 LD      spl/drivers/serial/built-in.o
 LD      spl/drivers/built-in.o
 LD      spl/common/built-in.o
 LD      spl/lib/built-in.o
 LD      spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
MKSUNXI spl/sunxi-spl.bin
BINMAN u-boot-sunxi-with-spl.bin
binman: 'module' object has no attribute 'FinaliseOutputDir' Makefile:1107: recipe for target 'u-boot-sunxi-with-spl.bin' failed
make: *** [u-boot-sunxi-with-spl.bin] Error 1
Quoted 4 lines
Quoted 1 line
If it matters, compiler is: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
Do you know what version of python you are using? I cannot imagine what is happening here.
$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Quoted 1 line
Quoted 1 line
Quoted 1 line

Quoted 8 lines

Quoted 4 lines
Quoted 1 line
and fwiw, this is on Ubuntu 16.04 LTS.
That's what I am using too. This is really mystifying. Are you able to debug the python code?
If you give me some pointers/suggestions, I'd be glad to, but I don't currently have much time to go wandering too deep into the uboot weeds.

My guess is that you have a tools.py file somewhere in your Python site_packages. You should be able to test this with:

python

Quoted 1 line

import tools

Perhaps 'dpkg -S tools.py' will tell you what package installed it.

If you don't get an error then it suggests you already have this package. That in turn would suggest that the fix is that the path should be prepended instead of appended at the top of binman.py.

Regards,
Simon

Kevin Hilman

author

2017-06-02 20:44 UTC #6 lore raw

Quoted 54 lines · Simon Glass

Hi Kevin,
Quoted 42 lines · Kevin Hilman
Quoted 40 lines · Simon Glass
Hi Kevin,
Quoted 37 lines · Kevin Hilman
Quoted 25 lines · Simon Glass
Hi Kevin,
Quoted 22 lines · Kevin Hilman
While trying to build v2017.05 for sun5i-r8-chip (CHIP_defconfig), I get the following build error. I'm not familiar with binman, so not sure what I should be looking for.
$ CROSS_COMPILE=arm-linux-gnueabihf- make
[...]
 LD      spl/drivers/serial/built-in.o
 LD      spl/drivers/built-in.o
 LD      spl/common/built-in.o
 LD      spl/lib/built-in.o
 LD      spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
MKSUNXI spl/sunxi-spl.bin
BINMAN u-boot-sunxi-with-spl.bin
binman: 'module' object has no attribute 'FinaliseOutputDir' Makefile:1107: recipe for target 'u-boot-sunxi-with-spl.bin' failed
make: *** [u-boot-sunxi-with-spl.bin] Error 1
Quoted 4 lines
Quoted 1 line
If it matters, compiler is: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
Do you know what version of python you are using? I cannot imagine what is happening here.
$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
and fwiw, this is on Ubuntu 16.04 LTS.
That's what I am using too. This is really mystifying. Are you able to debug the python code?
If you give me some pointers/suggestions, I'd be glad to, but I don't currently have much time to go wandering too deep into the uboot weeds.

Quoted 7 lines

My guess is that you have a tools.py file somewhere in your Python site_packages. You should be able to test this with:
python
Quoted 1 line
import tools
Perhaps 'dpkg -S tools.py' will tell you what package installed it.

$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.

Quoted 3 lines

Quoted 3 lines
Quoted 3 lines
import os.path
import tools
print os.path.abspath(tools.__file__)

/usr/local/lib/python2.7/dist-packages/tools/__init__.pyc

Quoted 1 line

Quoted 1 line
Quoted 1 line

So since this is in /usr/local, dpkg -S didn't help, so it was something installed by pip. Turns out that it was the jira-python package, installed by pip that had installed this tools dir.

Quoted 3 lines

If you don't get an error then it suggests you already have this package. That in turn would suggest that the fix is that the path should be prepended instead of appended at the top of binman.py.

"pip uninstall jira-python" also did the trick, but prepending worked too. I suppose having a name slightly less generic than "tools" would also work.

Anyways, I got it building now, so I'll let you decide which is the "right way" to fix.

Thanks,

Kevin

[1]

$ git diff tools/binman/

tools/binman/binman.py +1 -1

index 857d698b4c24..535bcece274f 100755
@@ -17,7 +17,7 @@ import unittest
 
 # Bring in the patman and dtoc libraries
 our_path = os.path.dirname(os.path.realpath(__file__))
-sys.path.append(os.path.join(our_path, '../patman'))
+sys.path.insert(1, os.path.join(our_path, '../patman'))
 sys.path.append(os.path.join(our_path, '../dtoc'))
 sys.path.append(os.path.join(our_path, '../'))

Simon Glass

2017-06-21 03:29 UTC #7 lore raw

Hi Kevin,

Quoted 81 lines · Kevin Hilman

Quoted 54 lines · Simon Glass
Hi Kevin,
Quoted 42 lines · Kevin Hilman
Quoted 40 lines · Simon Glass
Hi Kevin,
Quoted 37 lines · Kevin Hilman
Quoted 25 lines · Simon Glass
Hi Kevin,
Quoted 22 lines · Kevin Hilman
While trying to build v2017.05 for sun5i-r8-chip (CHIP_defconfig), I get the following build error. I'm not familiar with binman, so not sure what I should be looking for.
$ CROSS_COMPILE=arm-linux-gnueabihf- make
[...]
 LD      spl/drivers/serial/built-in.o
 LD      spl/drivers/built-in.o
 LD      spl/common/built-in.o
 LD      spl/lib/built-in.o
 LD      spl/u-boot-spl
OBJCOPY spl/u-boot-spl-nodtb.bin
COPY spl/u-boot-spl.bin
MKSUNXI spl/sunxi-spl.bin
BINMAN u-boot-sunxi-with-spl.bin
binman: 'module' object has no attribute 'FinaliseOutputDir' Makefile:1107: recipe for target 'u-boot-sunxi-with-spl.bin' failed
make: *** [u-boot-sunxi-with-spl.bin] Error 1
Quoted 4 lines
Quoted 1 line
If it matters, compiler is: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
Do you know what version of python you are using? I cannot imagine what is happening here.
$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
and fwiw, this is on Ubuntu 16.04 LTS.
That's what I am using too. This is really mystifying. Are you able to debug the python code?
If you give me some pointers/suggestions, I'd be glad to, but I don't currently have much time to go wandering too deep into the uboot weeds.
Quoted 7 lines
My guess is that you have a tools.py file somewhere in your Python site_packages. You should be able to test this with:
python
Quoted 1 line
import tools
Perhaps 'dpkg -S tools.py' will tell you what package installed it.
$ python
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
import os.path
import tools
print os.path.abspath(tools.__file__)
/usr/local/lib/python2.7/dist-packages/tools/__init__.pyc
Quoted 1 line
Quoted 1 line
Quoted 1 line
So since this is in /usr/local, dpkg -S didn't help, so it was something installed by pip. Turns out that it was the jira-python package, installed by pip that had installed this tools dir.
Quoted 3 lines
If you don't get an error then it suggests you already have this package. That in turn would suggest that the fix is that the path should be prepended instead of appended at the top of binman.py.

Quoted 6 lines

"pip uninstall jira-python" also did the trick, but prepending worked too. I suppose having a name slightly less generic than "tools" would also work.
Anyways, I got it building now, so I'll let you decide which is the "right way" to fix.

OK thanks for helping with this. I sent a patch.

http://patchwork.ozlabs.org/patch/778613/

Regards,
Simon
[...]