Skip to contentSkip to conversation

disk: part_efi: Fix parameters passed to is_gpt_valid().

PATCH New Thierry Reding 7 participants 11 messages Nov 17, 2011

lore
Share & tools
lore

Thierry Reding

author
#0 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

Something apparently went wrong when the patch in commit deb5ca8 was applied. Commit f75dd58 changed the type of gpt_head to be a pointer and correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got applied, the gpt_head was again reverted to &(gpt_head), which was the state before deb5ca8.

This commit fixes the passing of gpt_head into is_gpt_valid().

Signed-off-by Thierry Reding <[email protected]>
---
 disk/part_efi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
disk/part_efi.c +2 -2
index e7f2714..ddf80a7 100644
@@ -130,7 +130,7 @@ void print_part_efi(block_dev_desc_t * dev_desc)
 	}
 	/* This function validates AND fills in the GPT header and PTE */
 	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-			 &(gpt_head), &gpt_pte) != 1) {
+			 gpt_head, &gpt_pte) != 1) {
 		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
 		return;
 	}

@@ -169,7 +169,7 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
 
 	/* This function validates AND fills in the GPT header and PTE */
 	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-			&(gpt_head), &gpt_pte) != 1) {
+			gpt_head, &gpt_pte) != 1) {
 		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
 		return -1;
 	}
Signature · 1 line
1.7.7.3
author
#1 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

Quoted 37 lines · Thierry Reding

Something apparently went wrong when the patch in commit deb5ca8 was applied. Commit f75dd58 changed the type of gpt_head to be a pointer and correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got applied, the gpt_head was again reverted to &(gpt_head), which was the state before deb5ca8.

This commit fixes the passing of gpt_head into is_gpt_valid().

Signed-off-by Thierry Reding <[email protected]>
---
 disk/part_efi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
disk/part_efi.c +2 -2
index e7f2714..ddf80a7 100644
@@ -130,7 +130,7 @@ void print_part_efi(block_dev_desc_t * dev_desc)
 	}
 	/* This function validates AND fills in the GPT header and PTE */
 	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-			 &(gpt_head), &gpt_pte) != 1) {
+			 gpt_head, &gpt_pte) != 1) {
 		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
 		return;
 	}

@@ -169,7 +169,7 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
 
 	/* This function validates AND fills in the GPT header and PTE */
 	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-			&(gpt_head), &gpt_pte) != 1) {
+			gpt_head, &gpt_pte) != 1) {
 		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
 		return -1;
 	}
Signature · 1 line
1.7.7.3

I had actually set "Doug Anderson <[email protected]>" on Cc because he was involved with the initial patch but for some reason he got stripped from Cc. Does anybody know why this is happening?

It seems like the To: header is unmodified so perhaps I should only be adding people with --to when sending out patches with "git send-email".

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111117/c608a265/attachment.pgp

#2 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

Quoted 3 lines · Thierry Reding

I had actually set "Doug Anderson <[email protected]>" on Cc because he was involved with the initial patch but for some reason he got stripped from Cc. Does anybody know why this is happening?

Probably Doug has received the first e-mail. I noted that git send-email strips the CC addresses (maybe to avoid SPAM ?), but the e-mail is sent anyway.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
author
#3 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

Quoted 9 lines · Stefano Babic
Quoted 3 lines · Thierry Reding

I had actually set "Doug Anderson <[email protected]>" on Cc because he was involved with the initial patch but for some reason he got stripped from Cc. Does anybody know why this is happening?

Probably Doug has received the first e-mail. I noted that git send-email strips the CC addresses (maybe to avoid SPAM ?), but the e-mail is sent anyway.

I don't think git send-email is stripping the Cc header because I've seen it work properly for other mailing lists. Perhaps the mailing list software is the culprit here? Could it be that it strips people that are subscribed (and will receive the mails anyway) but not those that aren't subscribed? Not that Tom Warren wasn't stripped from Cc.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111117/f716c827/attachment.pgp

#4 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

Doug is in the CC field (via Outlook in my 'U-Boot' folder @ work), and has been for every message in this thread.

Quoted 28 lines

-----Original Message-----
From: Thierry Reding [mailto:thierry.reding at avionic-design.de]
Sent: Thursday, November 17, 2011 8:08 AM
To: Stefano Babic
Cc: Tom Warren; Doug Anderson; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

* PGP Signed by an unknown key

Quoted 9 lines · Stefano Babic
Quoted 3 lines · Thierry Reding

I had actually set "Doug Anderson <[email protected]>" on Cc because he was involved with the initial patch but for some reason he got stripped from Cc. Does anybody know why this is happening?

Probably Doug has received the first e-mail. I noted that git send-email strips the CC addresses (maybe to avoid SPAM ?), but the e-mail is sent anyway.

I don't think git send-email is stripping the Cc header because I've seen it work properly for other mailing lists. Perhaps the mailing list software is the culprit here? Could it be that it strips people that are subscribed (and will receive the mails anyway) but not those that aren't subscribed? Not that
Tom Warren wasn't stripped from Cc.

Quoted 4 lines

Thierry

* Unknown Key
* 0xA2E3269F

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

#5 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

Agreed--I see myself in the CC from the start.

Thanks for Stephen to pointing to the fix that he already posted.

-Doug

---

Quoted 50 lines · Tom Warren

Doug is in the CC field (via Outlook in my 'U-Boot' folder @ work), and has been for every message in this thread.

Quoted 17 lines

-----Original Message-----
From: Thierry Reding [mailto:thierry.reding at avionic-design.de]
Sent: Thursday, November 17, 2011 8:08 AM
To: Stefano Babic
Cc: Tom Warren; Doug Anderson; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

* PGP Signed by an unknown key

Quoted 6 lines · Stefano Babic
Quoted 3 lines · Thierry Reding

I had actually set "Doug Anderson <[email protected]>" on Cc because he was involved with the initial patch but for some reason he got stripped from Cc. Does anybody know why this is happening?

Quoted 5 lines
Quoted 3 lines

Probably Doug has received the first e-mail. I noted that git send-email strips the CC addresses (maybe to avoid SPAM ?), but the e-mail is sent anyway.

I don't think git send-email is stripping the Cc header because I've

seen it

Quoted 1 line

work properly for other mailing lists. Perhaps the mailing list software

is

Quoted 1 line

the culprit here? Could it be that it strips people that are subscribed

(and

Quoted 8 lines

will receive the mails anyway) but not those that aren't subscribed? Not that
Tom Warren wasn't stripped from Cc.

Thierry

* Unknown Key
* 0xA2E3269F

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.

-----------------------------------------------------------------------------------

#7 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

In reply to Thierry Reding

Hi Thierry,

Quoted 11 lines · Stefano Babic
Quoted 9 lines · Thierry Reding
Quoted 4 lines

I had actually set "Doug Anderson <[email protected]>" on Cc because he was involved with the initial patch but for some reason he got stripped from Cc. Does anybody know why this is happening?

Probably Doug has received the first e-mail. I noted that git send-email strips the CC addresses (maybe to avoid SPAM ?), but the e-mail is sent anyway.

Quoted 5 lines

I don't think git send-email is stripping the Cc header because I've seen it work properly for other mailing lists. Perhaps the mailing list software is the culprit here? Could it be that it strips people that are subscribed (and will receive the mails anyway) but not those that aren't subscribed? Not that Tom Warren wasn't stripped from Cc.

Actually I know that sometimes there are such phenomena on the mailing list, but as yet I failed to find a reason for it. What I saw in the past is that the CC field of individual mails sent to individual subscribers has a reduced CC field with respect to the original mail, i.e. a mail I received had a stripped header compared to what is in the archives.

I will try to look into this when I find some time.

Cheers
Detlev

Signature · 7 lines
Whatever you do will be insignificant,
but it is very important that you do it.
                                        -- Mahatma Gandhi
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
#8 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

In reply to Thierry Reding

Thierry Reding wrote at Thursday, November 17, 2011 12:05 AM:

Quoted 7 lines

Something apparently went wrong when the patch in commit deb5ca8 was applied. Commit f75dd58 changed the type of gpt_head to be a pointer and correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got applied, the gpt_head was again reverted to &(gpt_head), which was the state before deb5ca8.

This commit fixes the passing of gpt_head into is_gpt_valid().

I already posted this patch a while back:
http://patchwork.ozlabs.org/patch/122485/

Signature · 1 line
nvpublic
author
#9 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

Quoted 11 lines · Stephen Warren

Thierry Reding wrote at Thursday, November 17, 2011 12:05 AM:

Quoted 7 lines

Something apparently went wrong when the patch in commit deb5ca8 was applied. Commit f75dd58 changed the type of gpt_head to be a pointer and correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got applied, the gpt_head was again reverted to &(gpt_head), which was the state before deb5ca8.

This commit fixes the passing of gpt_head into is_gpt_valid().

I already posted this patch a while back:
http://patchwork.ozlabs.org/patch/122485/

I wasn't aware of that. Please ignore then.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111117/f6cdf9cf/attachment.pgp

#10 lore raw

PATCH 1/1 disk: part_efi: Fix parameters passed to is_gpt_valid().

In reply to Thierry Reding
Quoted 43 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Thierry Reding
Sent: Thursday, November 17, 2011 12:35 PM
To: u-boot at lists.denx.de
Cc: Tom Warren
Subject: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().

Something apparently went wrong when the patch in commit deb5ca8 was applied. Commit f75dd58 changed the type of gpt_head to be a pointer and
correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got applied, the gpt_head was again reverted to &(gpt_head), which was the state before deb5ca8.

This commit fixes the passing of gpt_head into is_gpt_valid().

Signed-off-by Thierry Reding <[email protected]>
---
 disk/part_efi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
disk/part_efi.c +0 -0
index e7f2714..ddf80a7 100644
@@ -130,7 +130,7 @@ void print_part_efi(block_dev_desc_t * dev_desc)
 	}
 	/* This function validates AND fills in the GPT header

and PTE */

disk/part_efi.c +1 -1
 	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-			 &(gpt_head), &gpt_pte) != 1) {
+			 gpt_head, &gpt_pte) != 1) {
 		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
 		return;
 	}

@@ -169,7 +169,7 @@ int 
 get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
 
 	/* This function validates AND fills in the GPT header

and PTE */

disk/part_efi.c int get_partition_info_efi(block_dev_desc_t * dev_desc, int part, · line 175

Quoted 6 lines
disk/part_efi.c +1 -1
 	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
-			&(gpt_head), &gpt_pte) != 1) {
+			gpt_head, &gpt_pte) != 1) {
 		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
 		return -1;
 	}

I had already posted 2 revisions of this patch:

http://lists.denx.de/pipermail/u-boot/2011-November/109791.html
http://lists.denx.de/pipermail/u-boot/2011-November/109899.html

And they are included in this pull request:

http://lists.denx.de/pipermail/u-boot/2011-November/110017.html

Quoted 7 lines

1.7.7.3

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot