command.c: Enable auto tab for the editenv command
PATCH 1/1 command.c: Enable auto tab for the editenv command
Enable the auto completion (with TAB) of the environment variable name after the editenv command.
---
=== modified file 'common/command.c' (properties changed: -x to +x)
command.c 2010-04-08 15:12:44 +0000 renamed from command.c 2009-11-22 23:06:11 +0000 +3 -0
@@ -188,6 +188,9 @@ void install_auto_complete(void) { +#if defined(CONFIG_CMD_EDITENV) + install_auto_complete_handler("editenv", var_complete); +#endif install_auto_complete_handler("printenv", var_complete); install_auto_complete_handler("setenv", var_complete); #if defined(CONFIG_CMD_RUN)
PATCH 1/1 command.c: Enable auto tab for the editenv command
Hi Ralf,
Quoted 4 lines
Enable the auto completion (with TAB) of the environment variable name after the editenv command.
Signed-off-by Ralf Tr?benbach <[email protected]>
The idea looks good, but the patch as such is not usable:
[dzu at pollux u-boot-testing (misc-fixes)]$ git am -3 -u ~/p1
Applying: command.c: Enable auto tab for the editenv command
error: command.c: does not exist in index
fatal: sha1 information is lacking or useless (command.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Patch failed at 0001 command.c: Enable auto tab for the editenv command When you have resolved this problem run "git am -3 --resolved". If you would prefer to skip this patch, instead run "git am -3 --skip". To restore the original branch and stop patching run "git am -3 --abort". [dzu at pollux u-boot-testing (misc-fixes|AM)]$
How did you create the patch? Please follow the instructions[1] in order to make life easier for everybody.
Quoted 3 lines
---
=== modified file '
common/command.c' (properties changed: -x to +x)
This also looks strange - we certainly don't want execute rights on source files.
command.c 2010-04-08 15:12:44 +0000 line 196
Quoted 12 lines
command.c 2010-04-08 15:12:44 +0000 renamed from command.c 2009-11-22 23:06:11 +0000 +3
-0@@ -188,6 +188,9 @@ void install_auto_complete(void) { +#if defined(CONFIG_CMD_EDITENV) + install_auto_complete_handler("editenv", var_complete); +#endif install_auto_complete_handler("printenv", var_complete); install_auto_complete_handler("setenv", var_complete); #if defined(CONFIG_CMD_RUN)
Cheers
Detlev
[1] http://www.denx.de/wiki/U-Boot/Patches
Signature · 8 lines
Per Anhalter durch die Galaxis hat den gewissen Effekt, den auch eine Sendung von Monty Python ausl?st; es l??t alles, was direkt danach in Radio, im Fern- sehen oder sonstwo auftaucht, absolut l?cherlich wirken. Es hat dieses gewisse Etwas, das alles in einem gereinigten Licht erscheinen l??t. - Robert Cushman -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
PATCH 1/1 command.c: Enable auto tab for the editenv command
Hello Detlev,
you are right (sorry). I've used Bazzar to create the patch (since we use Bazzar for version control here). I'm currently working on getting correct formatted patches (or switch to git for that).
I'll resend the patch next week.
Ralf
Quoted 75 lines
-----Original Message-----
From: Detlev Zundel [mailto:dzu at denx.de]
Sent: Friday, April 09, 2010 10:18 AM
To: Tr?benbach Ralf
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH]command.c: Enable auto tab for the editenv commandHi Ralf,
Quoted 1 line
Enable the auto completion (with TAB) of the environment
variable name
Quoted 3 lines
after the editenv command.
Signed-off-by Ralf Tr?benbach <[email protected]>The idea looks good, but the patch as such is not usable:
[dzu at pollux u-boot-testing (misc-fixes)]$ git am -3 -u ~/p1
Applying:command.c: Enable auto tab for the editenv command
error:command.c: does not exist in index
fatal: sha1 information is lacking or useless (command.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Patch failed at 0001command.c: Enable auto tab for the editenv command
When you have resolved this problem run "git am -3 --resolved". If you would prefer to skip this patch, instead run "git am -3 --skip".
To restore the original branch and stop patching run "git am -3 --abort".
[dzu at pollux u-boot-testing (misc-fixes|AM)]$How did you create the patch? Please follow the instructions[1] in order to make life easier for everybody.
Quoted 3 lines
---
=== modified file '
common/command.c' (properties changed: -x to +x)This also looks strange - we certainly don't want execute rights on source files.
command.c 2010-04-08 15:12:44 +0000 line 196
Quoted 12 lines
command.c 2010-04-08 15:12:44 +0000 renamed from command.c 2009-11-22 23:06:11 +0000 +3
-0@@ -188,6 +188,9 @@ void install_auto_complete(void) { +#if defined(CONFIG_CMD_EDITENV) + install_auto_complete_handler("editenv", var_complete); +#endif install_auto_complete_handler("printenv", var_complete); install_auto_complete_handler("setenv", var_complete); #if defined(CONFIG_CMD_RUN)Cheers
Detlev[1] http://www.denx.de/wiki/U-Boot/Patches
Signature · 12 lines
Per Anhalter durch die Galaxis hat den gewissen Effekt, den auch eine Sendung von Monty Python ausl?st; es l??t alles, was direkt danach in Radio, im Fern- sehen oder sonstwo auftaucht, absolut l?cherlich wirken. Es hat dieses gewisse Etwas, das alles in einem gereinigten Licht erscheinen l??t. - Robert Cushman -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de